[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-03 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-179412574 Without the patch, using version 1.9.1 of maven-scm-api and maven-scm-provider-gitexe, I am running into git add error that is different: ``` [INFO] Check

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178984032 Maven passes `release-pom.xml` and `pom.xml` to the `GitCheckInCommand`. Previously, it would attempt to `git add` both before doing the `git commit`. Naturally,

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178941997 why the git add append the subdir path again to the pom.xml? This does not happen with maven release prepare goal. ``` [WARNING] Ignoring unrecognized lin

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178940863 You are right the patch #31 does not work probably if the pom.xml is not in the root directory of git repo. I removed pomFileName in pom.xml and also in the command

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178935559 I am getting same error: ``` [INFO] Checking in modified POMs... [INFO] Executing: /bin/sh -c cd /scratch/jenkinsci-ws/workspace/apic-int-ifm_apic_rest

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178931065 I haven't tried #26 and I do not think it makes any difference here. I think the problem is with #31 in the way it tries to calculate the set of files fo be adde

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178930248 What if you remove the default 'perform' execution completely and instead append the parameter to `` as `-DpomFileName=apic_int/comp/ifm_apic_rest/pom.xml` ? -

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178930429 There are actually 2 separate patches: patch #31 and patch #26. Which one has the problem? I applied your patch #31 and I tried it and got same error.

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178929085 Actually I thnk you may be onto something here. It looks like the patch may have a problem with relative paths, when it is not run from the root of the git repos

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178926905 The command line supplied to Jenkins maven release field in maven project: "-Dresume=false -Prelease-profile release:prepare-with-pom release:perform -s ${M2_H

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178918591 What is the command line you are using, and what is the directory you are running it from, and where is the root of your git repo (my guess is `/scratch/jenkinsc

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178907308 I do not specify pomFileName for maven release prepare plugin here. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178900813 With maven-release-plugin version 2.5 and dependency on maven-scm-provider-gitexe version 1.9.1 including that configuration (our pom.xml is not on root of git r

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178898208 @indrgun I tested it on a vanilla project, which did not have any major config alterations for the release plugin. I wonder if the following bit of confi

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2016-02-02 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-178854338 HI sergei, I patched the latest scm with the patch on top, built it as version 1.9.5-beta-1 and use it with version 2.5 maven release plugin as such:

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2015-10-30 Thread indrgun
Github user indrgun commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-152661620 When can this PR be approved and merged? We have migrated from SVN to Git/Stash but we can't use release-with-pom anymore and the team is not happy. --- If your proj

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2015-09-19 Thread sergei-ivanov
Github user sergei-ivanov commented on the pull request: https://github.com/apache/maven-scm/pull/31#issuecomment-141722548 Rebased the PR on top of the current master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] maven-scm pull request: SCM-706 finer-grained handling of file ren...

2015-04-14 Thread sergei-ivanov
GitHub user sergei-ivanov opened a pull request: https://github.com/apache/maven-scm/pull/31 SCM-706 finer-grained handling of file rename status for gitexe provider... ..., rename source is not added to the set of files for commit operation anymore This is an actualisation