[GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-06-15 Thread wangyf2010
Github user wangyf2010 closed the pull request at: https://github.com/apache/maven-enforcer/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-06-04 Thread Wang, Simon
Any update for this PR? Please let me know if have any concerns. Regards Simon On Jun 2, 2014, at 10:16 PM, Wang, Simon wrote: > Thanks for your comments, Karl! > > I added document for this rule, please review it. > https://github.com/apache/maven-enforcer/pull/13 > > About enhance the rule

Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-06-02 Thread Wang, Simon
Thanks for your comments, Karl! I added document for this rule, please review it. https://github.com/apache/maven-enforcer/pull/13 About enhance the rule to detect repository entries in settings.xml/pom independent of mirrorOf settings. I think it’s out of scope for this rule, because this rule

Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-05-30 Thread Karl Heinz Marbaise
Hi Simon, so after checking it i found the point... I have defined mirrorOf * as usual in case of using a repository manager...in my settings.xml which looks like the following: nexus * http://.../nexus/.. So with the above i can add as much repository entries in my setti

Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-05-29 Thread Wang, Simon
Hi, Karl, Thanks for your comments. I did dig into requireNoRepositories.html, the purpose for that rule is: detect whether pom and pom’s parents contains repositories definition. That make sense to guide users to use correct convention (not define repositories in pom files). But “BannedReposit

Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-05-29 Thread Karl Heinz Marbaise
Hi Simon, I have taken a look into your suggestions I have a couple of thoughts about it ... First there exists already a rule to avoid repositories (http://maven.apache.org/enforcer/enforcer-rules/requireNoRepositories.html) which can be used and is has an option to allow particular re

[GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-05-28 Thread wangyf2010
GitHub user wangyf2010 opened a pull request: https://github.com/apache/maven-enforcer/pull/13 [MENFORCER-193]: Add new rule: BannedRepositories to ban specified repos... There are use cases that need to ban specified repositories. Ex. one enterprise migrate their repositories fr