Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Hello all The proposed new compiler plugin has been updated with the following changes: * Use of ASM for rewriting the module-info.java file on JDK older than 22 has been reintroduced (for reproductible builds). * Support for overwriting module-info.java in the tests has been reimpleme

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-24 à 14 h 25, Robert Scholte a écrit : Just one question: what will happen with Maven3 users (or any other tool) if one of their dependencies has this special type? Rephrasing as "what will happen with a Maven 3 plugin running on Maven 4 without having been updated to the Maven 4 API

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-24 à 14 h 13, Robert Scholte a écrit : What I'm seeing here is: service provides both a module descriptor with the services, so it can be used on the modulepath At the same time it also provides a META-INF/services to make it compatible for the classpath as well. This is awesome to

RE: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

t: Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2 Robert, you might missed this quite long thread that happened about a year ago: https://lists.apache.org/thread/x99pj75vfn5p3xtr0mvhgs5s4935j3gn Just to get into the picture, and not repeat the whole story again :) Thanks T O

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

> > -Original Message- > From: Tamás Cservenák > Sent: donderdag 24 oktober 2024 14:01 > To: Maven Developers List > Subject: Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin > beta-2 > > Robert, > > you might missed this quite

RE: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

-Original Message- From: Martin Desruisseaux Sent: donderdag 24 oktober 2024 13:38 To: dev@maven.apache.org Subject: Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2 Le 2024-10-24 à 13 h 17, Robert Scholte a écrit : (about automatic modules) > What

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Inline responses... > > -Original Message- > From: Martin Desruisseaux > Sent: donderdag 24 oktober 2024 12:38 > To: dev@maven.apache.org > Subject: Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin > beta-2 > > Le 2024-10-24 à 12 h 07, Robert Scholte

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-24 à 13 h 17, Robert Scholte a écrit : (about automatic modules) What is effectively the difference here? As long as there's no reference from a module descriptor to a module (either named or automatic) there should be no difference. The purpose of automatic modules is to allow th

RE: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Inline responses... -Original Message- From: Martin Desruisseaux Sent: donderdag 24 oktober 2024 12:38 To: dev@maven.apache.org Subject: Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2 Le 2024-10-24 à 12 h 07, Robert Scholte a écrit : > > Can you expla

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-24 à 12 h 07, Robert Scholte a écrit : Can you explain the problem you're trying to solve? In particular I don't understand the need for modular-jar and classpath-jar, as currently both classpath and modulepath are already build up correctly based on the module descriptors. The p

RE: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

om: Martin Desruisseaux Sent: woensdag 23 oktober 2024 16:40 To: dev@maven.apache.org Subject: Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2 Le 2024-10-23 à 16 h 22, Ralph Goers a écrit : > What is the easiest way to determine what has been changed? When I was > wo

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

On 24.10.24 11:03, Martin Desruisseaux wrote: About not trying anymore to be clever regarding -source versus -release options, there is good chance that this issue is mot since Maven 4 requires Java 17 for execution. Therefore, users should not have reason to use -source anymore. The concern ex

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-24 à 07 h 57, Olivier Lamy a écrit : I wonder if the changes have been ported to surefire and javadoc? Not yet, but indeed those plugins will also need to be updated. We may not be able to update them in same time as the compiler plugin. A consequence is that some tasks that should

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-24 à 08 h 20, Guillaume Nodet a écrit : Is there any technical reason why we could not port those ? About MCOMPILER-542 (a workaround that modified the module-info.class generated by javac versions before Java 22), there is no technical reason apart a desire to reduce dependencies

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Is there any technical reason why we could not port those ? Le mer. 23 oct. 2024 à 22:46, Jorge Solórzano a écrit : > Without delving into every detail, one concern I have is the inability to > use the option alongside and , MCOMPILER-582 >

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

I wonder if the changes have been ported to surefire and javadoc? Or maybe not needed as no impact? Sorry just a question from the peanut gallery (as I didn't have a look at the changes). But I remember suffering (because I was more involved at this time) a lot of issues in the past when JPMS was i

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Without delving into every detail, one concern I have is the inability to use the option alongside and , MCOMPILER-582 was a nice improvement, but I'm not sure if that behavior remains. In any case, in my opinion, relying on an empty workaro

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Le 2024-10-23 à 16 h 22, Ralph Goers a écrit : What is the easiest way to determine what has been changed? When I was working on Log4j’s JPMS support Maven’s handling of JPMS frequently caused problems and forced us to do some things I consider kind of ugly. The main changes are described the

Re: [DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

What is the easiest way to determine what has been changed? When I was working on Log4j’s JPMS support Maven’s handling of JPMS frequently caused problems and forced us to do some things I consider kind of ugly. Ralph > On Oct 23, 2024, at 7:12 AM, Guillaume Nodet wrote: > > Following the b

[DISCUSS] Merge JPMS work in upcoming maven-compiler-plugin beta-2

Following the beta-5 release, we're going to update a bunch of plugins (help welcome to port a few core plugins). In particular, I think the maven-compiler-plugin would benefit from a merge of Martin Deruisseaux's work around JPMS [1]. This leverages the javax.tools API directly, so will remove th