Re: [DISCUSS] Maven Core Plugins versioning

2024-03-12 Thread Romain Manni-Bucau
Hi Hervé, Think we can try to just move forward the v4 effort and if there are enough requests on v3 we would maintain it as a best effort but as it had been mentionned there is no more any real reason to do both as soon as maven v4 is officially out - ie final - IMHO. Romain Manni-Bucau @rmannib

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-12 Thread Herve Boutemy
using 4.x scheme looks simple and working: ok there is an exception with site, as there are always exceptions what is important is system prerequisites history: remember for JDK requirement? same for Maven version requirement just need to finish work on MPLUGIN-511 and we'll get the documentatio

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
Gary, "core plugins" are controlled by us, and they always followed this "standard" (version major was showing Maven API level). But true, for EXTERNAL plugins, this will be quite an interesting thing. They will probably solve the "migrated to Maven 4 API" by major version bump. Maven2 was "shor

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Gary Gregory
On Fri, Mar 8, 2024, 2:56 PM Michael Osipov wrote: > Am 2024-03-08 um 20:51 schrieb Gary Gregory: > > IMO, the old version + 0.10 is a recipe for confusion and explanations > for > > this and that exception. > > I totally agree with you, that is a horrible compromise. Do you see a > better way to

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Romain Manni-Bucau
Think site got slowly replaced by other alternatives - even to document mojos! - so today it is mainly about us and I also dont think limiting doxia 2 to maven 4 has much issues, there is no real request from outside for it AFAIK. >From a versioning standpoint I see really no reason to make a tran

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Michael Osipov
I plan to publish an announcement *before* I update anything or bump reporting plugins to the (now) next minor version. People will always complain -- regardless of what you do -- if they are unhappy. I don't expect you to waste to time for site, just skip it mentally. I will take care. Am 202

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
Sorry, 1989! On Fri, Mar 8, 2024 at 9:10 PM Tamás Cservenák wrote: > Michael, > > I understand, but then all that remains is +10 or +100 in versions, > trickeries, or whatever... > > Be prepared for "this works with that but does not with that other" types > of JIRA... > And my guess is that the

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
Michael, I understand, but then all that remains is +10 or +100 in versions, trickeries, or whatever... Be prepared for "this works with that but does not with that other" types of JIRA... And my guess is that the few who still use the site function of Maven will simply drop it. A big confusion i

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Michael Osipov
Am 2024-03-08 um 20:56 schrieb Tamás Cservenák: I agree with Gary, really really the simplest would be to NOT use Doxia 2 for Maven 3, as basically that IS the "plugin breakage" we are soon facing. This is unacceptable for me because that breaks two years of ongoing effort. I cannot expect pe

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
I agree with Gary, really really the simplest would be to NOT use Doxia 2 for Maven 3, as basically that IS the "plugin breakage" we are soon facing. T On Fri, Mar 8, 2024 at 8:53 PM Gary Gregory wrote: > IMO, the old version + 0.10 is a recipe for confusion and explanations for > this and tha

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Michael Osipov
Am 2024-03-08 um 20:51 schrieb Gary Gregory: IMO, the old version + 0.10 is a recipe for confusion and explanations for this and that exception. I totally agree with you, that is a horrible compromise. Do you see a better way to reconcile both issues? I don't see any :-( ---

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Gary Gregory
IMO, the old version + 0.10 is a recipe for confusion and explanations for this and that exception. Gary On Fri, Mar 8, 2024, 2:40 PM Tamás Cservenák wrote: > Maarten, > > that would need a LOT of work, from maven plugin tools, IDEs and ALL the > stuff that _assumes_ that a plugin artifactId is

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
Maarten, that would need a LOT of work, from maven plugin tools, IDEs and ALL the stuff that _assumes_ that a plugin artifactId is either "maven-xxx-plugin" or "xxx-maven-plugin". Never looked into, but I guess that would be quite a big impact. T On Fri, Mar 8, 2024 at 8:22 PM Maarten Mulders w

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Maarten Mulders
It might've been proposed and rejected before, but how about 1. maven4-compiler-plugin -or- 2. maven-compiler-plugin (with maven4/maven5/etc classifier) In both scenario's, we could still use semantic versioning as we do right now, and as Maven users probably expect us to adhere to. Thanks,

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Michael Osipov
Am 2024-03-08 um 17:20 schrieb Guillaume Nodet: I'm slightly hesitant about that. It seems to me plugins have mostly been compatible, so we very rarely used a major version switch, but we do have plugins in 3.12.1 for example, which would be translated to 3.0.12.1. Not even sure how the 4th digi

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Guillaume Nodet
Or maybe a 1 hundred bump: 3.12.1 -> 3.100.0 ? It may be more clear, as that's a number we don't usually reach... Le ven. 8 mars 2024 à 17:20, Guillaume Nodet a écrit : > > I'm slightly hesitant about that. > It seems to me plugins have mostly been compatible, so we very rarely > used a major v

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Guillaume Nodet
I'm slightly hesitant about that. It seems to me plugins have mostly been compatible, so we very rarely used a major version switch, but we do have plugins in 3.12.1 for example, which would be translated to 3.0.12.1. Not even sure how the 4th digit is supported... I wonder if an alternative propo

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Matthias Bünger
+1 Am 08.03.2024 um 13:00 schrieb Tamás Cservenák: So, can we agree on following (maybe even vote if needed)? I. Core Plugin Versioning Maven3 plugins carry 3.x as the major version number, and Maven4 plugins will carry 4.x major versions? II. Consequence: How to interpret Core plugin versions

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Romain Manni-Bucau
+1 without any strong opinion on doxia 2 for maven 3 in the future (no blocker IMHO but not the baseline too) Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
So, can we agree on following (maybe even vote if needed)? I. Core Plugin Versioning Maven3 plugins carry 3.x as the major version number, and Maven4 plugins will carry 4.x major versions? II. Consequence: How to interpret Core plugin versions See above. In short: the first element is "maven API

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
And a short addendum: Given, today there are still no Maven 4.x plugins nor Doxia 2.x reports out there (released), what if, we follow Michael intent BUT with a slight "bend": - the new Maven Site plugin that uses Doxia 2.0.0 and would carry version 4.0.0 (to be released) **should be Maven4 plugin

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
Just to clarify, explain myself but also FTR on thread: in case of report-plugins we basically have TWO requirements (or deps): - maven API level - doxia API level (that with 2.0.0 contains breaking changes) Basically, Maven4 supports 4.x plugins (that use new API) but also supports running 3,x p

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Romain Manni-Bucau
Hi Michael, Site 4.0.0 does not exist, there are only milestones (so no guarantee given in such a release) so not a big deal IMHO, we can align on Tamas proposal and just do a 3.(n+1) if we want to propose the changes to maven 3 (no big opinion on this one). So proposal sounds good to me: $maven.

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
Howdy, First, 4.0 is not out yet (check my remark in the initial mail "M releases do not count"). Second, is there a plugin out there that also includes a report? (or in other words, you remember I was insisting to SPLIT OUT all the report stuff out of plugins) As if there is no such plugin, we

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Michael Osipov
Am 2024-03-08 um 11:19 schrieb Tamás Cservenák: So, can we agree on following (maybe even vote if needed)? I. Core Plugin Versioning Maven3 plugins carry 3.x as the major version number, and Maven4 plugins will carry 4.x major versions? See Maven Site Plugin 4.0, contains fundemantal changes i

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Anders Hammar
Sounds good to me. /Anders (mobile) Den fre 8 mars 2024 11:19Tamás Cservenák skrev: > So, can we agree on following (maybe even vote if needed)? > > I. Core Plugin Versioning > Maven3 plugins carry 3.x as the major version number, and Maven4 plugins > will carry 4.x major versions? > > II. Cons

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Tamás Cservenák
So, can we agree on following (maybe even vote if needed)? I. Core Plugin Versioning Maven3 plugins carry 3.x as the major version number, and Maven4 plugins will carry 4.x major versions? II. Consequence: How to interpret Core plugin versions See above. In short: the first element is "maven API

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-07 Thread Tamás Cservenák
Michael, I am unsure why it would not work? As I explained in my initial email, Maven2 plugins were 2.x, Maven3 plugins were 3.x, so why could not Maven4 be 4.x? I think that "maven plugin" is quite well defined (is not "just a jar"). While I would expect your "bump the major version" for some lib

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Michael Osipov
This is a general problem and cannot be solved. As soon as you need to break the plugin compat you need to bump the major version. That breakage does not need to be related to Maven at all. Upshot: No matter what you do, you will do it wrong. I would rely on MPLUGIN foo to manage he compat histo

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Matthias bünger
Hey all, my thoughts on these questions are quite that we should keep it as simple as it is: I see value in keeping the versioning and its semantics with the Maven API at the first slot. This makes it an easy to see indicator and keeps the experience /knowledge of long time Maven users. About t

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Romain Manni-Bucau
Ok, I'd just use semver prefixing the plugin with the intended maven version (unspecified what happens if not aligned). It is always how it got perceived and I think it is good enough. About the naming I agree the plugin suffix is quite pointless as the maven prefix since we have the groupId, addi

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Konrad Windszus
This is slightly differently described on https://maven.apache.org/plugins/ Core pluginsPlugins corresponding to default core phases (ie. clean, compile). They may have multiple goals as well. But I think the intention is clear: This should apply to all plugins maintai

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Tamás Cservenák
+1 to that definition On Wed, Mar 6, 2024 at 3:14 PM Konrad Windszus wrote: > Maven Core plugins are listed in https://maven.apache.org/plugins/. > But I would say that this versioning policy applies to all plugins in > groupId org.apache.maven.plugins….. > > Konrad > > > On 6. Mar 2024, at 15:

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Tamás Cservenák
Gary, maven "core plugins" are these https://maven.apache.org/plugins/ In short, Maven plugins that are maintained by this project at ASF. While there is a quite overlap with mojohaus etc, they are NOT core plugins T On Wed, Mar 6, 2024 at 3:09 PM Gary Gregory wrote: > One issue from a non-M

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Konrad Windszus
Maven Core plugins are listed in https://maven.apache.org/plugins/. But I would say that this versioning policy applies to all plugins in groupId org.apache.maven.plugins….. Konrad > On 6. Mar 2024, at 15:06, Gary Gregory wrote: > > One issue from a non-Maven dev (me) is that I have no idea wh

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Tamás Cservenák
Romain, we have multiple ONGOING issues: - site plugin IMHO must not be 4.x (as it is still a Maven3 plugin, it does not use Maven4 API). OTOH, it _is a breaking change_, so users need to adjust their builds once upgraded https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-site-pl

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Konrad Windszus
Hi, I agree with both I. and II. Not sure I understand the need for III. IMHO breaking changes for users should almost never happen (or if at all only after a long deprecation phase) Maybe you can give an example you have in mind for III? But to make it visible to users I would say such an extrao

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Gary Gregory
One issue from a non-Maven dev (me) is that I have no idea what is a Maven "core" plugin vs. not. I would make that obvious for users, and no, the "maven-" prefix does not make it obvious: maven-clean-plugin -> maven-core-clean-plugin or maven4-core-clean-plugin I'm also not sure the "plugin" suf

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Romain Manni-Bucau
Hi Tamas, Not sure I really got the issue, is it to do a breaking change without a maven-core bump? I tend to agree with you, ie the versioning is $mavenCoreMajor.$pluginMajor.$pluginMinor and no patch digit and guess it works good enough even for users, no? Best, Romain Manni-Bucau @rmannibucau

[DISCUSS] Maven Core Plugins versioning

2024-03-06 Thread Tamás Cservenák
Howdy, We have several topics that need to be discussed. I. Core Plugin Versioning History: When Maven2 was born, and started using plugins "as we know them today" (Maven 1 was a very different beast), the Core Plugin versions were started as 2.0 on purpose. Just check the Maven Central for hist