Re: [DISCUSS] Major changed for 4.x

2023-08-29 Thread Jochen Wiedmann
On Tue, Aug 22, 2023 at 9:35 AM Guillaume Nodet wrote: > * Support for XML entities / XInclude Careful with that one! You might open a flood of security reports like "If the included file looks like this, or that, then ..." Jochen -

Re: [DISCUSS] Major changed for 4.x

2023-08-28 Thread Guillaume Nodet
Le lun. 28 août 2023 à 08:04, Olivier Lamy a écrit : > Hi, > > On Tue, 22 Aug 2023 at 17:36, Guillaume Nodet wrote: > > > > Hi everyone, > > > > I hope you guys have been able to rest a bit during the summer (for those > > that are back to work already)... > > > > I've pushed a few important PRs

Re: [DISCUSS] Major changed for 4.x

2023-08-27 Thread Olivier Lamy
Hi, On Tue, 22 Aug 2023 at 17:36, Guillaume Nodet wrote: > > Hi everyone, > > I hope you guys have been able to rest a bit during the summer (for those > that are back to work already)... > > I've pushed a few important PRs in the past months and I'd really like to > get the discussion going arou

Re: [DISCUSS] Major changed for 4.x

2023-08-23 Thread Mark Derricutt
Interesting - I see between alpha-5 and alpha-7 - tiles-maven-pllugin seems to work again (noticed this building alpha-8-SNAPSHOT). That’s good to know - will make evaluating the new mixins easier as well. -- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine T

Re: [DISCUSS] Major changed for 4.x

2023-08-23 Thread Mark Derricutt
On 23/08/2023 at 9:46:16 PM, Guillaume Nodet wrote: > The two ITs for mixins are available at > > https://github.com/apache/maven-integration-testing/pull/280/commits/13173969007b5e3b307ef5b191ac2d52a23dce6c > Nice - that looks like it should work - does that unfold into the effective-pom at a

Re: [DISCUSS] Major changed for 4.x

2023-08-23 Thread Guillaume Nodet
The two ITs for mixins are available at https://github.com/apache/maven-integration-testing/pull/280/commits/13173969007b5e3b307ef5b191ac2d52a23dce6c Le mar. 22 août 2023 à 23:30, Mark Derricutt a écrit : > Definitely keen on seeing this, or the approach taken - as Maven 4.x > breaks the existi

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Mark Derricutt
Definitely keen on seeing this, or the approach taken - as Maven 4.x breaks the existing usage of tiles-maven-plugin so having something supported, that covers the same featureset would be good. Where in GIthub can I see the IT’s mentioned here? On 22/08/2023 at 7:32:12 PM, Guillaume Nodet wrot

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Gary Gregory
FWIW, I don't have an issue with XML in general, just the style we use. An as aside, I find it amusing to watch the JSON folks reinvent each and every wheel that XML has been using for decades. Gary On Tue, Aug 22, 2023, 10:34 AM Romain Manni-Bucau wrote: > @Gary Gregory thing is that we regu

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Romain Manni-Bucau
@Gary Gregory thing is that we regularly hear that but nobody (as in "not significantly enough") embraced polyglot so means the verbosity is something you note but don't really care after all probably (not 100% sure it would help to solve that since attributes have kind of the same cons, ie make t

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Gary Gregory
One of Maven's pain points (a criticism hear at least) it's verbosity due to the XML style where almost everything is an element. If I can more succinctly list my dependencies, I would consider that a first win in this new Era that will be highly visible to even the most casual user :-) Hopefully t

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Romain Manni-Bucau
@Gary it is the stage "you can do whatever you like on your side", even a pom.properties flavor would work. I assume one of the most requested feature will be to flatten attributes more than inlining them ("org.apache.foo:bar:1.2.3") but on the core side the challenge can be to not break too fast a

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Guillaume Nodet
Not directly, but a simple extension could allow that... Le mar. 22 août 2023 à 12:33, Gary Gregory a écrit : > Hi all, > > Would any of these changes allow me to write my POM's XML dependencies in a > single element where the GID, AID, and version are attributes (and not > child elements)? > >

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Gary Gregory
I should have said "primitive" attributes plus Strings (and maybe Durations). Gary On Tue, Aug 22, 2023, 8:03 AM Elliotte Rusty Harold wrote: > On Tue, Aug 22, 2023 at 10:33 AM Gary Gregory > wrote: > ="2.13.0" ... /> > > > > In general, I want the XML to more OO, where XML elements are object

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Elliotte Rusty Harold
On Tue, Aug 22, 2023 at 10:33 AM Gary Gregory wrote: ="2.13.0" ... /> > > In general, I want the XML to more OO, where XML elements are objects and > attributes are, well, attributes. That dog won't hunt for reasons that are not specific to Maven. In OO attributes can be arbitrarily complex stru

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Gary Gregory
Hi all, Would any of these changes allow me to write my POM's XML dependencies in a single element where the GID, AID, and version are attributes (and not child elements)? In general, I want the XML to more OO, where XML elements are objects and attributes are, well, attributes. Gary On Tue,

Re: [DISCUSS] Major changed for 4.x

2023-08-22 Thread Romain Manni-Bucau
Globally it looks good, the only minor detail I would make is that instead of inlining params in methods considered as API (extension points, the model reader for ex) I would use a "request" object so read(a, b) would become read(req) to enable use to make it evolving more reliably instead of relyi

[DISCUSS] Major changed for 4.x

2023-08-22 Thread Guillaume Nodet
Hi everyone, I hope you guys have been able to rest a bit during the summer (for those that are back to work already)... I've pushed a few important PRs in the past months and I'd really like to get the discussion going around those. Those are major changes that I think we should introduce in Ma