Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Vincent Siveton
> Another question might be: Does the relation > 1 sink -> 1 output file/stream > always hold or are there formats that might need to output multiple files? > In the later case, createSink( OutputStream ) would be troublesome. The relation should persist. Cheers, Vincent

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Hervé BOUTEMY
> > Then I think "Sink createSink( Writer writer )" should be removed. > > I prefer deprecated for backward compatibility issue. this method was added in 1.0-beta-1-SNAPSHOT: 1.0-beta-1 hasn't been released yet. Is there really any backward compatibility issue here?

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Hervé BOUTEMY
Le vendredi 07 novembre 2008, Benjamin Bentmann a écrit : > It might however be convenient to create an AbstractTextSinkFactory from > which all/most text-based sinks could inherit. Seems a good idea. This would ensure too that every text-based sinks have the same default encoding: it gives some c

Re: (output) encoding support in doxia-sink-api

2008-11-07 Thread Benjamin Bentmann
Hervé BOUTEMY wrote: For the next 1.0-beta-1 version, 2 methods have been added to SinkFactory interface to improve encoding support: - Sink createSink( File outputDir, String outputName, String encoding ) Sounds good. This would enable the caller to configure the desired output encoding for

(output) encoding support in doxia-sink-api

2008-11-07 Thread Hervé BOUTEMY
Hi folks, For the next 1.0-beta-1 version, 2 methods have been added to SinkFactory interface to improve encoding support: - Sink createSink( File outputDir, String outputName, String encoding ) - Sink createSink( Writer writer ) See [1] for the full interface. I worked with Vincent to implement