[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block

2015-06-20 Thread sugartxy
Github user sugartxy commented on the pull request: https://github.com/apache/maven/pull/53#issuecomment-113768295 Oops! I misunderstood. Thank u! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block

2015-06-20 Thread sugartxy
Github user sugartxy commented on the pull request: https://github.com/apache/maven/pull/53#issuecomment-113748452 @krosenvold sorry for the mistake I've made. Does it work now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block

2015-06-19 Thread sugartxy
Github user sugartxy commented on the pull request: https://github.com/apache/maven/pull/53#issuecomment-113709155 @jvanzyl Please let me know if you want something else to be done on this pull request before you could merge it. --- If your project is set up for it, you can reply

[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block

2015-06-19 Thread sugartxy
Github user sugartxy commented on the pull request: https://github.com/apache/maven/pull/53#issuecomment-113508412 @ifedorenko @jvanzyl thx. I will rewrite it using try-with-resources ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven pull request: #MNG-5844: Close IO Streams in finally block

2015-06-19 Thread sugartxy
GitHub user sugartxy opened a pull request: https://github.com/apache/maven/pull/53 #MNG-5844: Close IO Streams in finally block Place the close method in the finally clause, so we can ensure it always runs regardless of how the method exits. You can merge this pull request