[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-08-19 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 Will reopen issue if someone does take a look. Closing issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] maven pull request #88: [MNG-5910] Fixed the description of the POM referenc...

2016-08-19 Thread rajivpjs
Github user rajivpjs closed the pull request at: https://github.com/apache/maven/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-08-09 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 @hboutemy - changes were made as per discussion. Please review and sign off. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven issue #91: [MDEP-519] Implemented feature to add the description to ea...

2016-08-09 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/91 Closing this PR, as Herve mentions this won't be usable on the console. I think this ticket can be descoped. I am happy to reopen again, if it is required to. --- If your project is s

[GitHub] maven pull request #91: [MDEP-519] Implemented feature to add the descriptio...

2016-08-09 Thread rajivpjs
Github user rajivpjs closed the pull request at: https://github.com/apache/maven/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request #91: [MDEP-519] Implemented feature to add the descriptio...

2016-08-01 Thread rajivpjs
GitHub user rajivpjs opened a pull request: https://github.com/apache/maven/pull/91 [MDEP-519] Implemented feature to add the description to each artefact Implemented feature that will add the description if the project contains the description. I couldn't find any exisiting

[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-07-28 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 I know that you are busy. Could you please let me know whether there are any more changes to be done? Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven pull request #89: [MNG-5995] Removed maven-compat as it not required a...

2016-07-28 Thread rajivpjs
Github user rajivpjs closed the pull request at: https://github.com/apache/maven/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...

2016-07-27 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/89 You are right. I tried `/Users/rajivpjs/Desktop/Apache/Maven/rajivpjs/maven/mavenfixtarget/bin/mvn -f /path/to/pom.xml clean package -V` It shows version 3.3.9. Maybe you are right

[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...

2016-07-26 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/89 Hi Karl With my recent change, I compiled with an example project and I didn't have any issues. This is what I did as per the Jira task description: `mvn -DdistributionTargetF

[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...

2016-07-25 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/89 I realised that on Friday evening, after reading again. That's why I sent an e-mail to the mailing list to work out how to build with maven. I will check whether my changes work, by using

[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-07-25 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 Hi Karl I have now made further changes. Hopefully, it should be fine. Please review. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven pull request #88: [MNG-5910] Fixed the description of the POM referenc...

2016-07-25 Thread rajivpjs
Github user rajivpjs commented on a diff in the pull request: https://github.com/apache/maven/pull/88#discussion_r72126082 --- Diff: maven-model-builder/src/test/resources/poms/factory/complexEmptyAndMissing.xml --- @@ -31,21 +31,5 @@ activated-1

[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-07-20 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 @khmarbaise - is the issue solved? Can this be merged and this pull request closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...

2016-07-20 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/89 That's right. It worked. To build the project I ran mvn -Drat.skip=true clean package and mvn -Drat.skip=true validate. -Drat.skip=true was required so that I avoid the RATException. H

[GitHub] maven pull request #89: [MNG-5995] Removed maven-compat as it not required a...

2016-07-20 Thread rajivpjs
GitHub user rajivpjs opened a pull request: https://github.com/apache/maven/pull/89 [MNG-5995] Removed maven-compat as it not required anymore for maven … Please review and let me know of any changes. Thanks. You can merge this pull request into a Git repository by

[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-07-19 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 @khmarbaise - I have it working now. Please see changes. This works by enabling @Test annotations together with @Rule. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven issue #88: [MNG-5910] Fixed the description of the POM reference & add...

2016-07-19 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/88 I agree. I have applied the following to the test class: @Rule private ExpectedException expectedException = ExpectedException.none(); Within the test I have added

[GitHub] maven pull request #88: [MNG-5910] Fixed the description of the POM referenc...

2016-07-19 Thread rajivpjs
Github user rajivpjs commented on a diff in the pull request: https://github.com/apache/maven/pull/88#discussion_r71407078 --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java --- @@ -56,5 +56,26 @@ public void

[GitHub] maven pull request #88: [MNG-5910] Fixed the description of the POM referenc...

2016-07-19 Thread rajivpjs
Github user rajivpjs commented on a diff in the pull request: https://github.com/apache/maven/pull/88#discussion_r71405276 --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java --- @@ -56,5 +56,26 @@ public void

[GitHub] maven pull request #88: [MNG-5910] Fixed the description of the POM referenc...

2016-07-18 Thread rajivpjs
GitHub user rajivpjs opened a pull request: https://github.com/apache/maven/pull/88 [MNG-5910] Fixed the description of the POM reference & added an exce… Please review and let me know any changes. Thanks. You can merge this pull request into a Git repository by run

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 Which branch should I be looking at and in which project? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 That's great. Well done! I can see only the Aether changes were made. Did you make any Apache Maven changes? The text "from" in "Downloading from central", how wa

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 ok cool. I will wait for your reply. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven pull request #87: [MNG-5457] Added the repository id to show which rep...

2016-07-15 Thread rajivpjs
Github user rajivpjs closed the pull request at: https://github.com/apache/maven/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 Sure. I will close this for now and will reopen when we know Aether has reached the appropriate state. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 "Since Aether is currently in transition to us" - what do you mean? Is Aether going to come to Apache When do you think we will be able to fix this? --- If your project is set up for i

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 In your example, where is the snapshots at the end? Are we saying repository at index 0, is not correct? If yes, what is the best way to determine which repository is correct? --- If your project

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 What do you mean by squash the commit? Do you have any examples of Integration tests for Apache way of doing things? Thanks. > On 15 Jul 2016, at 18:37, Michael Osipov wr

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

2016-07-15 Thread rajivpjs
Github user rajivpjs commented on the issue: https://github.com/apache/maven/pull/87 I am working on another fix. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven pull request #87: [MNG-5457] Added the repository id to show which rep...

2016-07-14 Thread rajivpjs
GitHub user rajivpjs opened a pull request: https://github.com/apache/maven/pull/87 [MNG-5457] Added the repository id to show which repository is being … I have added the repository id within both the AbstractMavenTransferListener.java & Slf4jMavenTransferListener.

[GitHub] maven-plugins pull request #89: [MSITE-654] Removed the slash

2016-07-10 Thread rajivpjs
GitHub user rajivpjs opened a pull request: https://github.com/apache/maven-plugins/pull/89 [MSITE-654] Removed the slash This is my first Apache source code change and I my ICLA agreement has been filed. Could you please review this change in relation to MSITE-654? Please