[GitHub] maven-wagon issue #31: [WAGON-469] wagon-http does not enable Expect-Continu...

2016-12-09 Thread mcculls
Github user mcculls commented on the issue: https://github.com/apache/maven-wagon/pull/31 OK, squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-wagon pull request #31: [WAGON-469] wagon-http does not enable Expect-...

2016-12-09 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven-wagon/pull/31 [WAGON-469] wagon-http does not enable Expect-Continue by default There appear to be two issues: * Expect-Continue is not enabled for PUT when no configuration is provided * The default

[GitHub] maven pull request: [MNG-5981] upgrade Sisu to 0.3.3 to pick up li...

2016-02-17 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/78 [MNG-5981] upgrade Sisu to 0.3.3 to pick up lifecycle fix https://issues.apache.org/jira/browse/MNG-5981 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread mcculls
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169349800 @atanasenko thanks, that would be helpful --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/77 [MNG-5958] restore binary compatibility of Lifecycle.setPhases https://issues.apache.org/jira/browse/MNG-5958 While MNG-5805 restored binary compatibility of Lifecycle.getPhases it didn'

[GitHub] maven pull request: Upgrade to Eclipse/Sisu 0.3.2

2015-09-15 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/66 Upgrade to Eclipse/Sisu 0.3.2 http://wiki.eclipse.org/Sisu/Changelog Includes the following fixes of interest to Maven: [470780](https://bugs.eclipse.org/bugs/show_bug.cgi?id=470780

[GitHub] maven-plugins pull request: MSHADE-168: fix manifestEntries generi...

2015-06-02 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven-plugins/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: Switch to official Guice 4.0

2015-04-29 Thread mcculls
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/45#issuecomment-97418554 To be absolutely clear: * injection of SLF4J loggers using `@Inject` is not supported in the official Guice library * injection of SLF4J loggers using `@Requirement

[GitHub] maven pull request: Switch to official Guice 4.0

2015-04-29 Thread mcculls
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/45#issuecomment-97376230 The only difference remaining between this and sisu-guice is support for `@Inject`ion of SLF4J loggers, but I don't believe that's used much, if at all. Person

[GitHub] maven pull request: Switch to official Guice 4.0

2015-04-28 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/45 Switch to official Guice 4.0 For anyone interested in using Guice 4.0 with Maven :) PS. you should use Eclipse/Sisu 0.3.1 with Guice 4.0, luckily master branch is already using that version

[GitHub] maven pull request: [MNG-5738] Addition of command line flag '--le...

2015-03-05 Thread mcculls
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/32#issuecomment-77430685 @ChristianSchulte I believe that was recently fixed in master: https://github.com/apache/maven/commit/57a6196422873eaf2f00a282b33894a74dcfd19c --- If your project is set

[GitHub] maven pull request: Update Guava dependency to 18.0

2014-10-26 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/26 Update Guava dependency to 18.0 With the update of Guice to 3.2.3, the limitation on the Guava dependency no longer applies. You can merge this pull request into a Git repository by running

[GitHub] maven pull request: [MNG-5642] Support type 'bundle' with extensio...

2014-06-04 Thread mcculls
Github user mcculls commented on the pull request: https://github.com/apache/maven/pull/19#issuecomment-45094640 That looks like a documentation issue - I believe the line from the dependency plugin doc should read: ``` -Dartifact=groupId:artifactId:version[:type][:classifier

[GitHub] maven-plugins pull request: MSHADE-168: fix manifestEntries generi...

2014-05-10 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven-plugins/pull/22 MSHADE-168: fix manifestEntries generic type See http://jira.codehaus.org/browse/MSHADE-168 for background You can merge this pull request into a Git repository by running: $ git pull

maven pull request: Use Eclipse/Sisu 0.0.0.M2a milestone

2013-03-23 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven/pull/6 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven pull request: Use Eclipse/Sisu 0.0.0.M2a milestone

2013-03-23 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/6 Use Eclipse/Sisu 0.0.0.M2a milestone Just pushed the release button, so the new artifacts are on their way to central+mirrors. Changes from 0.0.0.M2: * Use trace when logging internals

maven pull request: Avoid mixing two flavours of Guice on the classpath.

2013-03-19 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven/pull/5 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven pull request: Avoid mixing two flavours of Guice on the classpath.

2013-03-19 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/5 Avoid mixing two flavours of Guice on the classpath. Note: the main blocker to using Google-Guice for Maven3 is the lack of a release with the new ProvisionListener API, which is needed to support

maven pull request: Fix call to SimpleLoggerFactory.reset method

2013-03-18 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/4 Fix call to SimpleLoggerFactory.reset method Use LoggerFactory to make sure we get the right instance to reset, as SimpleLoggerFactory.INSTANCE is not actually used by slf4j-simple&#

maven pull request: Reverting some unexpected aether dependency changes to ...

2013-03-15 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven/pull/3 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven pull request: Reverting some unexpected aether dependency changes to ...

2013-03-15 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/3 Reverting some unexpected aether dependency changes to the top-level pom Not sure if these dependency changes were meant to be included or not in the last commit to master, but given there were no

maven-integration-testing pull request: [MNG-5446] AM/PM inconsistency in m...

2013-03-15 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven-integration-testing/pull/3 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h

maven pull request: Use Eclipse/Sisu 0.0.0.M2 milestone

2013-03-13 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven/pull/2 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven pull request: Use Eclipse/Sisu 0.0.0.M2 milestone

2013-03-12 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/2 Use Eclipse/Sisu 0.0.0.M2 milestone See https://jira.codehaus.org/browse/MNG-5453 The major differences between the new Eclipse/Sisu artifacts and the old bundles are: * brand new

maven-integration-testing pull request: [MNG-5445] extract StringSearchMode...

2013-03-12 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven-integration-testing/pull/2 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h

maven-integration-testing pull request: MNG-5446: AM/PM inconsistency in mn...

2013-03-05 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven-integration-testing/pull/3 MNG-5446: AM/PM inconsistency in mng-3827 and mng-3864 ITs? See https://jira.codehaus.org/browse/MNG-5446 - Maven appears to ignore the PM setting when parsing "2008-11-09

maven-integration-testing pull request: [MNG-5445] extract StringSearchMode...

2013-03-05 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven-integration-testing/pull/2 [MNG-5445] extract StringSearchModelInterpolator issue into local IT plugin Rather than rely on external versions-maven-plugin to expose the underlying bug. You can merge this

maven-integration-testing pull request: [MNG-5445] Add test to check legacy...

2013-03-05 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven-integration-testing/pull/1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h

maven pull request: [MNG-5445] Fix missing requirement in AbstractStringBas...

2013-03-05 Thread mcculls
Github user mcculls closed the pull request at: https://github.com/apache/maven/pull/1 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven pull request: [MNG-5445] Fix missing requirement in AbstractStringBas...

2013-03-05 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven/pull/1 [MNG-5445] Fix missing requirement in AbstractStringBasedModelInterpolator See http://jira.codehaus.org/browse/MNG-5445 You can merge this pull request into a Git repository by running: $ git

maven-integration-testing pull request: [MNG-5445] Add test to check legacy...

2013-03-05 Thread mcculls
GitHub user mcculls opened a pull request: https://github.com/apache/maven-integration-testing/pull/1 [MNG-5445] Add test to check legacy StringSearchModelInterpolator See http://jira.codehaus.org/browse/MNG-5445 You can merge this pull request into a Git repository by running