[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-20 Thread marob
Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141778410 OK. I've tested 2.11-SNAPSHOT and can confirm the FIX is OK. Thanks! --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread marob
Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141720699 All lines with non recognized algorithms are deleted. So the newly added line and all other ecdsa fingerprints (if any). Rsa and dsa fingerprints are kept, with

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread marob
Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141702559 As you can see, my modifications are in the AbstractJschWagon.openConnectionInternal method. This method launches a real connection and cannot be easily tested

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-18 Thread marob
Github user marob commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141385842 It's been months... can we expect any merge one day? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-wagon pull request: Prevent fingerprints loss in know_hosts

2014-11-26 Thread marob
GitHub user marob opened a pull request: https://github.com/apache/maven-wagon/pull/16 Prevent fingerprints loss in know_hosts Currently, when adding new fingerprints the whole know_hosts file is rewritten from the loaded fingerprints. But only fingerprints with a compatible