[GitHub] maven-surefire issue #96: Adding individual rerun times to XML reports

2017-07-23 Thread lamyaa
Github user lamyaa commented on the issue: https://github.com/apache/maven-surefire/pull/96 @Tibor17 We kind of lost track of this PR. Is there anything else needed from me or can we get this merged? --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2016-01-11 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-170758490 @Tibor17 I merged the latest changes from master and resolved conflicts. I checked that it is still working as expected. Let me know if there is anything else I

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2016-01-08 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-170191124 @Tibor17 Hi Tibor. I'm doing great, thanks. Congrats on the release! :) I'll work on this in the next couple of days to resolve conflicts an

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2015-09-28 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/96#issuecomment-143900518 @Tibor17 I just tested this PR with your recent SUREFIRE-1144 fix. It still works. Again, the point here was really just to provide the same level of

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-28 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-143896973 @Tibor17 I just tried junit47 for the first time. Indeed, it seems to already run test at the end like I was attempting to do in this PR with junit4. Do you

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-27 Thread lamyaa
Github user lamyaa closed the pull request at: https://github.com/apache/maven-surefire/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-27 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143607529 Thanks for taking care of this @Tibor17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-27 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-143595744 @Tibor17 I'm very sorry for the delay. Please go ahead and finish this one if you have time. I'm not quite sure how XmlReporterRunTimeIT works

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-23 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-142768756 @Tibor17 I haven't had a chance to look at junit47 provider yet. I'm hoping to get to it (as well as surefire-1144) this weekend. --- If your project

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-17 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-141156540 @Tibor17 As I was preparing a new pull request with the simple change: ``createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-14 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140153614 @Tibor17 It seems that we have a check for elapsed time being null in TestSetRunListerner.java so we never instantiate WrappedReportEntry with a null elapsed time

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-14 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140152959 @Tibor17 ``createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix, testSetReportEntry.elapsedTimeAsString() )`` does fix the issue

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-14 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-140148135 @Tibor17 I tried just changing the last parameter like you suggested: ``createTestSuiteElement( ppw, testSetReportEntry, testSetStats, reportNameSuffix

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-09-13 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/98#issuecomment-139917934 @Tibor17 Please give me a couple of days to look again at this. It's not very fresh in my mind anymore :) --- If your project is set up for it, you can rep

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-02 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137231366 Oh, I see. I never looked into junit47 provide in detail. I'll look into it and see how rerunFailingTestsAtEndCount can fit there. --- If your project is s

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-02 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137210814 > I am not sure if test report would be updated after test run has finished. What was intended? From my understanding, rerunAtEnd again ca

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-09-02 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/102#issuecomment-137207940 > Did you run the build (mvn install)? Yes, I did run mvn install and made sure that the checkstyle plugin passes. Are you maybe just seeing some weird l

[GitHub] maven-surefire pull request: Option to rerun failures at the end o...

2015-08-31 Thread lamyaa
GitHub user lamyaa opened a pull request: https://github.com/apache/maven-surefire/pull/102 Option to rerun failures at the end of test execution This PR introduces an option to rerun failing tests at the end of a test suite execution. The current option

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-08-25 Thread lamyaa
Github user lamyaa closed the pull request at: https://github.com/apache/maven-surefire/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-08-24 Thread lamyaa
Github user lamyaa commented on the pull request: https://github.com/apache/maven-surefire/pull/99#issuecomment-134315056 Done, sorry about that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] maven-surefire pull request: [SUREFIRE-964] TEST-*.xml files gener...

2015-06-29 Thread lamyaa
GitHub user lamyaa opened a pull request: https://github.com/apache/maven-surefire/pull/99 [SUREFIRE-964] TEST-*.xml files generated by Surefire throw validation warnings in Eclipse for no grammer constraints (DTD or XML schema) referenced in the document This pull request adds an

[GitHub] maven-surefire pull request: [Surefire-1144] Time for testsuite on...

2015-06-15 Thread lamyaa
GitHub user lamyaa opened a pull request: https://github.com/apache/maven-surefire/pull/98 [Surefire-1144] Time for testsuite on commandline does not suit with the time value given in the report file https://issues.apache.org/jira/browse/SUREFIRE-1144 This pull request

[GitHub] maven-surefire pull request: Adding individual rerun times to XML ...

2015-06-04 Thread lamyaa
GitHub user lamyaa opened a pull request: https://github.com/apache/maven-surefire/pull/96 Adding individual rerun times to XML reports When a test fails and is rerun (with rerunFailingTestsCount > 0), the XML report only shows the time elapsed for the first run of the test met