[GitHub] maven-surefire pull request #113: SUREFIRE-1250: add exceptions to describe ...

2016-08-23 Thread kgyrtkirk
Github user kgyrtkirk closed the pull request at: https://github.com/apache/maven-surefire/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-26 Thread kgyrtkirk
Github user kgyrtkirk commented on the pull request: https://github.com/apache/maven-surefire/pull/113#issuecomment-222059866 i've moved the check into `ResolvedTest`. I now use the `MatchedPattern`...to check for exceptions. I've squashed my changes into

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-25 Thread kgyrtkirk
Github user kgyrtkirk commented on the pull request: https://github.com/apache/maven-surefire/pull/113#issuecomment-221739676 I've used `Pattern.compile` to keep the regexp's problem description; i thinked it makes it more clear how it will be used eventually.

[GitHub] maven-surefire pull request: SUREFIRE-1250: add exceptions to desc...

2016-05-24 Thread kgyrtkirk
GitHub user kgyrtkirk opened a pull request: https://github.com/apache/maven-surefire/pull/113 SUREFIRE-1250: add exceptions to describe usage rules of %regex @Tibor17 i've cleaned it up a bit; and added exception for multiple hashmarks too. tests have passed on my machine.