[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-14 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164675576 @Tibor17 Ok. But I still don't understand why it is working on my computers: I don't have guice-2.0.jar and exclude it was enough. For my i

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-14 Thread juherr
Github user juherr closed the pull request at: https://github.com/apache/maven-surefire/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164302567 Yes. I tried first by removing testng from local repo + full it-repo. Then I tried by removing full local repo + full it-repo

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164301074 > Do you have this path? Yes > I use Java 7 which is maybe the only one difference. Ok. But it is working well on my side with `o

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164294388 I've just followed your process and it's working well for me with `maven 3.0.5` and `Oracle JDK 1.8.0_66` on `Linux Mint 17.2 Rafaela`. I tried on 2

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164288512 `com/beust/jcommander/ParameterException` comes from jcommander which is a TestNG dependency. If it is missing, that means the dependency resolution is falling

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164262422 > committer in Maven ASF I'm open :) > Tests in error I confirm it is working for me with maven 3.3.

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-164237383 5.14.4 is not supposed to fail and excluding the bad dependency worked for me. I'll try again with an up2date maven. Which one are you using? --- If

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-08 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162840938 @Tibor17 Done. Are the commits ok for you, or do you want I try to squash and/or reword them? --- If your project is set up for it, you can reply to this email

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-12-07 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-162522326 @Tibor17 No, I can't! YOU created this pull-request ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-06 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-162313840 Ok, I will. But I'm not available today. Is tomorrow still ok for you? --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-03 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161557229 You mean 5.14.4 or higher. But I'm agree, and I hope nobody is using TestNG 5.x :D --- If your project is set up for it, you can reply to this email and

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-03 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161556520 > What about to replace "," with ", " in surefire parameter It won't work because TestNG need a `List in these 2 versions.

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-12-03 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-161554781 > What exactly the bug is? `configure(Map)` from 5.14.1 and 5.14.2 is transforming `List` into a `String` with a space as separator. Then, `config

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160476785 In fact, `configure(CommandLineArgs)` may help to fix 5.14.1 and 5.14.2. But it will be more work and time. --- If your project is set up for it, you can

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160476223 > Do you need any help from my side? Yes, decide something :) Currently, the 5.14.2 and 5.14.3 tests are disable because of TestNG issues. 5.14.1

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160474911 Current status: 5.14.3 --- The jar is still available: https://github.com/cbeust/testng/blob/master/lib-supplied/guice-2.0.jar It

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160427809 > [WARNING] The POM for org.testng:testng:jar:5.14.3 is invalid, transitive dependencies (if any) will not be available: 1 problem was encountered while build

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160395575 As you proposed before `resetInitialGoals( version )` seems to work as expected. I'm not sure more profiles will help here. I'm trying `addGo

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160335454 I got it for 5.13 and 5.14.2: like reporter, listener attribute has changed too. I will fix it asap. I'm open for help with 5.14.3 --- If

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160334856 Some artifacts was corrupted before. Now, they are the same than central. For 5.14.3: - > [WARNING] The POM for org.testng:testng:jar:5.1

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-27 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160191413 I'm not sure to understand. The test with TestNG 6.0 and 6.9.9 is working, right? --- If your project is set up for it, you can reply to this emai

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-27 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-160169598 Current status: ``` Tests in error: testNgListenerReporter[3: TestNG 5.13](org.apache.maven.surefire.its.CheckTestNgListenerReporterIT): Exit

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-26 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-16224 Thank! I missed `resetInitialGoals( version )` before. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-26 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/107#issuecomment-159995366 @Tibor17 I tried to add some test cases in `TestNgListenerReporter` but I don't know how to override the testng version used by the test. Currently, i

[GitHub] maven-surefire pull request: [SUREFIRE-1194] reporter argument doe...

2015-11-20 Thread juherr
GitHub user juherr opened a pull request: https://github.com/apache/maven-surefire/pull/107 [SUREFIRE-1194] reporter argument does not work for TestNG You can merge this pull request into a Git repository by running: $ git pull https://github.com/juherr/maven-surefire

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-10-13 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-147729243 087c7c3c4b54000fae6ea722a0119ab76f05b5c1 is missing, but not a problem for me :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-10-13 Thread juherr
Github user juherr closed the pull request at: https://github.com/apache/maven-surefire/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144193053 I updated ranges with your comment https://github.com/apache/maven-surefire/pull/106#issuecomment-143793736 About the documentation, I prefer to not add

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144010693 @Tibor17 I didn't catch what I should add in the documentation as only dataproviderthreadcount is tested for the moment. --- If your project is set up f

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144008010 In fact, they are taking effects in TestNG, but as I said, they are only useful in specific cases. I don't know yet if it is a TestNG issue or not. I will

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-29 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-144005599 Yes, https://github.com/juherr/maven-surefire/commit/5ac824733ea4b8201e8acd5c1d6cead0301340ab will avoid exception in TestNG if parameters are set. I&#

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143768585 It's not a problem of time but I just want to understand what I'm doing. I'm talking about an compile dependency (scoped provided) where, a

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143764774 For my information, why not updating the testng dependency as I did it in #105? I'll try to add some tests for suite thread count. --- If your pr

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143743363 Sometime code is easier than explainations :) I updated #105. Feel free to comment. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143733741 Since 5.10, `suite.setDataProviderThreadCount()` is available but surefire doesn't use it. I'd like to add ```

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-143677994 I have some time but the support of `dataproviderthreadcount` is not as easy as expected. You can see my comment: https://github.com/apache/maven-surefire/pull

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-28 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143677343 I had time to analyze and I found that `dataProviderThreadCount` is taken into account only when `m_commandLineTestClasses != null || m_commandLineMethods

[GitHub] maven-surefire pull request: [SUREFIRE-1179] integration test

2015-09-26 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/106#issuecomment-143522916 Awesome! I should have time this week to close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-24 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-142852570 Thank! I will have a look but I'm not sure to succeed to propose something before end of the month. At least, it should be available for the EOY re

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-19 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-141709744 Are we agree that the current PR is more about parameters than threading? Before the fix: "-suitethreadpoolsize" and "-dataproviderthreadco

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-18 Thread juherr
Github user juherr commented on the pull request: https://github.com/apache/maven-surefire/pull/105#issuecomment-141488763 I will try to update it next week. What is the deadline if I want the fix in the next release? > See how the ITs are written in surefire-integrat

[GitHub] maven-surefire pull request: Quick fix for SUREFIRE-1177 and SUREF...

2015-09-18 Thread juherr
GitHub user juherr opened a pull request: https://github.com/apache/maven-surefire/pull/105 Quick fix for SUREFIRE-1177 and SUREFIRE-1179 You can merge this pull request into a Git repository by running: $ git pull https://github.com/juherr/maven-surefire arg-config

[GitHub] maven-surefire pull request: [SUREFIRE-1154] TestNG should be able...

2015-05-03 Thread juherr
Github user juherr closed the pull request at: https://github.com/apache/maven-surefire/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven-surefire pull request: TestNG should be able to run its own ...

2015-04-20 Thread juherr
GitHub user juherr opened a pull request: https://github.com/apache/maven-surefire/pull/90 TestNG should be able to run its own tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/juherr/maven-surefire testng-run-testng