[GitHub] maven issue #101: Spelling api

2017-02-03 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/101 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven issue #100: Spelling non-API change

2017-02-01 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven issue #100: Spelling non-API change

2017-01-31 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven issue #103: spelling: excident

2017-01-30 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 I can live with that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven issue #103: spelling: excident

2017-01-29 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 Well, ideally we'd pick things not likely to be typo'd (your second one would be `Depended`). Anyway, I'm more or less willing to take any pair of things you're happy w/.\

[GitHub] maven issue #103: spelling: excident

2017-01-29 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 https://proofwiki.org/wiki/Definition:Incident_(Graph_Theory) Offers "incident to" and "incident from". Offhand, I'd suggest moving away from graph th

[GitHub] maven issue #103: spelling: excident

2017-01-29 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 I studied graph theory starting in middle school. I know the other thing is a made up word. But, the problem is... consider lines... What is the opposite of a perpendicular line? Is it

[GitHub] maven issue #100: Spelling non-API change

2017-01-29 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 sonatype/plexus-sec-dispatcher#4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven issue #103: spelling: excident

2017-01-29 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/103 I doubt it. Do you understand the code enough to be able to / can you try to read it and then describe what the code is interested in describing? (try to avoid using anything that sounds similar to

[GitHub] maven issue #100: Spelling non-API change

2017-01-28 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 @michael-o : this PR is roughly "non-API change". I split off #101 for the API change (and included deprecation, but not docs, that's too much to ask). #102 is a bug fix, I think, so

[GitHub] maven issue #100: Spelling

2017-01-23 Thread jsoref
Github user jsoref commented on the issue: https://github.com/apache/maven/pull/100 @michael-o split -- please follow-up in #103 as that's a messier kettle --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] maven pull request #103: spelling: excident

2017-01-23 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/103 spelling: excident split from #100 This is for consistency. I know it's a public API. But, I don't know if this is the word you want. If it is, we can add the @Deprecated annotati

[GitHub] maven pull request #102: spelling: vertices

2017-01-23 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/102 spelling: vertices split from #100 I think this is a bug fix. I can't figure out how it could work otherwise. You can merge this pull request into a Git repository by running:

[GitHub] maven pull request #101: Spelling api

2017-01-23 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/101 Spelling api split from #100 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling-api Alternatively you can review and apply

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253963 --- Diff: maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/LifecycleExecutionPlanCalculatorStub.java --- @@ -88,7 +88,7 @@ public

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97254243 --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java --- @@ -67,7 +67,7 @@ protected void

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253779 --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionRequest.java --- @@ -108,14 +108,14 @@ public MetadataResolutionRequest

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253878 --- Diff: maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java --- @@ -105,7 +105,7 @@ public ProjectSorter( Collection projects

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253624 --- Diff: maven-compat/src/main/java/org/apache/maven/repository/MetadataGraphNode.java --- @@ -57,7 +57,7 @@ public MetadataGraphNode addIncident

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/maven/pull/100#discussion_r97253891 --- Diff: maven-core/src/main/java/org/apache/maven/repository/DelegatingLocalArtifactRepository.java --- @@ -61,7 +61,7 @@ public void setIdeWorkspace

[GitHub] maven pull request #100: Spelling

2017-01-22 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/maven/pull/100 Spelling You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/maven spelling Alternatively you can review and apply these changes as the patch