[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-25 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 closing, https://github.com/apache/maven/commit/66fc74d6296ea0a33f8a9712dc5ed5eb3affd529 provides more comprehensive adjustments for JSR-330 annotations --- If your project is set up for it, you

[GitHub] maven pull request #116: Fix jsr-330 injection of DefaultArtifactDescriptorR...

2017-05-25 Thread jdillon
Github user jdillon closed the pull request at: https://github.com/apache/maven/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-24 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor's change is the more correct/ideal change to avoid future mismatch between plexus-annotation configuration and JSR-330 annotations. The problem is that plexus @Requirement injects direct

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-24 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor already created https://issues.apache.org/jira/browse/MNG-6233 but if you really need another issue I can file one just to fix this specific problem. Seems a bit odd though that you want

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-24 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Hey folks can we get some movement on this and/or https://github.com/apache/maven/compare/MNG-6233_maven-resolver-provider-jsr330 ATM its broken, either of these fixes the issue. --- If

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-15 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 @ifedorenko ftr I can close this, so but i'm confused about @michael-o comment that your change (I think that is what he meant) wasn't suitable for a patch release. --- If your project

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-15 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 @ifedorenko can close this if you like, wasn't sure what you mean about "a JIRA either way". If we close this and go with your changes (which if you have that mostly done for merge

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-14 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 @ifedorenko howdy, i'm fine to wait if you are gonna adjust to jsr330 that will be better generally for the project anyways IMO; i'm just trying to learn how to use the api and can live

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

2017-05-14 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 the plexus @Requirement injection is probably why this works at all in Maven, though w/o using maven-resolver-provider in a pure guice/sisu environment, this fails and causes NPE

[GitHub] maven pull request #116: Fix jsr-330 injection of DefaultArtifactDescriptorR...

2017-05-14 Thread jdillon
GitHub user jdillon opened a pull request: https://github.com/apache/maven/pull/116 Fix jsr-330 injection of DefaultArtifactDescriptorReader ... which is not setting the VersionRangeResolver; cause NPE when use w/o plexus requirement injection You can merge this pull request into

[GitHub] maven issue #81: Hook up gossip as slf4j backend and implement customized co...

2016-06-02 Thread jdillon
Github user jdillon commented on the issue: https://github.com/apache/maven/pull/81 @jvanzyl I believe the output issues were sorted, but was still seeing some odd failures with what looked like resolution mismatches, downloading a version of one artifact but ending up with a

[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...

2016-05-24 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-221441322 Updated gossip to 2.0.0 release which is now in central. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-24 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-221379335 Updated gossip to 2.0.0 which is now in com.planet57 namespace and I can make a release of it shortly. --- If your project is set up for it, you can reply to this email

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220746222 @michael-o yup, that is what is used internally by AnsiConsole.wrapOutputStream() to _help_ detect if it should strip sequences or not, but its not a proper public api to

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220744680 @michael-o the jansi library has some limited support to detect tty when wrapping and potentially strip sequenced. I've pushed a change which makes the gossip lis

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220743522 @michael-o w/o making more of the embedder aware of potential colorization its not easy to do. I will push an example which should make > and -l work but it does invo

[GitHub] maven pull request: [WIP] Hook up gossip as slf4j backend and impl...

2016-05-20 Thread jdillon
Github user jdillon commented on a diff in the pull request: https://github.com/apache/maven/pull/81#discussion_r64118607 --- Diff: pom.xml --- @@ -282,6 +282,16 @@ 1.1.7 true + +org.sonatype.gossip +gossip

[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...

2016-05-20 Thread jdillon
Github user jdillon commented on the pull request: https://github.com/apache/maven/pull/81#issuecomment-220737076 Pending a groupId update to get a release of gossip which has a few minor bug fixes to make the core-it-suite happy. --- If your project is set up for it, you can reply

[GitHub] maven pull request: Hook up gossip as slf4j backend and implement ...

2016-05-16 Thread jdillon
GitHub user jdillon opened a pull request: https://github.com/apache/maven/pull/81 Hook up gossip as slf4j backend and implement customized color renderer Replaces slf4j-simple with gossip-slf4j ( https://github.com/jdillon/gossip ) and adds support for colorized output

maven-surefire pull request: Allow includes and excludes to be read from fi...

2012-11-14 Thread jdillon
Github user jdillon closed the pull request at: https://github.com/apache/maven-surefire/pull/7 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

maven-surefire pull request: Allow includes and excludes to be read from fi...

2012-11-08 Thread jdillon
GitHub user jdillon opened a pull request: https://github.com/apache/maven-surefire/pull/7 Allow includes and excludes to be read from files You can merge this pull request into a Git repository by running: $ git pull https://github.com/sonatype/maven-surefire include