[GitHub] maven pull request: Locate .mvn in current directory

2015-07-16 Thread dsyer
Github user dsyer commented on the pull request: https://github.com/apache/maven/pull/58#issuecomment-122027101 My reading of the windows script is it works already (but it's harder to tell with batch scripts, for me at least). --- If your project is set up for it, you can rep

[GitHub] maven pull request: Locate .mvn in current directory

2015-07-16 Thread dsyer
GitHub user dsyer opened a pull request: https://github.com/apache/maven/pull/58 Locate .mvn in current directory There was a problem with the logic in the while loop that detects the base dir - it should first look in the current directory, otherwise you can't build

[GitHub] maven pull request: Added support for MAVEN_ARGS in mvn, mvnDebug,...

2015-07-16 Thread dsyer
Github user dsyer commented on the pull request: https://github.com/apache/maven/pull/49#issuecomment-121934925 It looks like `$MAVEN_CONFIG` is already used to prepend to the command line arguments. Isn't that enough? There is no comment or any other usage of `$MAVEN_CONFIG` so