[GitHub] maven-integration-testing pull request #15: [MNG-6084] Add test for JSR250 s...

2016-12-21 Thread dantran
Github user dantran closed the pull request at: https://github.com/apache/maven-integration-testing/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing issue #15: [MNG-6084] Add test for JSR250 support

2016-12-21 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-integration-testing/pull/15 already merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-25 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-wagon/pull/29 your patch fixes the site plugin ssh issue.I will need to implement similar wagon handling developed at maven-site-plugin https://github.com/mojohaus/wagon-maven-plugin/issues/6

[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-25 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-wagon/pull/29 confirm it works with maven-site-plugin but not with wagon-maven-plugin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-25 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-wagon/pull/29 @nfalco79 could you give https://github.com/mojohaus/wagon-maven-plugin/tree/master/src/it/ssh-it a try? update the pom to use your env. I am not able to get mine working. It always

[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-25 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-wagon/pull/29 @nfalco79 it is a long waited fix. Thank you and thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-wagon issue #24: [wagon-ftp] support for secure FTP connection

2016-11-23 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-wagon/pull/24 @wiiitek could you squash the commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven-wagon issue #29: [WAGON-467] Allow customisation of some SSH options

2016-11-23 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven-wagon/pull/29 @nfalco79, since i used the patch method and push this change. Git cant close this PR. Please close it yourself --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven issue #98: [MNG-6084] Support JSR 250 @PreDestory and @PostContruct

2016-11-20 Thread dantran
Github user dantran commented on the issue: https://github.com/apache/maven/pull/98 PR for maven-integration-testing https://github.com/apache/maven-integration-testing/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] maven-integration-testing pull request #15: [MNG-6084] Add test for JSR250 s...

2016-11-20 Thread dantran
GitHub user dantran opened a pull request: https://github.com/apache/maven-integration-testing/pull/15 [MNG-6084] Add test for JSR250 support You can merge this pull request into a Git repository by running: $ git pull https://github.com/dantran/maven-integration-testing

[GitHub] maven pull request #98: [MNG-6084] Support JSR 250 @PreDestory and @PostCont...

2016-11-20 Thread dantran
GitHub user dantran opened a pull request: https://github.com/apache/maven/pull/98 [MNG-6084] Support JSR 250 @PreDestory and @PostContruct You can merge this pull request into a Git repository by running: $ git pull https://github.com/dantran/maven master Alternatively you

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread dantran
Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141748659 please test wagon-2.11-SNAPSHOT --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread dantran
Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141748169 it is fixed and test with wagon-maven-plugin. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread dantran
Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141742580 hkr.getHostKey( host, null ) can return null where to orignal code does handle --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread dantran
Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141740614 I had to revert the change, its NPE wagon-ssh at wagon-maven-plugin/src/it/ssh-it test. --- If your project is set up for it, you can reply to this email and

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-19 Thread dantran
Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141720614 Just want confirm, only the addional line that inserted prior to your test get removed, or the entire file is empty out --- If your project is set up for it, you

[GitHub] maven-wagon pull request: Prevent fingerprints loss in known_hosts

2015-09-18 Thread dantran
Github user dantran commented on the pull request: https://github.com/apache/maven-wagon/pull/16#issuecomment-141582086 I will take a look. Please bare with me on my ignorance, and provide me a test case, promise to push 2.10.1 out for you. Even a pom using wagon-wagon-plugin also

[GitHub] maven-scm pull request: Add ssl support ( ie ssl:host:port://path ...

2014-05-04 Thread dantran
Github user dantran closed the pull request at: https://github.com/apache/maven-scm/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven-scm pull request: Add ssl support ( ie ssl:host:port://path ...

2014-04-21 Thread dantran
GitHub user dantran reopened a pull request: https://github.com/apache/maven-scm/pull/12 Add ssl support ( ie ssl:host:port://path ) Please help to review this enhancement which adds ssl support for perforce provider where 'ssl:' is added to before the ho

[GitHub] maven-scm pull request: Add ssl support ( ie ssl:host:port://path ...

2014-04-21 Thread dantran
Github user dantran closed the pull request at: https://github.com/apache/maven-scm/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven-scm pull request: Add ssl support ( ie ssl:host:port://path ...

2014-04-21 Thread dantran
GitHub user dantran opened a pull request: https://github.com/apache/maven-scm/pull/12 Add ssl support ( ie ssl:host:port://path ) Please help to review this enhancement which adds ssl support for perforce provider where 'ssl:' is added to before the ho