[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-09-08 Thread birkedal
Github user birkedal commented on the pull request: https://github.com/apache/maven/pull/50#issuecomment-138463968 It works just fine after the switch to backticks :+1: I have no opinion on whether that other idiom is better or not. One more little detail; if JAVA_HOME is

[GitHub] maven pull request: MNG-5837: Use a subshell, rather than the 'loc...

2015-06-08 Thread birkedal
Github user birkedal commented on the pull request: https://github.com/apache/maven/pull/50#issuecomment-109946813 Looks like there are still problems on Solaris after applying the patch. It seams like it's the `$()` that is problematic. See this comment on [MNG-5658](