Re: moving GitHub issue notifications to issues@maven.a.o

2017-10-21 Thread Uwe Barthel
+1 (non binding) -- bart...@x-reizend.de > On 21. Oct 2017, at 12:22, Hervé BOUTEMY wrote: > > Currently, comments are sent to dev@maven.a.o > > For our classical official Jira issue tracker, notifications are sent to > issues@maven.a.o > > If nobody objects (72h as usual), I'll ask infra

Re: [DISCUSSION] finishing Aether import: help find a new name

2016-08-26 Thread Uwe Barthel
everybody ok for: - name: "Artifact Resolver" - groupId: org.apache.maven.resolver - artifactId: resolver(-*) Why not more formal like: -name: Maven Artifact Resolver -groupId: org.apache.maven.[artifact | resolver] -artifactId: artifact-resolver

Re: [DISCUSSION] finishing Aether import: help find a new name

2016-08-05 Thread Uwe Barthel
more general than resolve? -- barthel - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: [DISCUSSION] finishing Aether import: help find a new name

2016-08-04 Thread Uwe Barthel
Hi, I know Aether is one of the catchy non telling name. But, why not leave Aether with new Maven namespace like org.apache.maven.aether? -- barthel - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional

Re: Aether

2016-06-24 Thread Uwe Barthel
Hi Gary, > What is the background story for Aether moving to and from Maven. @see: https://projects.eclipse.org/projects/technology.aether/reviews/termination-review -- barthel > On 24 Jun 2016, at 19:38, Gary Gregory wrote: > > Hi, > > What is the background story for Ae

Aether

2016-06-23 Thread Uwe Barthel
Hi, I would like to contribute to bring Aether to Apache Maven. The repositories git.apache.org, github.com) are available. The clearance is running. What are the next steps? The item (https://issues.apache.org/jira/browse/MNG-6006) contains less information. -- barthel

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. ITs passed. Merge conflict solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-integration-testing issue #14: MNG-6049: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Rename already done. ITs running locally right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven issue #70: MNG-6049: Adds version range result filter behaviour

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @talios Not yet public. I'll create a public example extension if the 3.4.0 release is available. See integration test: https://github.com/apache/maven-integration-testing/pull/14 Not ea

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 Relabelling commit from MNG-3092 to MNG-6049. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 Relabelling commit from MNG-3092 to MNG-6049. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-21 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67945228 --- Diff: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3092VersionRangeResultFilterExtensionTest.java --- @@ -0,0 +1,132

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-21 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @michael-o Please take a look at https://issues.apache.org/jira/browse/MNG-6049 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @michael-o Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-20 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67776474 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,73 @@ + + + + +http

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-20 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67776182 --- Diff: core-it-suite/src/test/resources/mng-3092/repo/org/apache/maven/its/mng3092/a/2.0-SNAPSHOT/a-2.0-20100408.111215-1.pom

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o Missing JARs added and changes included. Integration tests run successfully: ``` […] --- T

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @michael-o I'm working on integration tests right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-20 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 @michael-o Indent changes reverted. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: Roadmap Maven 3.4.0

2016-06-15 Thread Uwe Barthel
be the solution for this issue while we would not change the default behaviour or provide different strategies in Maven core. Adding a documentation and an example on this issue and everyone might implement a solution he likes/needs. -- barthel -

Re: maven git commit: [MNG-3507] keep green for success: INFO in blue (DEBUG is cyan)

2016-06-14 Thread Uwe Barthel
st different to my own customized console color it's maybe unconfortable for me to read. My suggestion: DEBUG/INFO: leave as is, maybe make DEBUG bold but don’t change the color. WARNING: bold yellow ERROR: bold red Regards, -- barthel > On 15 Jun 2016, at 08:19, Hervé BOUTEMY wrot

[GitHub] maven-integration-testing issue #14: MNG-3092: Adds integration tests for ve...

2016-06-14 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven-integration-testing/pull/14 @michael-o I changed something based on your comments. * Duplication of version number removed in ```mng-3092/filter-extensionpom.xml``` * Version number changed in JavaDoc

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-14 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67101198 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/pom.xml --- @@ -0,0 +1,74 @@ + + + + +http

[GitHub] maven-integration-testing pull request #14: MNG-3092: Adds integration tests...

2016-06-14 Thread barthel
Github user barthel commented on a diff in the pull request: https://github.com/apache/maven-integration-testing/pull/14#discussion_r67099834 --- Diff: core-it-suite/src/test/resources/mng-3092/filter-extension/src/main/java/org/apache/maven/its/extensions

Re: Roadmap Maven 3.4.0

2016-06-14 Thread Uwe Barthel
fixed? -- barthel > On 14 Jun 2016, at 22:55, Paul Benedict wrote: > > You can find the JIRA Maven Roadmap here: > https://issues.apache.org/jira/browse/MNG/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel > > > Cheers, > Paul > > On Tue, Jun 14,

Roadmap Maven 3.4.0

2016-06-14 Thread Uwe Barthel
there any other open PRs for 3.4.0, where I might be able to help with a review? -- barthel - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #70: MNG-3092: Adds version range result filter behaviour

2016-06-14 Thread barthel
Github user barthel commented on the issue: https://github.com/apache/maven/pull/70 I would like to look at ```ContextualSnapshotVersionFilter``` solution, if the Aether code was moved back to Apache Maven. --- If your project is set up for it, you can reply to this email and have

Re: Massive number of failing ITs

2016-05-19 Thread Uwe Barthel
:00 [INFO] Final Memory: 94M/743M [INFO] […] ——8<—8<——snipp——8<—8<—— -- barthel > On 19 May 2016, at 22:27, Jason van Zyl wrote: > > This is what I wrote for people trying to contribute to core: > > http://takari.io/2014/06/01/contributing-to-maven-core.

Re: Massive number of failing ITs

2016-05-19 Thread Uwe Barthel
<—8<——snipp——8<—8<—— $ PATH=/Users/barthel/sources/github.com/apache/apache-maven-3.4.x-SNAPSHOT/bin/:${PATH} mvn -version Apache Maven 3.4.0-SNAPSHOT (4b35102f0e3302e15a80d3ddb756463601b9217a; 2016-05-19T20:35:50+02:00) Maven home: /Users/barthel/sources/github.com/apache/apac

Re: Maven Core - Release 3.4.0?

2016-05-07 Thread Uwe Barthel
* MNG-3092: https://github.com/apache/maven/pull/70 -- barthel > On 07 May 2016, at 20:05, Karl Heinz Marbaise wrote: > > Hi to all, > > based on the number issues which have been fixed in the current 3.4.0... > > I would like to ask if there are objections to make a n

Re: Maven Release Plugin And A BOM

2016-05-03 Thread Uwe Barthel
Hi Petar, I found a very old enforcer rule at smartics and asked them to provide these as OS. They did it two weeks ago at github under Apache Software License. :-) Take a look at https://github.com/smartics/smartics-enforcer-rules -- barthel On May 3, 2016 4:25:55 PM Petar Tahchiev

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-03-20 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-198910133 @dinoboy197: Sorry, I haven't had time to look at @ChristianSchulte suggestion until now. @jvanzyl @michael-o: Suggestion: Merge this solution. I'll ev

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-22 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-187570913 @ChristianSchulte : Sounds interesting. I'll take a look on it at the end of this week. --- If your project is set up for it, you can reply to this email and have

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-18 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-185894318 @dinoboy197 : Fantastic. Thanks for your help. After reading your post, it sounds so logical. @michael-o , @jvanzyl : Now the merge comes true? :-D --- If your

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-184374596 @michael-o Sorry I've no idea how to remove the merge 'noise' from this really old branch. The only change of mine is ```28fd43d```. --- If your project i

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-184328357 @jvanzyl @michael-o : Read to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-184327161 Integration test pull request: https://github.com/apache/maven-integration-testing/pull/14 --- If your project is set up for it, you can reply to this email and have

[GitHub] maven-integration-testing pull request: MNG-3092: Adds integration...

2016-02-15 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven-integration-testing/pull/14 MNG-3092: Adds integration tests for version range result filter behaviour You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-184308767 Use JSR 330 annotation instead of the Plexus annotation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-184304203 @jvanzyl : Thanks for your tip. Now it works. :-D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-13 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-183661203 @jvanzyl , @michael-o : I start working on the integration tests. It's more complicated than I thought. The default handling works but I have difficulti

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-05 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-180504355 It's an old branch. So I merged the actual master into it and use Maven 3.4.0-SNAPSHOT instead. Only the last commit reflects the MNG-3092 sol

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2016-02-01 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-178390879 @jvanzyl , @michael-o : Sorry for the delay. I'm busy right now. I will try to do the change to Maven 3.4 (and JSR330) and add a integration test. But not before f

Re: [VOTE] Retire Maven Application Skin, Maven Classic Skin, Maven Stylus Skin

2015-12-25 Thread Uwe Barthel
+1 -- Uwe On December 24, 2015 23:34:47 "Michael Osipov" <1983-01...@gmx.net> wrote: Hi, as previously suggested, it makes sense to retire those skins because they haven't been updated for a long time and we don't have the resources to maintain them properly [1]. Last releases: Maven Appl

Re: Retiring Maven Skins

2015-12-24 Thread Uwe Barthel
Hi Michael, +2 -- Uwe bart...@x-reizend.de > On 23 Dec 2015, at 21:30, Michael Osipov <1983-01...@gmx.net> wrote: > > Hi folks, > > Hervé is quite busy right now preparing Doxia (Sitetools) 1.7 along with Maven > Site Plugin 3.5. I have several tickets on my own I'd like to fix. Some of > th

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-29 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-160448962 I'm busy the next few days. But I will give it a try if these changes have a chance to merge in 3.3.10. --- If your project is set up for it, you can reply to this

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-25 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159729295 @jvanzyl Did you mean ```@Requirement``` and ```@Component```? I'm following the coding style found in the classes around. Please point me to the replace

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-25 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159728334 @michael-o Indent size and inside issues solved. Commits squashed and amend on last commit in branch. What can I do to avoid the merge commit? If I merge the master

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-24 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159399815 Organize import in ```DefaultVersionRangeResolver``` and squash commit. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159076106 POM file adapted. Use parent version 3.3.10-SNAPSHOT and remove ```commons-lang``` dependency. --- If your project is set up for it, you can reply to this email and

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159059568 @michael-o see my comment Oct 19: > Please remove version property for commons-lang when merging into the master. That's the rework you suggest with

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159057440 @michael-o Sorry. I'm not the owner of this PR. I only push that change forward. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-159011269 I would like to see this changes in the next Maven (3.3.10) release. @michael-o @jvanzyl Please don't forget to merge :-) --- If your project is set up for it

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-11-23 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-159010718 I would like to see this behaviour in the next Maven (3.3.10) release. @phang98 What's the status of the integration tests? @jvanzyl Do you like to merge

Re: Updating the default versions for maven-compiler-plugin

2015-11-06 Thread Uwe Barthel
-1 Many commercial projects still require Java 1.6. mit freundlichen Grüßen -- Uwe Barthel On November 6, 2015 1:57:04 PM Attila-Mihály Balázs wrote: Hello, Given that we're almost in 2015, what do people think about updating the default source / target for maven-compiler-plugin t

Re: Question concerning maven-filtering component

2015-11-04 Thread Uwe Barthel
> -/** > - * @plexus.requirement > - */ > +@Component > private BuildContext buildContext; Use @Requirement instead of @Component. mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de > On 04 Nov 2015, at 22:33, Karl Heinz Marbaise wrote: >

[MNG-3092] merge/commit buddy needed

2015-11-02 Thread Uwe Barthel
My PR for “Adds version range result filter behaviour” (https://github.com/apache/maven/pull/70) is ready for merging and needs a willing committer to merge into master. Please take a look and leave a comment if I could support the merging somehow. mit freundlichen Grüßen Uwe Barthel -- bart

Re: Maven Release Version Policy

2015-11-02 Thread Uwe Barthel
is as strict but clean as possible. But maybe this behaviour is too strict, so it could be a part of a 'strict server' version policy implementation. mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
ing mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de > On 31 Oct 2015, at 13:26, Hervé BOUTEMY wrote: > > great: what is the bundle-maven-plugin feature you're talking about? > > Regards, > > Hervé > > Le samedi 31 octobre 2015 13:18:35 Uwe Barthel a écri

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
> I'm not sure "strict semver" can be automated: functional change can't be > easily detected if there is no API change The bundle-maven-plugin behaviour is a good base to discuss about I think. mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de > On

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
en-plugin (baseline) for similar behaviour at build time. But it is strong bundled on OSGi version philosophy. mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de > On 31 Oct 2015, at 12:28, Hervé BOUTEMY wrote: > > by that you mean you expect a version policy implemen

Re: Maven Release Version Policy

2015-10-31 Thread Uwe Barthel
Hi, I’m with Jason to move Maven forward to use (strict) semver as default version strategy. I understand the 'cloudbee' strategy as a more exotic way. But I'm interested in more than one strategy, configurable via plugin or providing by default plugin. mit freundlichen Grü

Re: MNG-5899 Project models are no longer mutable in reactor

2015-10-27 Thread Uwe Barthel
breaks the actual API. May it could be possible in Maven 3.4 or 4, but not in 3.3.x. Just my 2 cents. -- barthel - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-27 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-151463857 The default behavior is ``do nothing``. The ITs doesn't show any errors at this modifications. --- If your project is set up for it, you can reply to this email and

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-26 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-151395866 Can I do anything to support the merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [VOTE] Release Apache Maven Shade Plugin version 2.4.2 (Take 2)

2015-10-24 Thread Uwe Barthel
+1 (non binding) checksum [x] Java 5 [x] mit freundlichen Grüßen Uwe Barthel -- bart...@x-reizend.de > On 24 Oct 2015, at 12:48, Karl Heinz Marbaise wrote: > > Hi, > > We solved 7 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=1231792

[GitHub] maven pull request: MNG-4463: Version ranges cannot be used for ar...

2015-10-24 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/64#issuecomment-150790373 Since ``org.apache.maven.repository.internal.DefaultModelResolver.resolveModel(Parent)`` handles the version range and

[GitHub] maven pull request: Mac OS X - way of getting JAVA_HOME location

2015-10-24 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/31#issuecomment-150783928 @jvanzyl Please think about merging. :+1: The man page of ``java_home`` is dated from 04 August 2010. This should be old enough to integrate it in Maven, I

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-22 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-150489457 @michael-o @jvanzyl Let's go merging? :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

Re: [VOTE] Release Apache Maven Shade Plugin version 2.4.2

2015-10-20 Thread Uwe Barthel
-1: for me. (non binding) In respect of http://semver.org/ I suggest the version 2.5.0. The Java version change is a minimum minor change. -- barthel > On 20 Oct 2015, at 23:47, Tibor Digana wrote: > > +1: from me > > No blocker from my side. Actually Java 5 is already arc

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-19 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-149349259 @michael-o Your review comments are integrated. .gitignore cleaned up. Apache Commons Lang used instead of ``IllegalArgumentException``. Please remove version

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-17 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-148898986 This solution could also be usable for [MNG-5353](https://issues.apache.org/jira/browse/MNG-5353). --- If your project is set up for it, you can reply to this email and

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-16 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-148704373 @ChristianSchulte Typo fixed. Thanks for looking into it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-16 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-148659197 @michael-o Your comment on 'old' commit b6d72699c8b0089351f797e217d635424c1ae5a2: > Don't! Always through a NPE if null is passed. :+1: Bu

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-16 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-148653328 @michael-o There is a typo and not a hidden statement. :-D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-148556469 @jvanzyl @michael-o : Ready for easier review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/70#issuecomment-148553852 This PR replaced the PR (#68) and based on master and re-created branch MNG-3092. This branch contains the cherry picked b6d7269. --- If your project is set up for it

[GitHub] maven pull request: MNG-3092: Filter Version Range Result

2015-10-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/68#issuecomment-148553491 I've open a new PR (#70) based on master and re-created branch MNG-3092. This branch contains the cherry picked b6d7269. --- If your project is set up for it, yo

[GitHub] maven pull request: MNG-3092: Filter Version Range Result

2015-10-15 Thread barthel
Github user barthel closed the pull request at: https://github.com/apache/maven/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: MNG-3092: Adds version range result filter beh...

2015-10-15 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/70 MNG-3092: Adds version range result filter behaviour The discussion on issue [MNG-3092](https://issues.apache.org/jira/browse/MNG-3092) shows the seriously needs of different kinds of version range

[GitHub] maven pull request: MNG-3092: Filter Version Range Result

2015-10-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/68#issuecomment-148537300 Only b6d7269 is the relevant commit. All other commits are merged from master into my feature branch. --- If your project is set up for it, you can reply to this email

[GitHub] maven pull request: MNG-3092: Filter Version Range Result

2015-10-15 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/68#issuecomment-148528528 Is there anything else I can do to help to merge this change or make/explain it better? --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: MNG-3092: Filter Version Range Result

2015-10-02 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/68#issuecomment-144997575 Only b6d72699c8b0089351f797e217d635424c1ae5a2 contains the enhancements. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven pull request: MNG-3092: Filter Version Range Result

2015-10-02 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/68 MNG-3092: Filter Version Range Result The discussion on issue [MNG-3092](https://issues.apache.org/jira/browse/MNG-3092) shows the seriously needs of different kinds of version range resolving in

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-10-02 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-144993151 I closed this pull request and I come back soon with a less invasive filter solution. --- If your project is set up for it, you can reply to this email and have your

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-10-02 Thread barthel
Github user barthel closed the pull request at: https://github.com/apache/maven/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120431206 My preferred strategy is to resolve only released versions within a version range (```"onlyReleases"```). If a developer needs a SNAPSHOT version, it is p

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/57#issuecomment-120420443 The `org.eclipse.aether.resolution.VersionRangeRequest` contains the artifact . If you implement an odd/even version range resolver strategy only for your

[GitHub] maven pull request: MNG-3092: Add strategy based version range res...

2015-07-10 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/57 MNG-3092: Add strategy based version range resolver. The discussion on issue [MNG-3092](https://issues.apache.org/jira/browse/MNG-3092) shows the seriously needs of different kinds of version range

[GitHub] maven pull request: MNG-3092: strategy based version resolver

2015-07-10 Thread barthel
Github user barthel closed the pull request at: https://github.com/apache/maven/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: MNG-3092: strategy based version resolver

2015-07-10 Thread barthel
Github user barthel commented on the pull request: https://github.com/apache/maven/pull/56#issuecomment-120301859 I'll open a new pull request with a stashed commit and more explanation. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] maven pull request: MNG-3092: strategy based version resolver

2015-07-09 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/56 MNG-3092: strategy based version resolver These changes replaces the default version range resolver with a strategy based version range resolver. You can merge this pull request into a Git

[GitHub] maven pull request: Merge from barthel/maven

2015-07-05 Thread barthel
Github user barthel closed the pull request at: https://github.com/apache/maven/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: Merge from barthel/maven

2015-07-05 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/55 Merge from barthel/maven You can merge this pull request into a Git repository by running: $ git pull https://github.com/barthel/maven MNG-3092 Alternatively you can review and apply these

[GitHub] maven pull request: Merge pull request #1 from apache/master

2015-07-05 Thread barthel
Github user barthel closed the pull request at: https://github.com/apache/maven/pull/54 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: Merge pull request #1 from apache/master

2015-07-05 Thread barthel
GitHub user barthel opened a pull request: https://github.com/apache/maven/pull/54 Merge pull request #1 from apache/master Merge all commits from apache/master into barthel/master. You can merge this pull request into a Git repository by running: $ git pull https://github.com