[GitHub] maven issue #103: spelling: excident

2017-01-29 Thread atanasenko
Github user atanasenko commented on the issue: https://github.com/apache/maven/pull/103 2cents: why not `addInNode()`/`addOutNode()` (renaming `exNodes`->`outNodes`)? Simple and concise. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven-integration-testing pull request #18: [MNG-5958] restore binary compat...

2017-01-15 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven-integration-testing/pull/18 [MNG-5958] restore binary compatibility of Lifecycle.setPhases Modify tests for MNG-5805 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] maven pull request: [MNG-6025] Add a ProjectArtifactsCache similar...

2016-05-19 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven/pull/82 [MNG-6025] Add a ProjectArtifactsCache similar to PluginArtifactsCache You can merge this pull request into a Git repository by running: $ git pull https://github.com/atanasenko/maven

[GitHub] maven pull request: [MNG-5957] Configuration within lifecycle phas...

2016-01-22 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/76#issuecomment-174052876 I didn't get to using it yet after implementing, cool that it works for someone :) --- If your project is set up for it, you can reply to this email and have

[GitHub] maven pull request: [MNG-5957] Configuration within lifecycle phas...

2016-01-22 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/76#issuecomment-173905730 This was actually implemented in MNG-5805 [1]. There is currently a bug MNG-5958 [2] with a pending pull request for ITs [3], but you can already use it like so: [4

[GitHub] maven-integration-testing pull request: [MNG-5958] restore binary ...

2016-01-08 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven-integration-testing/pull/13#issuecomment-170025305 I've had troubles running tests when following official guidelines [1]. But changing 'mvn clean test ...' to 'mvn clean

[GitHub] maven-integration-testing pull request: [MNG-5958] restore binary ...

2016-01-07 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven-integration-testing/pull/13#issuecomment-169820952 btw, I'm also seeing a failure in test for MNG-4919, which seems to be caused by MNG-5359 --- If your project is set up for it, you can rep

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-07 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169636108 This change actually breaks MNG-5805 test since plexus can no longer call setPhases with Lifecycle map. However, I think changing the functionality (and test) to use

[GitHub] maven-integration-testing pull request: [MNG-5958] restore binary ...

2016-01-07 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven-integration-testing/pull/13 [MNG-5958] restore binary compatibility of Lifecycle.setPhases You can merge this pull request into a Git repository by running: $ git pull https://github.com/atanasenko

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169332865 @michael-o, @mcculls I can also assist with tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] maven pull request: [MNG-5958] restore binary compatibility of Lif...

2016-01-06 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/77#issuecomment-169321926 +1 Turns out people do use this method.. Stuart, thanks for fixing! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] maven pull request: MNG-5805: Fix NPE in LifecyclePhase#toString()

2015-08-03 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/62#issuecomment-127386965 I've updated to junit4, looks more modern now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] maven pull request: MNG-5805: Fix NPE in LifecyclePhase#toString()

2015-08-03 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/62#issuecomment-127380233 Hi, I took a look at a couple of neighboring tests and was convinced all of them are junit3 --- If your project is set up for it, you can reply to this email and have

[GitHub] maven pull request: MNG-5805: Fix NPE in LifecyclePhase#toString()

2015-08-01 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven/pull/62 MNG-5805: Fix NPE in LifecyclePhase#toString() You can merge this pull request into a Git repository by running: $ git pull https://github.com/atanasenko/maven master Alternatively you can

[GitHub] maven pull request: MNG-5805: Restore binary compatibility

2015-07-23 Thread atanasenko
Github user atanasenko closed the pull request at: https://github.com/apache/maven/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven pull request: MNG-5805: Restore binary compatibility

2015-07-19 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven/pull/59 MNG-5805: Restore binary compatibility You can merge this pull request into a Git repository by running: $ git pull https://github.com/atanasenko/maven master Alternatively you can review

[GitHub] maven pull request: MNG-5805: Custom packaging types: configuring ...

2015-04-27 Thread atanasenko
Github user atanasenko closed the pull request at: https://github.com/apache/maven/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] maven-integration-testing pull request: MNG-5805: Custom packaging...

2015-04-27 Thread atanasenko
Github user atanasenko closed the pull request at: https://github.com/apache/maven-integration-testing/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-integration-testing pull request: MNG-5805: Custom packaging...

2015-04-27 Thread atanasenko
Github user atanasenko closed the pull request at: https://github.com/apache/maven-integration-testing/pull/12 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-integration-testing pull request: MNG-5805: Custom packaging...

2015-04-27 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven-integration-testing/pull/12 MNG-5805: Custom packaging types: configuring DefaultLifecycleMapping mojo executions You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] maven pull request: MNG-5805: Custom packaging types: configuring ...

2015-04-27 Thread atanasenko
Github user atanasenko commented on the pull request: https://github.com/apache/maven/pull/43#issuecomment-96817019 It looks like you applied only the pom file change of sisu version. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] maven pull request: MNG-5805: Custom packaging types: configuring ...

2015-04-20 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven/pull/43 MNG-5805: Custom packaging types: configuring DefaultLifecycleMapping mojo executions You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] maven-integration-testing pull request: MNG-5805: Custom packaging...

2015-04-20 Thread atanasenko
GitHub user atanasenko opened a pull request: https://github.com/apache/maven-integration-testing/pull/11 MNG-5805: Custom packaging types: configuring DefaultLifecycleMapping mojo executions You can merge this pull request into a Git repository by running: $ git pull https