[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 Looks like we have a similar bug in `mvn.cmd`. The added `testJvmConfigFileCR` test fails on Windows: ``` testJvmConfigFileCR(org.apache.maven.it.MavenITmng6255FixConcatLines) Time

[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...

Github user Tunaki commented on the issue: https://github.com/apache/maven-integration-testing/pull/23 I ran the IT with 3.5.0 on Windows, but it passed. Since the issue resolves around the error message that is printed on the console, I think the two files `folder-with- -space

[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/128 Shouldn't there be the same fix for `mvn`, and not just `mvn.cmd`? [`${basedir}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L150)

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 This looks OK, verified with `bash` and `dash` (on Ubuntu 16.04), `tcsh` and `sh` (on FreeBSD 11.0). Could you add an integration test for this (https://github.com/apache/maven-integration-testing

[GitHub] maven issue #127: Fix concat_lines in mvn to deal with CRLF

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 This doesn't seem to work on CRLF files on Git Bash (or Ubuntu). Result is the same as with `tr`. ```sh $ echo -e "Foo\nBar" > test.txt $ cat -e test.txt Foo$

[GitHub] maven-surefire pull request #151: Fixing build on Windows cmd.exe.

Github user Tunaki closed the pull request at: https://github.com/apache/maven-surefire/pull/151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] maven-surefire issue #151: Fixing build on Windows cmd.exe.

Github user Tunaki commented on the issue: https://github.com/apache/maven-surefire/pull/151 Yes, I was finishing typing it up: https://issues.apache.org/jira/browse/SUREFIRE-1375. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] maven-surefire pull request #151: Fixing build on Windows cmd.exe.

GitHub user Tunaki opened a pull request: https://github.com/apache/maven-surefire/pull/151 Fixing build on Windows cmd.exe. Files generated with the XJC tool were using the platform encoding, that can be different from the project source encoding. In this case, the project source

[GitHub] maven-wagon pull request #32: [WAGON-485] ScpWagon file size Integer to Long

Github user Tunaki commented on a diff in the pull request: https://github.com/apache/maven-wagon/pull/32#discussion_r95232415 --- Diff: wagon-providers/wagon-ssh/src/main/java/org/apache/maven/wagon/providers/ssh/jsch/ScpWagon.java --- @@ -297,7 +297,7 @@ public void