Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
s quite large, given how broadly it is used. In nearly every other case I'd just change the version and move on. Just trying to explain the reasoning here. ________ From: Sam Gammon Sent: Tuesday, March 5, 2024 11:40 PM To: Maven Developers List Subject: Re: Compile

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
, 2024 11:28:27 PM To: dev@maven.apache.org Subject: Re: Compiler bug: Issues with JPMS module version On 2024/03/06 07:15:11 Sam Gammon wrote: > I hadn't noticed that test, thank you. That's very helpful, maybe, then, > Guava's string HEAD-jar-SNAPSHOT​ can simply be a

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
(Sorry, forgot to say; the reasoning for a killswitch flag: ultimately, a Maven user can just provide --module-version​ via compiler arguments so long as Maven isn't injecting it.) From: Sam Gammon Sent: Tuesday, March 5, 2024 11:15 PM To: dev@maven.apach

Re: Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
a ModuleDescriptor.Version::parse(String v) should guard the lines you linked. Cheers, Christian On 2024/03/06 06:46:27 Sam Gammon wrote: > Hello Maven devs, > > Longtime user, first time mailing list subscriber. > > I was attempting to convert some Java libraries to JPMS module

Compiler bug: Issues with JPMS module version

2024-03-05 Thread Sam Gammon
Hello Maven devs, Longtime user, first time mailing list subscriber. I was attempting to convert some Java libraries to JPMS modules today, and ran into a compiler issue with Maven version 3.8.1 and above; this deals with the --module-version​ flag. Maven sets the module version to the project