[ http://jira.codehaus.org/browse/MNG-466?page=comments#action_46238 ]
Rod Coffin commented on MNG-466:
I agree with your explanation and think that this issue should be marked as
"WON'T FIX"
Thanks!
> Maven eclipse plugin doesn't
[ http://jira.codehaus.org/browse/MNG-466?page=comments#action_46221 ]
Rod Coffin commented on MNG-466:
At the time I wrote up this issue I was using MyEclipse and I seem to remember
that it worked best when the webapp directory was setup as a source folder
[ http://jira.codehaus.org/browse/MNG-466?page=comments#action_46216 ]
Rod Coffin commented on MNG-466:
I just retested this issue with the M2 source from yesterday (9/11) and it does
not seem to be resolved yet. Let me know if there is more that I can do
[ http://jira.codehaus.org/browse/MNG-862?page=all ]
Rod Coffin updated MNG-862:
---
Attachment: patch-862.txt
This bug seems to be caused because the Plexus MapConverter creates a TreeMap
and the CompilerConfiguration expects a LinkedHashMap. These two are
-beta-1
Reporter: Rod Coffin
Priority: Minor
Adding a compiler argument to a forked compiler causes maven to fail. An
example plugin configuration causing this error is:
org.apache.maven.plugins
maven-compiler-plugin
true
C:\oss
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45116 ]
Rod Coffin commented on MNG-710:
Works great now, thanks Trygve!
> Add ability to fork the maven-compiler-plugin
> -
>
>
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_45086 ]
Rod Coffin commented on MNG-710:
I just tried compiling with a forked JDK 1.3 compiler and it seems that the
source parameter is still being passed to the compiler. I think this is
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---
Attachment: maven-compiler-plugin.diff3.txt
plexus-compiler-javac.diff3.txt
plexus-compiler-api.diff3.txt
I've added unit tests for buildi
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44190 ]
Rod Coffin commented on MNG-710:
I can write some test cases for this but won't have the time until tomorrow
night. When I get the chance I'll create a few and upload them as
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44186 ]
Rod Coffin commented on MNG-710:
So it sounds like we will need to add a comiler version parameter to the plexus
compiler and add arguments based on this setting. I would be ok with
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44181 ]
Rod Coffin commented on MNG-710:
I think checking the fork flag would work if you specify source and target in
your plugin configuration. Basically if forking those flags wouldn'
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44179 ]
Rod Coffin commented on MNG-710:
My bad with the style, I had it applied and must have messed up my settings.
Would you like me to reapply the style and submit the diff? I'll also
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---
Attachment: plexus-compiler-javac.diff2.txt
> Add ability to fork the maven-compiler-plugin
> -
>
>
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44177 ]
Rod Coffin commented on MNG-710:
I've tried out these changes and the only problem I see at this point is that
the source argument is always being passed, even if forking to a jd
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44137 ]
Rod Coffin commented on MNG-710:
Good point about the plexus javac compiler being Sun javac specific. In that
case I would be ok with adding a version flag and executing some logic in
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44135 ]
Rod Coffin commented on MNG-710:
The problem is that users of this plugin can specify any arbitrary java
compiler. So the compiler type (IBM, Sun, etc.) and version could all vary. I
[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44133 ]
Rod Coffin commented on MNG-710:
Valid compiler arguements differ based on the version of the compiler used.
For example, we don't want to pass the 'source' argument to
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---
Attachment: plexus-compiler-api.diff.txt
> Add ability to fork the maven-compiler-plugin
> -
>
> Key: MNG-710
&g
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---
Attachment: plexus-compiler-javac.diff.txt
> Add ability to fork the maven-compiler-plugin
> -
>
>
[ http://jira.codehaus.org/browse/MNG-710?page=all ]
Rod Coffin updated MNG-710:
---
Attachment: maven-compiler-plugin.diff.txt
> Add ability to fork the maven-compiler-plugin
> -
>
>
Add ability to fork the maven-compiler-plugin
-
Key: MNG-710
URL: http://jira.codehaus.org/browse/MNG-710
Project: Maven 2
Type: Improvement
Components: maven-plugins
Reporter: Rod Coffin
Attachments: maven-compiler
e to anyone looking to contribute
> that.
>
> Nice article on DevX by the way - and please feel free to drop the
> developers list a line if you are writing any in the future. We're
> always happy to give feedback.
>
> Cheers,
> Brett
>
> On 8/4/05, Rod Coffin &
[ http://jira.codehaus.org/browse/MNG-635?page=comments#action_43314 ]
Rod Coffin commented on MNG-635:
Agreed that the getServletContext method is the way to go if you're running in
container, but this is not the case during unit testing.
But I fo
[ http://jira.codehaus.org/browse/MNG-635?page=comments#action_43302 ]
Rod Coffin commented on MNG-635:
I think that it is important for Maven to provide a facility to unit test all
parts of an application including view components such as servlets. For me
[ http://jira.codehaus.org/browse/MNG-635?page=all ]
Rod Coffin updated MNG-635:
---
Attachment: MNG-635.txt
There is probably several ways to accomplish this but attached is one simple
approach that I tried and got to work. I created a Webapp plugin that
-beta-1-SNAPSHOT
Windows XP
java version "1.5.0_02"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_02-b09)
Java HotSpot(TM) Client VM (build 1.5.0_02-b09, mixed mode, sharing)
Reporter: Rod Coffin
Priority: Blocker
Unit tests that depend on resources in the webapp
: 2.0-alpha-2
Environment: Windows XP
java version "1.5.0_02"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_02-b09)
Java HotSpot(TM) Client VM (build 1.5.0_02-b09, mixed mode, sharing)
Reporter: Rod Coffin
Attachments: patch.txt
The maven-eclipse-plugin does
[ http://jira.codehaus.org/browse/MNG-359?page=comments#action_39737 ]
Rod Coffin commented on MNG-359:
If the allowed "../" in order refer to modules at the same level as
the parent project then working with a maven project within Eclips
: 2.0-alpha-2
Environment: Windows XP
java version "1.5.0_02"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_02-b09)
Java HotSpot(TM) Client VM (build 1.5.0_02-b09, mixed mode, sharing)
Reporter: Rod Coffin
Priority: Minor
Attachments: patch.txt
The maven-eclipse
29 matches
Mail list logo