[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-18 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-46524647 First of all - thanks for your email. I understand, that this will ruin current ORing technique, but at least it could be fixed with copying for a while

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-12 Thread MysterionRise
Github user MysterionRise closed the pull request at: https://github.com/apache/maven/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45826259 @jvanzyl Looks correct, please close this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45825613 Let me check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731774 Hm, probably you are correct. I've just have strong feeling, when somebody said 'Sonatype' - think about 'Maven' and vice-versa.

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-11 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45731386 http://jira.codehaus.org/browse/MNG-4565 - take a look here. It have link for reference http://books.sonatype.com/mvnref-book/reference/profiles-sect

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/20#issuecomment-45704618 I've implement this patch, only cause it's 100% relates with official documentation. --- If your project is set up for it, you can reply to this email and

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/20 [MNG-4565] Multiple profile activation conditions does not work Add possibilty to use multiple activators and have AND between them You can merge this pull request into a Git repository by

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-10 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45643803 I'm sorry, I don't understand, why you close this PR? Does it bad? I miss something? --- If your project is set up for it, you can reply to this email and

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-08 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45431277 Just wonder, is there anything I could do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-04 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-45134460 I've update pull request. I change my approach, so it will not now a platform dependable. But ITs are still failing at weird place. I'm 100% sure, that i

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-06-02 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44831587 Good stuff. I will try it today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44757042 I'm 100% don't wanna rush. I will think about special activator for testing purpose (It could be _AlwaysTrueActivator_). I will try to give it a try

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44756590 Not understand your point about failing against master. I agree that platform activators is not good idea. So same with JDK activator, right? I'm only

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44755927 Awesome,this is the only platform, I couldn't test against.Could you specify your _mvn -version_ output? I will try to fix test. --- If your project is set u

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44751378 Could you tell me, what did you use? I've run tests on Linux: mvn -version Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 20

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-31 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/16#issuecomment-44749028 Any updates on my pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven pull request: http://jira.codehaus.org/browse/MNG-4565

2014-05-27 Thread MysterionRise
Github user MysterionRise commented on the pull request: https://github.com/apache/maven/pull/15#issuecomment-44268726 Create new pull request with squashed commits https://github.com/apache/maven/pull/16, plz take a look --- If your project is set up for it, you can reply to

[GitHub] maven pull request: http://jira.codehaus.org/browse/MNG-4565

2014-05-27 Thread MysterionRise
Github user MysterionRise closed the pull request at: https://github.com/apache/maven/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven pull request: [MNG-4565] Multiple profile activation conditi...

2014-05-27 Thread MysterionRise
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/16 [MNG-4565] Multiple profile activation conditions does not work You can merge this pull request into a Git repository by running: $ git pull https://github.com/MysterionRise/maven MNG

[GitHub] maven pull request: http://jira.codehaus.org/browse/MNG-4565

2014-05-27 Thread MysterionRise
GitHub user MysterionRise opened a pull request: https://github.com/apache/maven/pull/15 http://jira.codehaus.org/browse/MNG-4565 Simple solution to this bug. Add possibility to have multiple condition in profile activation. Add simple test with positive and negative case