Re: Extension does not work from .mvn/extensions.xml

2018-11-20 Thread J. Lewis Muir
On Tue, Nov 20, 2018 at 1:01 PM Romain Manni-Bucau wrote: > Le mar. 20 nov. 2018 19:23, J. Lewis Muir a écrit : > > There's no way I can get the developers of the > > software I'm planning to use this in to install the extension in > > Maven's lib/ext

Re: Extension does not work from .mvn/extensions.xml

2018-11-20 Thread J. Lewis Muir
On Tue, Nov 20, 2018 at 2:30 AM Romain Manni-Bucau wrote: > 1. you have to use lib/ext folder and not extensions.xml cause it is loaded > too late Unfortunately, that's a deal breaker. Using Maven's lib/ext is the original situation I reported when I started this thread (i.e., it worked from Mav

Re: Extension does not work from .mvn/extensions.xml

2018-11-19 Thread J. Lewis Muir
On Mon, Nov 19, 2018 at 4:16 PM Romain Manni-Bucau wrote: > Time to push your code and an example on github to encourage help/people to > run it ;) OK, here's how to get the extension with the proof of concept code and install it locally: === $ git clone https://github.com/imca-cat/profile-activ

Re: Extension does not work from .mvn/extensions.xml

2018-11-19 Thread J. Lewis Muir
On Sat, Nov 17, 2018 at 11:32 AM Romain Manni-Bucau wrote: > Le sam. 17 nov. 2018 17:06, J. Lewis Muir a écrit : > > > Idea was to set an activation which will match true with default impls > > > > OK, I'm just trying to make sure I understanding that. The def

Re: Extension does not work from .mvn/extensions.xml

2018-11-17 Thread J. Lewis Muir
On Sat, Nov 17, 2018 at 1:53 AM Romain Manni-Bucau wrote: > > > Not instead but also. Instead of 3 impl you will get 4. > > > > I see. I guess I don't know where to hook into the model, then. I > > can't find anything in the model that implements the is-active > > computation for a Profile or Ac

Re: Extension does not work from .mvn/extensions.xml

2018-11-16 Thread J. Lewis Muir
On Fri, Nov 16, 2018 at 3:35 PM Romain Manni-Bucau wrote: > I didnt find in the code where the hint matches, just saw a chain so should > work if i didnt miss a later filtering. Where in the code is that? > That said my naming advise was for > the pom content more than the code (to not interpret

Re: Extension does not work from .mvn/extensions.xml

2018-11-16 Thread J. Lewis Muir
On Fri, Nov 16, 2018 at 12:02 AM Romain Manni-Bucau wrote: > For the marker i was thinking about "property" so your activation would be > "el:name" or anything else - idea just being not intrusive and impacting > for actual property activation. I see. I thought that, in order for the hijack to w

Re: Extension does not work from .mvn/extensions.xml

2018-11-15 Thread J. Lewis Muir
On Wed, Nov 14, 2018 at 3:31 PM Romain Manni-Bucau wrote: > You can debug using mvnDebug but i think it is cause there is already a > property handler - > https://github.com/apache/maven/blob/master/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/PropertyProfileActivato

Extension does not work from .mvn/extensions.xml

2018-11-14 Thread J. Lewis Muir
Hello, all! I have an extension https://github.com/imca-cat/profile-activation-advanced that allows property-based profile activation based on an MVEL expression. My problem is that it works === $ mvn help:active-profiles validate ... The following profiles are active: - foo_env-developmen