[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-09-10 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Thank you. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

2017-09-10 Thread Fuud
Github user Fuud closed the pull request at: https://github.com/apache/maven-surefire/pull/114 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-06-06 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Any questions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-10 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 ParallelComputerBuilder.PC sets scheduller to runner (see org.apache.maven.surefire.junitcore.pc.ParallelComputerBuilder.PC#setSchedulers(org.junit.runners.ParentRunner

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-09 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 >Is that true that at least some runners still have some children since the beginning when parallel computer (PC) has recognized them? In general case I can not garantee t

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-06 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 I am not sure that I understand your question. But I can try to answer :) 1) JUnit has @RunWith annotaion that consumes Class 2) This Runner should implement method getDescription

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-05 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Because Spock can't (do not want) generate runners at test object creation time. Parametrized runners are generated at runtime and therefore not known at init time. --- If your project i

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-05 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 NoTestsRemainException will be thrown in this case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-05 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 With pure JUnit it is not possible. You can only place @Test annotation on method => there will be at least one test in TestClass. --- If your project is set up for it, you can reply

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-05-05 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 @Jezorko https://github.com/spockframework/spock/pull/558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-04-06 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2017-01-31 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2016-12-12 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 "Master Origin" integration tests suite does not pass on my Windows box. ``` Results : Failed tests: properNewlinesAndEncodingWithDiffere

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

2016-12-08 Thread Fuud
Github user Fuud commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/114#discussion_r91513593 --- Diff: surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java --- @@ -32,15

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

2016-12-08 Thread Fuud
Github user Fuud commented on a diff in the pull request: https://github.com/apache/maven-surefire/pull/114#discussion_r91491402 --- Diff: surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java --- @@ -428,10 +428,10

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2016-12-08 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Just FYI: integration tests suite does not pass on Windows. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2016-12-08 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 Tests run: 701, Failures: 0, Errors: 0, Skipped: 133 [INFO] [INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-check) @ surefire-integration-tests --- [INFO] [INFO

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

2016-08-29 Thread Fuud
Github user Fuud commented on the issue: https://github.com/apache/maven-surefire/pull/114 any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

2016-07-12 Thread Fuud
GitHub user Fuud opened a pull request: https://github.com/apache/maven-surefire/pull/114 Parallel runner should not drop away runners that have zero children. JUnit does not force runners to include all child tests in Description. Therefore Parallel Runner should not throw such