Re: Maven 3.9.0 plexus-utils issue in extension

2023-02-14 Thread Falko Modler
e the impact on GIB users, but the above change would make sense anyway (if there's ever a 3.8.8). Cheers, Falko Am 10.02.2023 um 19:44 schrieb Michael Osipov: Am 2023-02-10 um 18:55 schrieb Falko Modler: Hi Michael, Have you tried to back port the class loading strategy from gnodet@ back to 3

Re: GitHub release notes ...

2023-02-12 Thread Falko Modler
Hi, > what about just set a link to the JIRA release notes for all GitHub release > notes. I like this minimalist approach, better than having no changes info in GitHub at all. GH release notes are very handy for update bots like renovate. Most of the time I don't see any release notes in such

Re: Maven 3.9.0 plexus-utils issue in extension

2023-02-10 Thread Falko Modler
schrieb Michael Osipov: Am 2023-02-09 um 12:00 schrieb Falko Modler: ... Thank you for the in-depth analysis. This is ugly, I agree. Have you tried to back port the class loading strategy from gnodet@ back to 3.8.x? Please try that, if that works I would be inclined to include this with 3.8.8 si

Re: Maven 3.9.0 plexus-utils issue in extension

2023-02-09 Thread Falko Modler
Correction: It's also way too early to drop support for Maven <=3.9. "for Maven < 3.9". Also sorry for the formatting mess, I copied the error directly from the console. Cheers, Falko - To unsubscribe, e-mail: dev-unsubscr

Maven 3.9.0 plexus-utils issue in extension

2023-02-09 Thread Falko Modler
Hi all, I'm currently trying to get gitflow-incremental-builder (GIB) running in a GitHub Action using Maven 3.9.0 (and Java 17). https://github.com/gitflow-incremental-builder/gitflow-incremental-builder GIB is a maven extension that shall be usable in the following "flavors": 1. as a plugin

Re: Maven 3.9,0 plan

2023-01-24 Thread Falko Modler
://repository.apache.org/#nexus-search;gav~org.apache.maven~apache-maven~3.9.0-SNAPSHOT~~ czw., 19 sty 2023 o 22:49 Falko Modler napisał(a): Hi there, So, please anyone able to, test 3.9.0-SNAPSHOT if you can. do I have to build it on my own? I've been looking in a few places including Jenkins but I cou

Re: Maven 3.9,0 plan

2023-01-19 Thread Falko Modler
Hi there, So, please anyone able to, test 3.9.0-SNAPSHOT if you can. do I have to build it on my own? I've been looking in a few places including Jenkins but I couldn't find a pre-built archive. Thanks! Cheers, Falko - To

Re: Dependencies from profiles broken in 3.8.5?

2022-03-15 Thread Falko Modler
Now tracked via: https://issues.apache.org/jira/browse/MNG-7432 Am 15.03.2022 um 13:52 schrieb Falko Modler: FTR, problem confirmed, see: - https://github.com/quarkusio/quarkus/pull/24285#issuecomment-1067713252 - https://github.com/quarkusio/quarkus/pull/24285#issuecomment-1067738029 There is

Re: Dependencies from profiles broken in 3.8.5?

2022-03-15 Thread Falko Modler
:06 PM Falko Modler wrote: Thanks for checking! In fact, I would have been very surprised if that was broken in general. Right now I'm suspecting user property parsing but I have yet to take a closer look... - To unsubscri

Re: Dependencies from profiles broken in 3.8.5?

2022-03-14 Thread Falko Modler
Thanks for checking! In fact, I would have been very surprised if that was broken in general. Right now I'm suspecting user property parsing but I have yet to take a closer look... - To unsubscribe, e-mail: dev-unsubscr...@mave

Dependencies from profiles broken in 3.8.5?

2022-03-14 Thread Falko Modler
Hi everyone, before I invest (a lot of) time, is it just me or are dependencies from profiles broken in Maven 3.8.5? In my Quarkus project, two usecases broke with 3.8.5 but they are fine with 3.8.4 and before. One is described briefly here: https://github.com/quarkusio/quarkus/pull/24285#issue

Re: Upcoming release of maven-dependency-plugin

2022-02-13 Thread Falko Modler
ss, it would be worth to give a feedback in advance. Somebody may guide you in the right direction rather sooner than later. T Dňa št 10. 2. 2022, 11:45 Falko Modler napísal(a): TBH, I haven't created an issue yet. I wanted to create a working draft first and play around with it to see wheth

Re: Upcoming release of maven-dependency-plugin

2022-02-10 Thread Falko Modler
much time do you need to finish your work? czw., 10 lut 2022 o 01:07 Falko Modler napisał(a): Hi Slawomir, a few weeks ago I started working on extending the "properties" goal to create a version property per dependency. This would be very useful for projects like Quarkus that hav

Re: Upcoming release of maven-dependency-plugin

2022-02-09 Thread Falko Modler
Hi Slawomir, a few weeks ago I started working on extending the "properties" goal to create a version property per dependency. This would be very useful for projects like Quarkus that have a big BOM and would like to reuse versions from that BOM for various things in integration tests etc. It w

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Falko Modler
Am 27.11.2021 um 20:25 schrieb Romain Manni-Bucau: 1. Profiles dont work by design since they must be activated and have the same issue that plugin flag In what I proposed the activation happens automatically via ... activation, so I don't get your point. Sure, if you don't have a suitable fil

Re: Different parent/child configuration without child located customization?

2021-11-27 Thread Falko Modler
Hi, what also works in many cases is a profile with file activation, e.g. if there is src/main/kotlin add the kotlin plugin. You can even use flagfiles to control this, which isn't pretty but sometimes it makes sense Cheers, Falko --

Re: Upcoming Maven 3.8.4

2021-10-23 Thread Falko Modler
Hi, Given that we had two releases with regressions I tend *not* to merge #578. Give it more time and thought. As written before on GH, not merging #578 or a backport of #476 will bring back MNG-6843. This will catch users off guard that were happily benefitting from MNG-6843 being fixed in 3.

Re: Upcoming Maven 3.8.3

2021-09-16 Thread Falko Modler
Hi Michael, thanks for moving this forward! Great to see that you are considering to include MNG-7235, as both PRs were created by a fellow Quarkus team member after I advertised to report this issue (that came up during a recent relocation in Quarkus). Regarding MNG-7212: IIRC, I saw someone e

Re: Regression in Maven 3.8.2? site/javadoc generation fails

2021-09-04 Thread Falko Modler
I haven't checked, but there is a good chance https://github.com/apache/maven/pull/527 might fix that problem. Cheers, Falko 03.09.2021 16:02:04 Stefan Seifert : > thanks for the pointer - but i think my problem is different. in my case it's > not a problem of looking up a site descriptor, bu

Re: Maven Extension Configuration

2021-08-31 Thread Falko Modler
Hi Robert, this is basically https://issues.apache.org/jira/browse/MNG-5897, no? I left a few thouhts there a while ago. Cheers, Falko Am 31.08.2021 um 22:50 schrieb Robert Scholte: Hi, I see quite some Maven extensions that rely on configuration. There's no convention for this, so they all

Re: [VOTE] Release Apache Maven version 3.8.2

2021-08-23 Thread Falko Modler
There is an open PR for that as well: https://github.com/apache/maven/pull/521 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven version 3.8.2

2021-08-23 Thread Falko Modler
Why revert? Are you aware of any other regression caused by that? Both known regressions have been fixed (not yet merged). Having said that, as discussed previously, a solution without a TL is preferable in the long run but probably requires a more invasive approach that is too big for a 3.8.x p

Re: [VOTE] Release Apache Maven version 3.8.2

2021-08-22 Thread Falko Modler
this *➜ **maven-core* *git:(**42c99b45e**)* git bisect good 76d5f0d942f52650d3bdf775b6af42d23d69066b is the first bad commit commit 76d5f0d942f52650d3bdf775b6af42d23d69066b Author: Falko Modler Date: Fri Jun 25 19:28:40 2021 +0200 [MNG-6843] Parallel build fails due to missing JAR arti

Re: [VOTE] Release Apache Maven version 3.8.2

2021-08-10 Thread Falko Modler
I checked it briefly with Quarkus (almost 1k modules) and I couldn't really see a difference. Cheers, Falko - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: [VOTE] Release Apache Maven version 3.8.2

2021-08-06 Thread Falko Modler
Hi all, it wouldn't surprise me if it was that ThreadLocal quickfix from my PR. I think everyone agrees that it is a bandaid solution but well, correctness and stability over (some) speed, IMO. It would be nice to limit this workaround to only when aggregating goals are involved but that seems

Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-07-10 Thread Falko Modler
Done already: https://github.com/apache/maven/pull/482 Cheers, Falko - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: Maven 3.8.x

2021-06-24 Thread Falko Modler
Hi, I'd like to suggest an update of maven-shared-utils to at least 3.3.3 due to security issue https://issues.apache.org/jira/browse/MSHARED-297. Quarkus is using parts of Maven that bring in maven-shared-utils 3.2.1 and we received complaints by users: https://github.com/quarkusio/quarkus/issue

Re: Mojo execution synchonization with forked lifecycles in parallel builds

2021-05-12 Thread Falko Modler
Hi Guillaume, aggregation goals and parallel builds in combination are a bit of a mess, e.g.: - https://issues.apache.org/jira/browse/MNG-6843 - https://github.com/apache/maven/pull/413 - https://www.mail-archive.com/dev@maven.apache.org/msg123439.html Cheers, Falko Am 12.05.2021 um 17:25 sch

Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-05-03 Thread Falko Modler
om redoing the same bad and understand the process on how to make the code better in the early beginning. Cheers Tibor17 On Sun, Jan 24, 2021 at 10:51 PM Falko Modler wrote: Hi Tibor, thanks for this very elaborate answer and I always appreciate your feedback, but to me it kind of misses t

Re: [ANN] Apache Maven 3.8.1 Released

2021-04-05 Thread Falko Modler
FWIW, takari wrapper also still mentions Maven 3.7.0 for a replacement. I created https://github.com/takari/maven-wrapper/pull/176 to correct that but I have no idea whether someone will merge that as the project is basically inactive. Cheers, Falko Am 05.04.2021 um 16:01 schrieb Robert Scholte:

Core IT failures with AdoptOpenJDK 11 OpenJ9, but not with HotSpot

2021-02-28 Thread Falko Modler
Hi everyone, with AdoptOpenJDK 11.0.10, I'm getting three test failures/errors with current masters of maven and maven-integration-testing, but only with the OpenJ9 variant, not with HotSpot. Is this a known problem? [ERROR] Failures: [ERROR] MavenITmng5482AetherNotFoundTest>AbstractMavenIntegr

Re: Incremental Maven - push the feature

2021-02-22 Thread Falko Modler
This is very interesting and exciting news! this is a fork of Maven somehow? Or additional plugins that are configurable into standard Maven? I second this question. I too published something on quicker Maven builds that's lower tech - https://paulhammant.com/2021/01/28/dagging-on-maven FW

Re: Maven 4: -pl !... is not recursive

2021-02-21 Thread Falko Modler
p://rmannibucau.wordpress.com> | Github < https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book < https://www.packtpub.com/application-development/java-ee-8-high-performance Le sam. 20 févr. 2021 à 14:40, Falko Modler a écrit : Thanks for

Re: Maven 4: -pl !... is not recursive

2021-02-20 Thread Falko Modler
Thanks for the quick reaction/answers! TBH, I haven't fully understood why -N cannot be used here. I do understand that -N reduces the reactor to one project (before project selection via -pl can kick in). But what if -N wouldn't be applied if -pl is present? It would then become a "secondary"

Maven 4: -pl !... is not recursive

2021-02-19 Thread Falko Modler
Hi everyone, I started playing around with 4.0.0-alpha-1-20210214.163053-40 and I realized that -pl X will now also build submodules of X but -pl !X will only exclude X, not its submodules. Isn't this a bit inconsistent? Cheers, Falko -

Re: Official Maven Github Actions

2021-02-12 Thread Falko Modler
Hi all, FWIW, a wrapper also doesn't help if you want to test extensions or plugins with multiple Maven versions. E.g.: - https://github.com/gitflow-incremental-builder/gitflow-incremental-builder/blob/master/.github/workflows/maven.yml#L105-L136 - https://github.com/gitflow-incremental-builder/g

Re: MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-01-24 Thread Falko Modler
s by adding or removing them somewhere inside. Cheers Tibor17 On Sat, Jan 16, 2021 at 10:21 PM Dan Tran wrote: we are facing the same issue at work (300+ modules), classpath empty randomly empty Love to see some resolution, will help to test it Thanks -D On Fri, Jan 15, 2021 at

MNG-6843 Parallel build fails due to missing JAR artifacts in compilePath

2021-01-15 Thread Falko Modler
Hi everyone, I'd like to raise awareness for the MavenProject concurrency problem that is causing MNG-6843 "Parallel build fails due to missing JAR artifacts in compilePath" [1] and probably others [2] [3] [4]. Almost a month ago, I created a ThreadLocal-based fix for this [5] (after another, ol

Re: Speed of Maven build

2020-08-25 Thread Falko Modler
Maybe slightly offtopic but if you have (many) submodules, you might want to consider automatic incremental builds (based on SCM changes) with https://github.com/vackosar/gitflow-incremental-builder Don't be scared by the name. You do not actually need a gitflow branch layout. Disclaimer: I am m

Assumption fail treated as unexcepted exception?!

2020-08-16 Thread Falko Modler
Which surefire plugin version? Have you set any config properties? Cheers, Falko - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: Absolute location of settings files help

2020-07-25 Thread Falko Modler
Inject the MavenSession: @Parameter(defaultValue ="${session}", readonly = true) private MavenSession mavenSession; and then: mavenSession.getRequest() -> getUserSettingsFile() or getGlobalSettingsFile() Cheers, Falko Am 23.07.2020 um 13:42 schrieb John Patrick: From within a plugin, how

Excluding builds of certain git branches on ASF Jenkins

2020-07-22 Thread Falko Modler
Hi Maarten, you can add 'when' to a 'stage' but that would not prevent the job from being triggered. AFAICS, nothing that you can put in Jenkinsfile will prevent the job from being triggered. Cheers, Falko - To unsubscribe, e

Re: surefire M6?

2020-07-07 Thread Falko Modler
Hi Oliver, which performance issue do you mean? I was actually hoping to revive https://github.com/apache/maven-surefire/pull/169 for M6 but I haven't had time thus far. Cheers, Falko Am 08.07.2020 um 00:38 schrieb Olivier Lamy: Hi, I wonder if there is a plan to release M6 ASAP with the per

Re: The Chicken-Egg problem with Maven Wrapper and Maven Wrapper Plugin

2020-05-23 Thread Falko Modler
Hi Robert, this is slightly offtopic but since you wrote: On the other hand, the plugin must be able to download the apache-maven-wrapper distribution. Is this integration into Maven also adressing proxy handling for the download? I am asking because I had to add special handling to Quarkus t

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-24 Thread Falko Modler
at 10:45 PM Falko Modler wrote: Hi, I just tried to to sign the output of https://github.com/vackosar/gitflow-incremental-builder and I do not see this error. *But* the plugin simply hangs and does not continue if I use 3.0.0 after starting Kleopatra (https://docs.kde.org/stable5/en/pim/kleo

Re: [VOTE] Release Apache Maven GPG Plugin version 3.0.0

2020-04-15 Thread Falko Modler
Hi, I just tried to to sign the output of https://github.com/vackosar/gitflow-incremental-builder and I do not see this error. *But* the plugin simply hangs and does not continue if I use 3.0.0 after starting Kleopatra (https://docs.kde.org/stable5/en/pim/kleopatra/). When I first use 1.6 of th

Re: [ANN] Apache Maven Shade Plugin 3.2.2 Released

2020-02-14 Thread Falko Modler
Thanks to everyone involved! Am 13.02.2020 um 22:03 schrieb Hervé Boutemy: The Apache Maven team is pleased to announce the release of the Apache Maven Shade Plugin, version 3.2.2 This plugin provides the capability to package the artifact in an uber-jar, including its dependencies and to sha

Re: [maven-shade-plugin] 3.2.2 status and open PRs

2020-01-16 Thread Falko Modler
! Best regards, Falko Am 04.01.2020 um 11:57 schrieb Karl Heinz Marbaise: Hi, On 03.01.20 17:11, Falko Modler wrote: Hi everyone, it has been over a year since the last release 3.2.1 and two weeks ago there have been some activities to release 3.2.2 but it seems those commits were (partially

[maven-shade-plugin] 3.2.2 status and open PRs

2020-01-03 Thread Falko Modler
ssigned to 3.2.2, but both are still open: - https://issues.apache.org/jira/browse/MSHADE-340 - https://issues.apache.org/jira/browse/MSHADE-339 Thanks for your attention/help! Best regards and happy 2020, Falko Modler --

Re: More checkstyle API changes

2019-12-23 Thread Falko Modler
Hi Mark, The maven-checkstyle-plugin is rather pretty much hardcoded to a specific checkstyle version. While you _could_ technically exchange the checkstyle dependency it is not really intended. Are you sure it is not really intended? It is actually _documented_: https://maven.apache.org/pl

flatten-maven-plugin maintenance status?

2019-10-06 Thread Falko Modler
Hi everyone, I (and others) have created various pull requests for flatten-maven-pugin over the last months  and the feedback was less than stellar, to put it mildly: https://github.com/mojohaus/flatten-maven-plugin/pulls I am not sure whether Jörg Hohwiller (the primary maintainer?) is reachab

RE: [VOTE] Maven incremental build for BIG-sized projects with local and remote caching [I]

2019-09-18 Thread Falko Modler
sible > >Our idea was to move from workaround solutions(as Tibor classified >this) to native solution. > >Thanks for sharing this. > >Kind regards, >Max > > >-Original Message- >From: Falko Modler [mailto:f.mod...@gmx.net] >Sent: Wednesday, September 18,

Re: [VOTE] Maven incremental build for BIG-sized projects with local and remote caching

2019-09-17 Thread Falko Modler
Hi there, I must admit that I did not read everything but in case you are using Git this extension might help: https://github.com/vackosar/gitflow-incremental-builder It is a Maven extension and it is _not_ limited to Gitflow setups! Disclaimer: I am not the owner of this project but I am a "C