Re: Surefire next release

2021-12-21 Thread Emond Papegaaij
Hi, For what it's worth, I would really like to see https://issues.apache.org/jira/browse/SUREFIRE-1935 / https://github.com/apache/maven-surefire/pull/389 merged. It adds support for the SessionLauncher API in JUnit 5. We rely heavily on this API to prevent expensive components being recreated fo

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-13 Thread Emond Papegaaij
e per fork. I've submitted the PR against surefire: https://github.com/apache/maven-surefire/pull/389 Best regards, Emond On Sun, Sep 12, 2021 at 9:14 PM Emond Papegaaij wrote: > Hi Tibor, > > I've reworked the commit to keep the JUnit version at 1.3 and use > reflecti

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-13 Thread Emond Papegaaij
Sep 13, 2021 at 7:51 AM Marc Philipp wrote: > Hi Emond, > > could you please elaborate why the LauncherSessionListener approach > doesn’t work for forkCount=1 for Arquillian? > > Cheers, > > Marc > > On Sunday, Sep 12, 2021 at 9:37 PM, Emond Papegaaij < > e

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-12 Thread Emond Papegaaij
Hi Marc, Thanks for the links to the documentation. This really helps for my Arquillian-Spock extension. It's good to know the LauncherSession was introduced to solve this issue. The problem I see with this new API is that it requires the extension to explicitly make use of it. For example, the J

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-12 Thread Emond Papegaaij
Hi Tibor, I've reworked the commit to keep the JUnit version at 1.3 and use reflection to get the session. Also, I've fixed the issue with the session used for scanning tests in main thread that remained open. The formatting is now in line with the checkstyle rules and all tests pass. https://gith

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
st regards, Emond Op vr 10 sep. 2021 23:00 schreef Tibor Digana : > Hi Emond, > > Are you looking for this? > > https://github.com/junit-team/junit5/blob/main/documentation/src/test/java/example/UsingTheLauncherDemo.java#L86-L96 > > On Fri, Sep 10, 2021 at 10:49 PM E

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 9:15 PM Emond Papegaaij wrote: > On Fri, Sep 10, 2021 at 8:41 PM Christian Stein > wrote: > >> On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij < >> emond.papega...@gmail.com> >> wrote: >> >> For now, I think the Launch

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 8:41 PM Christian Stein wrote: > On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij > > wrote: > > For now, I think the LauncherSession is the best way to at least provide > > some hooks for pre and post fixtures. It shouldn't be too hard to get

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 6:18 PM Tibor Digana wrote: > We have to dig into Junit 5. Surefire is a streamer of classes across the > forks which is our load balancer. Therefore each class is running > separately, pre and post fixtures. If the Junit 5 used Java Streamer > including dome kind of contr

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
the JUnitPlatformProvider. However, I'm not sure what the intended audience of LauncherSessionListener is. Best regards, Emond On Fri, Sep 10, 2021 at 12:42 PM Emond Papegaaij > wrote: > > > Hi all, > > > > First of all, sorry for the lengthy post. I decided to add some context &g

JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
out on this one and point me in the right direction, as we like to upgrade our test frameworks and this is blocking us at the moment. Best regards, Emond Papegaaij [1] Arquillian extension for Spock Framework 2: https://github.com/topicusonderwijs/arquillian-testrunner-spock/tree/spock-2.0-juni