Re: [jira] (SUREFIRE-1424) javax.transaction.TransactionManager not visible with Java9

2017-09-29 Thread Alan Bateman
On 29/09/2017 08:57, Enrico Olivelli wrote: : 2) dealing with modules like java.sql which as not in java.base (http://download.java.net/java/jdk9/docs/api/java.base-summary.html) Currently I have no solution as there is no official maven dependency for java.sql package You shouldn't need to

Re: module-info hygiene

2016-10-17 Thread Alan Bateman
On 17/10/2016 08:32, Peter Levart wrote: : Do we need an --exclude-modules (in addition to --add-modules) option on javac, java and jlink commands? --exclude-modules would be different to --limit-modules. If some module requires module M and there is no module M on the module path or it is

Re: Specifying module paths

2016-01-15 Thread Alan Bateman
On 15/01/2016 09:06, Robert Scholte wrote: Suppose there's a logging module and a fat module, which also contains the classes of the logging module, but older. In my module-info I have requires logging; requires fat; These modules are in the same directory. Which class is loaded first

Re: RFE support jar as modulepath argument

2015-12-04 Thread Alan Bateman
On 04/12/2015 12:27, Ali Ebrahimi wrote: Just as I said in another thread post: If we have module group concept and modules belong to same module group loaded by same classloader then we can support splited packages. This way each module group maps to each classloader. This will support te

Re: RFE support jar as modulepath argument

2015-12-04 Thread Alan Bateman
On 03/12/2015 19:49, Robert Scholte wrote: After reading the specs it seems like I can only refer to a directory containing modules. For a dependency specified in the pom.xml I could refer to the directory (within the local repository) containing that specific artifact. However, such direct

Re: JavaxToolsCompiler

2015-09-18 Thread Alan Bateman
On 17/09/2015 22:07, Robert Scholte wrote: I can confirm the fix. thanks! Robert Thanks for the confirmation. Just to double check, this is with the ToolProvider fix rather than the patch to the compiler plugin that one of Stuart's mails referenced, right? As we're exchanging mail, I'm cur

Re: JavaxToolsCompiler

2015-09-16 Thread Alan Bateman
On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven. AFAICT this is because it’s now using the service loader mechanism which is influenced by the Thread’s context ClassLoader The follo

Re: JavaxToolsCompiler

2015-09-14 Thread Alan Bateman
On 14/09/2015 20:21, Stuart McCulloch wrote: Yes, the issue is that ToolProvider.getSystemJavaCompiler() is returning null when using the Jigsaw EA with Maven. AFAICT this is because it’s now using the service loader mechanism which is influenced by the Thread’s context ClassLoader That ma

Re: JavaxToolsCompiler

2015-09-14 Thread Alan Bateman
On 14/09/2015 17:40, Robert Scholte wrote: Hi, On behalf of the Apache Maven team I'd like to ask for advice for changing the JavaxToolsCompiler[1] This implementation is used when java code is being compiled with Maven *by default*, so right now when pointing JAVA_HOME to the latest JDK9 ver

Re: Apache Maven JDeps Plugin

2015-04-13 Thread Alan Bateman
On 13/04/2015 03:46, Hervé BOUTEMY wrote: last week, during DevoxxFR, Arnaud and I showed maven-jdeps-plugin: as expected, a lot of users didn't know about this tool So for sure, having this plugin and a report would help Then there is the question of: what should the report look like? Should it