Re: [PR] [MNG-8764] Sort injected lists by @Priority annotation [maven]

2025-06-03 Thread Guillaume Nodet
More verbose code. What’s the benefit? Guillaume Nodet Le mar. 3 juin 2025 à 23:05, Pankraz76 (via GitHub) a écrit : > > Pankraz76 commented on code in PR #2425: > URL: https://github.com/apache/maven/pull/2425#discussion_r2124918459 > > > ## > impl/maven-di/

Re: current setup is leaking quality: [S1161] "@override" should be used on overriding members

2025-06-03 Thread Guillaume Nodet
Most of them are afaik. I spotted a few modules that have not been clearly flagged as deprecated such as maven-artifact though. Fwiw, I'm not saying this PR is useless, it also contains fixes in api/ and they should definitely be merged. Le mar. 3 juin 2025 à 10:45, Andy Law a écrit : > > Are all

Re: current setup is leaking quality: [S1161] "@override" should be used on overriding members

2025-06-03 Thread Andy Law
Are all those bits of “compatibility code” annotated as @Deprecated? Later, Andy From: Guillaume Nodet Date: Tuesday, 3 June 2025 at 09:20 To: Maven Developers List Subject: Re: current setup is leaking quality: [S1161] "@override" should be used on overriding members FWIW, most if not all of

Re: current setup is leaking quality: [S1161] "@override" should be used on overriding members

2025-06-03 Thread Guillaume Nodet
FWIW, most if not all of these changes are in compatibility (I.e. deprecated) code, so while it can be worth fixing things, we should focus on current / used code instead, so those changes are low priority imho. Guillaume Nodet Le mar. 3 juin 2025 à 09:47, Vincent Potuc

current setup is leaking quality: [S1161] "@override" should be used on overriding members

2025-06-03 Thread Vincent Potucek
Hello devs, Given the current state of the Maven codebase—where even basic conventions like proper @Override annotations are not consistently followed, and there's misalignment with JCC—it’s clear that things are out of control. There is a vacuum in chaos waiting to be filled with natural order