Re: Permission to merge?

2025-05-02 Thread Olivier Lamy
In this case better to keep different commits for each different issues (just in case some need to be reverted) On Fri, 2 May 2025 at 9:45 pm, Elliotte Rusty Harold wrote: > Yes, just squash and merge. One approval is all you need. > > We use version control so in a worst case scenario we can al

Re: Permission to merge?

2025-05-02 Thread Elliotte Rusty Harold
Yes, just squash and merge. One approval is all you need. We use version control so in a worst case scenario we can always roll back or revert. More likely if something's wrong we just fix it in a new PR. Merging is not an irreparable commitment, but 99 times out of 100 we just merge and continue

Re: Release tag format for Maven projects

2025-05-02 Thread Romain Manni-Bucau
Hi, My 2 cents would be that in java ecosystem you just do not care and you will find 33% of people liking vN format, 33% N format and 33% $project-$version or variants ($project/$version for ex). I tend to think, until you have some major tooling not supporting the convention (which is not our ca

AW: Release tag format for Maven projects

2025-05-02 Thread Christofer Dutz
Maybe some side-angle from a fellow Apache project In PLC4X we build all of our variants with maven ... also PLC4Go. When releasing we changed tagging of releases to use the „v-notation“ as this allows simpler integration into the Go dependency resolution. However I would not say that this use-c

Re: [VOTE] Require Java 21 for Maven 4 (Rephrased Vote)

2025-05-02 Thread Michael Osipov
-1 Changing such an important requirement in the RC phase isn't professional. On 2025/04/30 13:12:43 Matthias Bünger wrote: > Hi everyone, > over the last years we had several discussions about lifting the > required Java version to run Maven from 8 to something higher. You can > find them in t

Re: [VOTE] Require Java 21 for Maven 4 (Rephrased Vote)

2025-05-02 Thread Enrico Olivelli
+1 (non-binding) Enrico Il giorno ven 2 mag 2025 alle ore 09:41 Niels Basjes ha scritto: > +1 (non-binding) > > On Fri, May 2, 2025 at 8:27 AM Piotr P. Karwasz > > wrote: > > > Hi, > > > > On 30.04.2025 15:12, Matthias Bünger wrote: > > > In a chat with several PMC, committers and contributors

Re: Release tag format for Maven projects

2025-05-02 Thread Michael Osipov
-1 The 'v' is absolutely redundant since it does repeat on every object. See also: https://github.com/apache/maven-release/pull/122 On 2025/05/01 20:30:02 Slawomir Jaranowski wrote: > Hi, > > We introduce a short and the same template release tag name for Maven > projects as: > > v@{project.ve

Re: [VOTE] Require Java 21 for Maven 4 (Rephrased Vote)

2025-05-02 Thread Niels Basjes
+1 (non-binding) On Fri, May 2, 2025 at 8:27 AM Piotr P. Karwasz wrote: > Hi, > > On 30.04.2025 15:12, Matthias Bünger wrote: > > In a chat with several PMC, committers and contributors nobody saw > > strong disadvantages on this. Therefore, I want to start the official > > vote to set the minim