Re: Thought: apply jsr305(nullable,notnull) to maven?

2025-02-10 Thread Xeno Amess
roger. Guillaume Nodet 于2025年2月11日周二 15:20写道: > The resolver API should be avoided in the future as it's supposed > to be hidden by the Maven 4 API. So I'm not sure it's worth it. > > Le mar. 11 févr. 2025 à 08:00, Xeno Amess a écrit : > > > is it good to copy them for resolver? > > > > Guilla

Re: Thought: apply jsr305(nullable,notnull) to maven?

2025-02-10 Thread Guillaume Nodet
The resolver API should be avoided in the future as it's supposed to be hidden by the Maven 4 API. So I'm not sure it's worth it. Le mar. 11 févr. 2025 à 08:00, Xeno Amess a écrit : > is it good to copy them for resolver? > > Guillaume Nodet 于2025年2月11日周二 13:56写道: > > > Maven 4 uses the follow

Re: Thought: apply jsr305(nullable,notnull) to maven?

2025-02-10 Thread Xeno Amess
is it good to copy them for resolver? Guillaume Nodet 于2025年2月11日周二 13:56写道: > Maven 4 uses the following : > > https://github.com/apache/maven/tree/master/api/maven-api-annotations/src/main/java/org/apache/maven/api/annotations > > > > Guillaume Nodet > > > > Le mar. 11

Re: Comments removed in consumer POM

2025-02-10 Thread Romain Manni-Bucau
Le mar. 11 févr. 2025 à 07:32, Guillaume Nodet a écrit : > I think this discussion tends to go away from two important points. > > First, consumer poms NEED to be able to be read by Maven 3. > So you cannot really add any custom namespace, new elements or > anything that would be rejected by Mave

Re: Comments removed in consumer POM

2025-02-10 Thread Guillaume Nodet
I think this discussion tends to go away from two important points. First, consumer poms NEED to be able to be read by Maven 3. So you cannot really add any custom namespace, new elements or anything that would be rejected by Maven 3. You can force the use of a modelVersion > 4.0.0 in the consume

Re: Thought: apply jsr305(nullable,notnull) to maven?

2025-02-10 Thread Guillaume Nodet
Maven 4 uses the following : https://github.com/apache/maven/tree/master/api/maven-api-annotations/src/main/java/org/apache/maven/api/annotations Guillaume Nodet Le mar. 11 févr. 2025 à 05:35, Xeno Amess a écrit : > as title. > during recently learning about maven an

Thought: apply jsr305(nullable,notnull) to maven?

2025-02-10 Thread Xeno Amess
as title. during recently learning about maven and maven-resolver, sometimes I really think it better to have nullable/notnull annotations...

Re: Comments removed in consumer POM

2025-02-10 Thread Elliotte Rusty Harold
On Mon, Feb 10, 2025 at 1:15 PM Xeno Amess wrote: > > well, adding custom elements, makes it cannot pass xsd, right? Depends on what the XSD says. Not that satisfying the XSD is or should be a requirement. > or we shall allow any element name? but that would kill typo check, like if > somebody w

Re: Github issue migration problem

2025-02-10 Thread Sandra Parsick
Sorry for not getting back to you sooner. I was on vacation. it is something we prepared https://lists.apache.org/thread/07p1xyz210755qsl5gt466nyp3tdzmrs I don't know why it did not happen in this migration @Benjamin any idea? The PR linking did work because the step “importing issues” failed

Management of stale issues and PRs

2025-02-10 Thread Slawomir Jaranowski
Hi, I added shared GitHub action to management stale - old issues and PRs. In first step I add an automation for items with label: waiting-for-feedback, and we have for such items: - will mark as stale after 60 days - will close after next 30 days - items with milestone or labels `priority:blocke

Re: Comments removed in consumer POM

2025-02-10 Thread Romain Manni-Bucau
Maybe we can start by just keeping the comments before or nested in kept element and if the comment is before a dropped element (build) we drop it as well? Will not reach 100% but maybe be sufficient to start? Romain Manni-Bucau @rmannibucau | .NET Blog

Re: Comments removed in consumer POM

2025-02-10 Thread Xeno Amess
> And if you ask for my own idea, I would tend to preserve the comments, until there be better solution but sadly I just think in the shitty xml/xsd world, there might never be a better solution.. Xeno Amess 于2025年2月10日周一 21:45写道: > > Side note: technically this doesn't help to move content

Re: Comments removed in consumer POM

2025-02-10 Thread Xeno Amess
> Side note: technically this doesn't help to move content to tags since we have the info of comment location and content already, what we miss is "should we keep it or not" and this is the same for custom xsds - being worse for XSD when they are nested in kept elements so the other topic about cus

Re: Comments removed in consumer POM

2025-02-10 Thread Romain Manni-Bucau
Are we saying comments should be written in tags? I think we are starting to speak about another topic - which is relevant and mainly "how can we handle external XSD securely" - but comment topic stays, as mentionned there are real life use cases for comments where you do not want to go with a cust

Re: Comments removed in consumer POM

2025-02-10 Thread Xeno Amess
well, adding custom elements, makes it cannot pass xsd, right? or we shall allow any element name? but that would kill typo check, like if somebody wrongly said, , and spend a whole day finding what be wrong. or is there some way to allow some...prefix?or allow-all-namespace like or something? Ga

Re: Comments removed in consumer POM

2025-02-10 Thread Gary Gregory
I agree FWIW, this is a problem XML standards solved decades ago. Comments should be considered invisible, in fact many parsers don't surface them. Between processing instructions and namespaces, a tool should have all it needs IMO. Gary On Mon, Feb 10, 2025, 07:45 Elliotte Rusty Harold wrote:

Re: Comments removed in consumer POM

2025-02-10 Thread Elliotte Rusty Harold
On Mon, Feb 10, 2025 at 10:02 AM Xeno Amess wrote: > > > Sometimes comments are used to embed additional machine-readable metadata. > yes and considering somebody would like to use this for a maven extension > or something... Yes, that's a pretty common antipattern. Embedding other markup formats

Re: Comments removed in consumer POM

2025-02-10 Thread Xeno Amess
> Sometimes comments are used to embed additional machine-readable metadata. yes and considering somebody would like to use this for a maven extension or something... Julien Plissonneau Duquène 于2025年2月10日周一 16:47写道: > Hi, > > Le 2025-02-09 20:28, Anders Hammar a écrit : > > After the talk we we

Re: Comments removed in consumer POM

2025-02-10 Thread Julien Plissonneau Duquène
Hi, Le 2025-02-09 20:28, Anders Hammar a écrit : After the talk we were approached by a couple of people from the audience who raised concern about comments in the build POM being removed in the published consumer POM. Sometimes comments are used to embed additional machine-readable metadata