Re: Using git forks

2025-01-04 Thread Christoph Läubrich
Eclipse Platform uses Github for a while now and we have completely switched to using forks for devs and contributors including protecting the main branch from direct pushes as described here[1]. A slight (and convenient) deviation is that you do not clone your fork, but the original repositor

Re: Leveraging SonarQube Cloud (fka SonarCloud)

2025-01-04 Thread Gerd Aschemann
> On 4. Jan 2025, at 22:28, Slawomir Jaranowski wrote: > > On Thu, 2 Jan 2025 at 14:10, Konrad Windszus wrote: >> >> Hi, >> Maven currently does not leverage SonarQube analysis (nor any other static >> code analysis). Although onboarding currently requires one INFRA ticket per >> repo >> (

Re: GitHub Issues - trmplates

2025-01-04 Thread Slawomir Jaranowski
On Sat, 4 Jan 2025 at 22:28, Matthias Bünger wrote: > > Hi, > I personally don't see the benefit of the "improvement" and "new > feature". Even more I think it might confuse people, especially deciding > what is an improvement and what is a new feature. Is a feature only new, > when it's introduci

Re: Leveraging SonarQube Cloud (fka SonarCloud)

2025-01-04 Thread Slawomir Jaranowski
On Thu, 2 Jan 2025 at 14:10, Konrad Windszus wrote: > > Hi, > Maven currently does not leverage SonarQube analysis (nor any other static > code analysis). Although onboarding currently requires one INFRA ticket per > repo > (https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INF

Re: GitHub Issues - trmplates

2025-01-04 Thread Matthias Bünger
Hi, I personally don't see the benefit of the "improvement" and "new feature". Even more I think it might confuse people, especially deciding what is an improvement and what is a new feature. Is a feature only new, when it's introducing anything completly new which wasn't there before or where's t

Re: Using git forks

2025-01-04 Thread Slawomir Jaranowski
We had a list of branches https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dist-tool/job/master/site/dist-tool-branches.html - but now is an issue an report is not generated On Sat, 4 Jan 2025 at 22:00, Gerd Aschemann wrote: > > I am about to run some analysis of the overall Mav

Re: Using git forks

2025-01-04 Thread Gerd Aschemann
I am about to run some analysis of the overall Maven project with jQAssistant in the next weeks (currently I am fighting with some problems with the tool as it is really a large codebase).However, as a quick win I can provide some data about the number of branches.The attached Excel lists all (133)

Re: Using git forks

2025-01-04 Thread Andy Law
I’m a lurker on this list, albeit one that’s wanting to find time to add a feature to the enforcer plugin. I’m with Tamás on this, not least because then all code updates will be coming in through the same route, be they from you outstanding worthies or from us occasional self-interest contribu

GitHub Issues - trmplates

2025-01-04 Thread Slawomir Jaranowski
Hi, Working forward on GitHub Issues I would like to propose a templates for issues: - Bug Report - standard bug report - New Feature Proposal - request for new feature - Improvement Proposal - improvement for existing feature I hope it will be enough ... So my proposed PR: - https://github.co

Re: Using git forks

2025-01-04 Thread Slawomir Jaranowski
On Sat, 4 Jan 2025 at 15:15, Tamás Cservenák wrote: > > Howdy, > > I'd like to ask devs to NOT code directly against branches in ASF > repositories, as we are swamped literally with unwanted spam: I am not > interested in each commit of the branch being worked on. > > Instead, fork the repo and cr

Re: Using git forks

2025-01-04 Thread Slawomir Jaranowski
On Sat, 4 Jan 2025 at 17:11, Elliotte Rusty Harold wrote: > > The tail is wagging the dog here. It sounds like you need to > reconfigure the mailing list to not be so noisy; i.e. to ignore > commits on non-master branches. The problem is the mailing list, not > the branches. It will be difficult

Re: Using git forks

2025-01-04 Thread Slawomir Jaranowski
On Sat, 4 Jan 2025 at 18:17, Konrad Windszus wrote: > > Hi, > There used to be some problems related to CI. At least ASF Jenkins > differentiates between forked PRs and non-forked PRs. > For GitHub Actions there is a difference with regards to permissions > (https://docs.github.com/en/actions/wr

Re: Using git forks

2025-01-04 Thread Tamás Cservenák
Eliotte, don't get me wrong, but i have hard time to follow your reasoning: - i posted how we all are _swamped_ by commit mails as canonical repo is used for development - you came back as "ML is misconfigured" - then I asked you who will clean up these vaguely named branches you create in canonic

Re: Using git forks

2025-01-04 Thread Elliotte Rusty Harold
On Sat, Jan 4, 2025 at 4:20 PM Tamás Cservenák wrote: > > But to continue: what will happen to branches named like "mdo", > "apidoc", "copy", "null" etc in _cnonical maven repo_ if you go > missing? Branches are cheap, but the way these things work if these aren't cleaned up manually, eventually

Re: Using git forks

2025-01-04 Thread Tamás Cservenák
Howdy, am pretty much sure: https://github.com/apache/maven/actions/runs/12606622638 For starters, we haven't used Jenkins since some time... is disabled. Thanks T On Sat, Jan 4, 2025 at 6:17 PM Konrad Windszus wrote: > > Hi, > There used to be some problems related to CI. At least ASF Jenkins

Re: Using git forks

2025-01-04 Thread Konrad Windszus
Hi, There used to be some problems related to CI. At least ASF Jenkins differentiates between forked PRs and non-forked PRs. For GitHub Actions there is a difference with regards to permissions (https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-perm

Re: Using git forks

2025-01-04 Thread Tamás Cservenák
Unsure about the tail, but as I said: I do want to know about changes in the canonical repo. Also, it is not "me", it is ASF setup and AFAIR it was always like it. But to continue: what will happen to branches named like "mdo", "apidoc", "copy", "null" etc in _cnonical maven repo_ if you go missin

Re: Using git forks

2025-01-04 Thread Elliotte Rusty Harold
The tail is wagging the dog here. It sounds like you need to reconfigure the mailing list to not be so noisy; i.e. to ignore commits on non-master branches. The problem is the mailing list, not the branches. On Sat, Jan 4, 2025 at 2:46 PM Tamás Cservenák wrote: > > >>> and shouldn't clutter the c

Re: Using git forks

2025-01-04 Thread Tamás Cservenák
>>> and shouldn't clutter the commit logs. Well, my point is that they DO clutter commit logs, see ML link. On your (private) fork I am not notified about your each commit, while I AM notified about each commit on ASF repo :) Also, I DO want to be notified about ANY change happening in canonical

Re: Using git forks

2025-01-04 Thread Elliotte Rusty Harold
This shouldn't be a problem if we disable everything except squash and merge and require all commits to go through PRs. We do have a big problem with commits that go straight into the source tree without a PR or a code review. Branch vs fork is a red herring. IMHO working on branches is much simpl

Using git forks

2025-01-04 Thread Tamás Cservenák
Howdy, I'd like to ask devs to NOT code directly against branches in ASF repositories, as we are swamped literally with unwanted spam: I am not interested in each commit of the branch being worked on. Instead, fork the repo and create PRs. The commits ML is nearly unusable, I'd really like to se