+1
Le mar. 26 nov. 2024 à 11:07, Guillaume Nodet a écrit :
> Hey,
>
> Note: mvnd 1.x wraps Maven 3.9.x and 2.x wraps Maven 4.x.
>
> This release provides distributions based on Apache Maven 4.0.0-rc-1.
> Note that the above release is still under vote, so this release will be
> cancelled if 4.0.
+1
Were still short of votes…
Guillaume Nodet
Le mar. 26 nov. 2024 à 11:07, Guillaume Nodet a écrit :
> Hey,
>
> Note: mvnd 1.x wraps Maven 3.9.x and 2.x wraps Maven 4.x.
>
> This release provides distributions based on Apache Maven 4.0.0-rc-1.
> Note that the above
Hi Elliotte,
On 29.11.2024 13:27, Elliotte Rusty Harold wrote:
We should do that too in our poms to avoid the recurring and annoying
problems of forgetting to run spotless manually and consequently
having a meaningless break in the CI that needs to be investigated.
Integrated over all of us this
* don't
You are right that spotless will not touch files if you are unable to parse
it.
So let's try.
S.
pt., 29 lis 2024, 22:16 użytkownik Guillaume Nodet
napisał:
> Do or don’t ?
> Wdym “breaking it” ?
> If the code cannot be parsed, the formatted will simply fail (and fail the
> build btw)
Do or don’t ?
Wdym “breaking it” ?
If the code cannot be parsed, the formatted will simply fail (and fail the
build btw), so it won’t modify it.
Guillaume Nodet
Le ven. 29 nov. 2024 à 21:52, Sylwester Lachiewicz
a écrit :
> I do think that's a good idea as it will alw
I do think that's a good idea as it will always format code that may not
yet committed. Potentially breaking it
Sylwester
pt., 29 lis 2024, 21:10 użytkownik Guillaume Nodet
napisał:
> Created the following PR which should work (still to be tested):
>
> https://github.com/apache/maven-parent/pul
Created the following PR which should work (still to be tested):
https://github.com/apache/maven-parent/pull/215
Le ven. 29 nov. 2024 à 18:21, Elliotte Rusty Harold a
écrit :
> While working on a third party plugin I noticed it was configured to
> autorun spotless as part of "mvn test" (and pro
On Fri, Nov 29, 2024 at 10:52 AM Guillaume Nodet wrote:
>
> We can use a profile which would be activated when not on CI. But +1 to
> enable it by default.
https://github.com/jenkinsci/plugin-pom/pull/1017 FTR
-
To unsubscribe,
We can use a profile which would be activated when not on CI. But +1 to
enable it by default.
env.CI !true
Le ven. 29 nov. 2024 à 19:16, Romain Manni-Bucau a
écrit :
> Hi Eliotte,
>
> Not sure it is good for tests but for pom and main it shouldn't run apply
> (at least on the CI, can
Hi Eliotte,
Not sure it is good for tests but for pom and main it shouldn't run apply
(at least on the CI, can be locally) otherwise you would just hide the fact
the style is not respected by formatting it locally on the CI in a PR for
example and therefore merge the broken formatting (and defeati
hi
Who will commit changes if workspase on CI will be changed?
What will be merged if build pass on modified files?
pt., 29 lis 2024, 18:21 użytkownik Elliotte Rusty Harold
napisał:
> While working on a third party plugin I noticed it was configured to
> autorun spotless as part of "mvn test
While working on a third party plugin I noticed it was configured to
autorun spotless as part of "mvn test" (and probably other goals):
[INFO] --- spotless:2.43.0:apply (default) @ spotbugs-maven-plugin ---
[INFO] Spotless.Format is keeping 10 files clean - 0 were changed to
be clean, 0 were alrea
I am a bit worried by
https://github.com/palantir/palantir-java-format/issues/735.
Although I know that also the Google Formatter suffers from this, I am not sure
how resilient that is with respect to future JDK updates.
Konrad
> On 29. Nov 2024, at 10:33, Piotr P. Karwasz wrote:
>
> Hi Benja
Hi Benjamin,
On 28.11.2024 20:31, Benjamin Marwell wrote:
I was not able to reach out to the maintainer. What should we do about it?
I have reached out to my Palantir contacts to see what is going on with
that project.
Input is appreciated. I found palantir/spotless very valuable and I
would
The Apache Maven team is pleased to announce the release of the
Apache Maven 4.0.0-rc-1
Apache Maven is a software project management and comprehension tool.
Based on the concept of a project object model (POM), Maven can manage
a project's build, reporting and documentation from a central piece o
+1
Palantir is by far the best formatter out there. Any means to keep it would
be desirable, in ANY way.
Donation or forking would be feasible when the maintainer is not able to
keep up or needs more help. Not trying to rip it away from them, more like
the thought of offering help.
Is there anyo
16 matches
Mail list logo
