Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Guillaume Nodet
I think it's very feasible to get rid of and replace with in the POM. Without breaking compatibility of course, as we could keep in POM 4.0 and use in POM 4.1. Le lun. 5 août 2024 à 19:38, Oliver B. Fischer a écrit : > > Hi Martin, > > I would say the term module is totally fine. We have, as

Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Oliver B. Fischer
Hi Martin, I would say the term module is totally fine. We have, as everywhere in our human word, a lot of homonyms, everythere. The term module is as good as project or component or even partition. What is more imporant is to have a good definion of a term before using it. So what is the de

Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Gary Gregory
I think it is confusing to document one term and use another in the POM. It would be a different discussion if you proposed to alias to . 2c, Gary On Mon, Aug 5, 2024, 8:24 AM Tamás Cservenák wrote: > Howdy, > > While I somewhat agree, I think that "Maven module" is clear when used in > contex

[VOTE] Release Maven Resolver 1.9.22

2024-08-05 Thread Tamás Cservenák
Howdy, This Resolver 1.9.22 release is a release with memory usage improvements in collectors. Maven 4.x is picking up Resolver 2.x, while Maven 3.x remains at Resolver 1.x lineage. The two major versions, as far as client code goes (Mojos or extensions, using Resolver API as documented), are bin

[VOTE] Release Maven Resolver 2.0.1

2024-08-05 Thread Tamás Cservenák
Howdy, This Resolver 2.0.1 release is a bugfix release with several improvements as well: a bugfix in JDK transport, JDK and Jetty transport improvements, and memory usage improvements in collectors and finally IPC named locks (ported from mvnd, module is Java 17+). Maven 4.x is picking up Resolv

Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Guillaume Nodet
I very dislike the "module" terminology, which is not even reflected in the code / api. The API only has a notion of "Project". The notion of modules is only used while loading the reactor and never used again after. Everything is about "project" in maven, so I disagree with Jeff Jensen. I woul

Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Jeff Jensen
Additionally, since a module is part of a product and project is activity to change a product, I prefer the term "module" (or even "submodule") because they are not "projects" (yes Eclipse and other tools refer to them as "projects" but that is arguably a wrong term). I also would rather clarify t

Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Tamás Cservenák
Howdy, While I somewhat agree, I think that "Maven module" is clear when used in context, also Maven was there before JPMS ;) And finally, as you pointed out, POM will always have a "module" as well. Hence, I am unsure about the value of this terminology change... Yes, it is longer to type "maven

Re: Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Anders Hammar
Hi, The "Maven module" naming is also used outside of the Maven project. E.g. it's used in other tooling such as IDEs, so a change needs to be broadcasted. Not sure it's worth it. /Anders On Mon, Aug 5, 2024 at 2:14 PM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > In order to

Re: Should the Dependency interface contains a getPath() method?

2024-08-05 Thread Tamás Cservenák
Howdy, You are on the right track and Guillame and I had a lot of discussions about this. IMO, best would be to wait for him (is on PTO I think) and have a chat face to face? Thanks T On Mon, Aug 5, 2024 at 2:07 PM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Maven 4 has two

Terminology proposal: "Maven module" -> "Maven sub-project"

2024-08-05 Thread Martin Desruisseaux
In order to avoid confusion between "Maven module" and "Java module", I suggest to update documentation for using "Maven sub-project" instead of "Maven module". However, the XML elements in the POM would be unchanged for compatibility reason. There is apparently not so many places in the docum

Re: Should the Dependency interface contains a getPath() method?

2024-08-05 Thread Martin Desruisseaux
Le 2024-08-05 à 14 h 07, Martin Desruisseaux a écrit : * Optional getModuleModuleDescriptor() Typo: should be getModuleDescription(). It was a copy-and-paste error.     Martin

Re: Proposal: remove warning about file encoding not set

2024-08-05 Thread Tamás Cservenák
+1 for removing this warning On Mon, Aug 5, 2024 at 1:22 PM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > In Maven 3, if the configuration parameter or the > "project.build.sourceEncoding" property is not set, the compiler emits a > warning like below: > > > File encoding has

Proposal: remove warning about file encoding not set

2024-08-05 Thread Martin Desruisseaux
In Maven 3, if the configuration parameter or the "project.build.sourceEncoding" property is not set, the compiler emits a warning like below: > File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent! However since Java 18, the default encoding in a

maven-compiler-plugin 4: integration tests completed

2024-08-05 Thread Martin Desruisseaux
Hello all The proposed maven-compiler-plugin version 4 now passes the integration tests. It has reached a state where it could (theoretically) be used instead of version 3, but there is probably some more bugs to discover. Many tests had to be modified, and a few of them have been deleted. The