Re: [VOTE] Release Maven Javadoc Plugin version 3.6.2

2023-11-04 Thread Michael Osipov
Am 2023-11-04 um 19:13 schrieb Slawomir Jaranowski: +1 One broken link - https://maven.apache.org/plugins-archives/maven-javadoc-plugin-LATEST/jira-report.html OVERVIEW -> Release Notes Thanks, fixed. - To unsubscribe, e-mai

Re: [VOTE] Release Maven Javadoc Plugin version 3.6.2

2023-11-04 Thread Slawomir Jaranowski
+1 One broken link - https://maven.apache.org/plugins-archives/maven-javadoc-plugin-LATEST/jira-report.html OVERVIEW -> Release Notes pt., 3 lis 2023 o 21:43 Michael Osipov napisał(a): > Hi, > > We solved 7 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&v

Re: Maven 5 pom extension for agents

2023-11-04 Thread Romain Manni-Bucau
Ps (seems i lost a paragraph): how does it work in consumer pom, breaks most consumers which will assume right a single jar cant be found twice in deps no? Le sam. 4 nov. 2023 à 14:39, Romain Manni-Bucau a écrit : > I still see it as abusing of extension to create sets. > Means you can only do i

Re: Maven 5 pom extension for agents

2023-11-04 Thread Romain Manni-Bucau
I still see it as abusing of extension to create sets. Means you can only do it while it is jars - how would it work with .jmod for ext? Now the critical part: how do plugin know about it? Ie is it better to define a ton of potentially conflicting default names + add name config in all plugins or

Re: Maven 5 pom extension for agents

2023-11-04 Thread Martin Desruisseaux
Le 2023-11-04 à 14 h 02, Tamás Cservenák a écrit : What would a dependency type=jar, sources be? That represents two different files... Okay, it makes sense to avoid multi-types then. On a second though, even when the file is the same, some types are mutually exclusive (e.g. "classpath" and

Re: Maven 5 pom extension for agents

2023-11-04 Thread Tamás Cservenák
No, imho a dependency cannot have two or more types: we are focused on this topic (jar vs module) but type is more than that, think sources. In former case we talk about same file (artifact.jar) but representing different thing (cp or mp candidate). What would a dependency type=jar, sources be? T

Re: Maven 5 pom extension for agents

2023-11-04 Thread Martin Desruisseaux
Le 2023-11-04 à 13 h 47, Romain Manni-Bucau a écrit : How does an artifact has 2 types (it is the main issue with this design)? I also thought about that. For an initial version, Tamas's proposal would work. For a solution that avoid repetition, maybe should allow a comma or space-separated

Re: Maven 5 pom extension for agents

2023-11-04 Thread Tamás Cservenák
Like this https://gist.github.com/cstamas/dd3795fd47f15a28d48a8c03fa9dd939 This is completely legal from mvn pov (no warning, unlike same artifact in two scopes) T On Sat, Nov 4, 2023, 13:48 Romain Manni-Bucau wrote: > How does an artifact has 2 types (it is the main issue with this design)?

Re: Maven 5 pom extension for agents

2023-11-04 Thread Romain Manni-Bucau
How does an artifact has 2 types (it is the main issue with this design)? Le sam. 4 nov. 2023 à 11:05, Tamás Cservenák a écrit : > So, just for fun, I used MIMA /w local mods (MIMA is vanilla mvn39 models + > resolver1) to resolve one of my demo modules: > (neglect the root type of "dinosaur"...

Re: Maven 5 pom extension for agents

2023-11-04 Thread Martin Desruisseaux
Le 2023-11-03 à 21 h 30, Romain Manni-Bucau a écrit : The proposal would put the dependency on whatever path the said it should be. Means you create as much type as plugin*pathTypePerPlugin, looks overkill. The current set of new path types would contain about 6 types (class, module, tagl

Re: Maven 5 pom extension for agents

2023-11-04 Thread Tamás Cservenák
So, just for fun, I used MIMA /w local mods (MIMA is vanilla mvn39 models + resolver1) to resolve one of my demo modules: (neglect the root type of "dinosaur"...Also, this is really simplified, _resolving_ this graph would FAIL, as MIMA has no idea what "module" type is, as can be seen in GAVs, whe

Re: Maven 5 pom extension for agents

2023-11-04 Thread Tamás Cservenák
Well, I have to disagree... Maven Core has no idea what "add to classpath" means, and the flag is not even used in core. Same would stand for MP etc. Maven Core (simplified: the POM) tells WHAT IT IS only. Maven Plugin is the one who uses the core provided information to process things. So Plugin

Re: Maven 5 pom extension for agents

2023-11-04 Thread Romain Manni-Bucau
Yes, this is the part I find broken in maven design (even mvn3) 1nd hope we stop abusing. Also note it keeps the flag per maven module whereas we have a need per plugin. So first step is to fix plugin config to get them filters of artifacts per their "paths" and sounds like it will be sufficient, n

Re: Maven 5 pom extension for agents

2023-11-04 Thread Tamás Cservenák
So, just to explain w/ code: In Maven3 ArtifactHandler (type=id selects a handler) looks like this: https://github.com/apache/maven/blob/maven-3.9.x/maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java#L55 And you can spot the two boolean "lfags": addedToClasspath (C

Re: Maven 5 pom extension for agents

2023-11-04 Thread Tamás Cservenák
Well, even mvn3 works like it today, except it has "fixed set" of flags. All i did is opened up the number of possible flags, added MP (next to existing CP flag from mvn 3). Types were really eztensible in mvn3 as well, but less expressive with fixed set of flags. Basically even in mvn3, an artifa

Re: Maven 5 pom extension for agents

2023-11-04 Thread Romain Manni-Bucau
Doesnt it mean you dont need type at all. I understand the idea to add new method in the handler but this is really a weird design and still blocked by the predefined set so user is still locked by design so not sure how it helps to rely on type. Le ven. 3 nov. 2023 à 21:44, Tamás Cservenák a écr