Re: Gratuitous refactorings

2023-07-05 Thread Henning Schmiedehausen
This is most likely a bot "warming up" by contributing to some well-known (high-reputation) repository. Merging those will allow them to build a reputation for things like "sell stars for github repos". - https://the-guild.dev/blog/judging-open-source-by-github-stars - https://dagster.io/blog/fake

Re: Gratuitous refactorings

2023-07-05 Thread Jeremy Landis
Looks like classwork for sure. I think intent on pull request needs to be present to explain the value and maybe contributor guide should state that if it does not. The change appears to be from sonar rules. It's clearly some form of classwork when user has no GitHub history. Many classes now

Gratuitous refactorings

2023-07-05 Thread Elliotte Rusty Harold
Lately I've noticed a few random PRs from first time contributors that use some automated refactoring tool on our code for no obvious reason. Here's an example: https://github.com/apache/maven-assembly-plugin/pull/131 These refactorings don't seem helpful and don't IMO improve the code in any way