Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Gary Gregory
Ah, I was misled by the PR title then. Thank you for the clarification! Gary On Sat, May 20, 2023, 12:53 Elliotte Rusty Harold wrote: > On Sat, May 20, 2023 at 3:33 PM Gary Gregory > wrote: > > > > Please don't change the default behavior to exclude test sources! > > Non-binding -1 from me. >

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Elliotte Rusty Harold
On Sat, May 20, 2023 at 3:33 PM Gary Gregory wrote: > > Please don't change the default behavior to exclude test sources! > Non-binding -1 from me. > If you're referring to #76, that's not what it does. Test sources are still checked. What changes is that **generated code**, test and non-test ali

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Gary Gregory
Please don't change the default behavior to exclude test sources! Non-binding -1 from me. Some tests serve as nice examples. I also want to enforce checkstyle for PR sources consistently whether the changes are in main or test. Please don't accepting this as is and make me edit dozens and dozens

Re: [VOTE] Release Maven Checkstyle Plugin version 3.3.0

2023-05-20 Thread Elliotte Rusty Harold
https://github.com/apache/maven-checkstyle-plugin/pull/76 is in progress from an external developer and is, IMHO, a quite nice improvement. Might be worth waiting for this to be finished up. Otherwise, I found some minor issues in dependencies and the tests, but nothing blocking. On Fri, May 19,

Re: maven 3.9.x warnings

2023-05-20 Thread Romain Manni-Bucau
Le sam. 20 mai 2023 à 10:22, Slawomir Jaranowski a écrit : > Hi, > > We have two kinds of causes which can emit warnings: > 1. wrong using of plugin by user like use deprecated or unexisting > parameters, using deprecated goals > 2. wrong implementation in plugin, eg scope, EOL components > > Fir

Re: maven 3.9.x warnings

2023-05-20 Thread Slawomir Jaranowski
Hi, We have two kinds of causes which can emit warnings: 1. wrong using of plugin by user like use deprecated or unexisting parameters, using deprecated goals 2. wrong implementation in plugin, eg scope, EOL components First group should be displayed - because the end user can fix their own build

Re: maven resolver beyond 1.6.x

2023-05-20 Thread Michael Osipov
Am 2023-05-20 um 00:35 schrieb Henning Schmiedehausen: Hi, The page on https://maven.apache.org/resolver/maven-3.8.x.html states that *"Since version 1.7.0, Maven Resolver requires Java 8 to run and a brand new default sync context factory has been implemented."*. Assuming for a moment that Jav