Re: [VOTE] Release Maven Wagon version 3.5.3

2022-12-20 Thread Herve Boutemy
+1 Reproducible Builds ok: reference build done with JDK 8 on Windows Regards, Hervé On 2022/12/18 21:57:37 Michael Osipov wrote: > Hi, > > We solved 1 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318122&version=12352696 > > There are still a couple of issues l

Re: [VOTE] Release Apache Maven Daemon 1.0.0-m1

2022-12-20 Thread Hervé Boutemy
+1 Reproducible Builds: - ok on .zip distribution, including rebuilding native library (in native/) - ko on .tar.gz distribution: │ -gzip compressed data, from FAT filesystem (MS-DOS, OS/2, NT) │ +gzip compressed data I don't know why... And GraalVM binary native distributions are not Reproduci

[GitHub] [maven-shared-incremental] olamy commented on a diff in pull request #18: store last compilation time

2022-12-20 Thread GitBox
olamy commented on code in PR #18: URL: https://github.com/apache/maven-shared-incremental/pull/18#discussion_r1054007576 ## src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java: ## @@ -48,6 +52,13 @@ public static final String CREATED_FILES_LST_FI

[GitHub] [maven-shared-incremental] olamy commented on pull request #18: store last compilation time

2022-12-20 Thread GitBox
olamy commented on PR #18: URL: https://github.com/apache/maven-shared-incremental/pull/18#issuecomment-1360885857 > Doesnt goal and execid are sufficient to avoid isTest need? It is in the key already. ideally this could be used by other mojos than m-compiler-p so we probably don't

Re: [VOTE] Release Maven Wagon version 3.5.3

2022-12-20 Thread Olivier Lamy
+1 On Mon, 19 Dec 2022 at 07:57, Michael Osipov wrote: > > Hi, > > We solved 1 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318122&version=12352696 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/issues/?jql=project%20%3D%20WAG

Re: [VOTE] Release Apache Maven Daemon 1.0.0-m1

2022-12-20 Thread Olivier Lamy
+1. (but need to find projects not using flatten-maven-plugin as this doesn't work with core 4.0.0-alpha-3) On Fri, 16 Dec 2022 at 23:07, Guillaume Nodet wrote: > > I've staged a candidate release at > https://dist.apache.org/repos/dist/dev/maven/mvnd/1.0.0-m1/ > > Note that this release is bas

AW: Surefire Plugin Pull Requests

2022-12-20 Thread Pabst, Andreas
Hi again, thanks Slawomir and Michael for reviewing and merging the additional PRs I created that fix both the GitHub artifact upload and the failing build on Linux with JDK 18. I'd like to renew my request for a review of the PR I originally intended to get merged (#568) which would fix the

Re: [VOTE] Release Maven Wagon version 3.5.3

2022-12-20 Thread Michael Osipov
Am 2022-12-19 um 00:05 schrieb Slawomir Jaranowski: +1 - old parent - the most of mailing lists addresses was not working Those are something for the next major. 3.x won't change in this regard anymore. - To unsubscribe, e

Re: [VOTE] Release Maven Wagon version 3.5.3

2022-12-20 Thread Michael Osipov
Am 2022-12-18 um 22:57 schrieb Michael Osipov: Hi, We solved 1 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318122&version=12352696 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20WAGON%20AND%20resolution%