Re: Polyglot usage of components/Dependency graph API

2022-11-22 Thread Romain Manni-Bucau
Do you mean the container.lookup fails? Normally, with the metadata in the jar, the default impl ( https://github.com/apache/maven-dependency-tree/blob/master/src/main/java/org/apache/maven/shared/dependency/graph/internal/DefaultDependencyGraphBuilder.java) should be returned. If not maybe ensure

Re: Polyglot usage of components/Dependency graph API

2022-11-22 Thread Patrick Plenefisch
Getting the DependencyGraphBuilder to be on the classpath is turning out trickier than anticipated. I added both normal dependencies, and as a dependency inside the plugin, but neither seems to be resolved. Do I have to manually resolve this dependency inside the mojo? ...

Re: Polyglot usage of components/Dependency graph API

2022-11-22 Thread Patrick Plenefisch
irb(#):002:0> ctx.session.container => # Well, would you look at that! Literal hours of staring at the javadoc over multiple days and yet somehow I missed that. Though to be fair I did type .context and search the javadoc and code for "context" before I realized you said "container". Though it is

Re: Polyglot usage of components/Dependency graph API

2022-11-22 Thread Romain Manni-Bucau
*ctx.session.container* ? Le mar. 22 nov. 2022 à 16:23, Patrick Plenefisch a écrit : > No, how would I do that with the released version of Mojo today? I know the > standard version of injecting for java uses a field and an annotation, but > I'm not writing java, and I don't know how to adapt t

Re: Polyglot usage of components/Dependency graph API

2022-11-22 Thread Patrick Plenefisch
No, how would I do that with the released version of Mojo today? I know the standard version of injecting for java uses a field and an annotation, but I'm not writing java, and I don't know how to adapt that to my polyglot pom-inline code: https://github.com/jruby/jruby/blob/master/lib/pom.rb#L209

Re: Polyglot usage of components/Dependency graph API

2022-11-22 Thread Romain Manni-Bucau
Hi Patrick, Did you try injecting PlexusContainer? It is not the most sexy and modern way to do it but it fits quite well the scripting language since the container enables to lookup anything, it is just a matter of injecting it in the mojo then forwarding it to the script. Side note: I assume a

Polyglot usage of components/Dependency graph API

2022-11-22 Thread Patrick Plenefisch
Hi, How can I query a specific dependency's *resolved* transitive dependencies inside a class executed by a mojo? I have access to session and project, and that's it. I looked at DependencyGraphBuilder and the underlying ProjectDependenciesResolver, but those seem to be injected. While I can genera

Re: [HEADS UP] Master update to parent pom 38 with JDK 1.8 and new code style

2022-11-22 Thread Guillaume Nodet
Argh, sorry, the "rebase/merge" does not work... Le mar. 22 nov. 2022 à 15:26, Guillaume Nodet a écrit : > Yes, good point. One can also explicitly "rebase / merge" if there has > been no commit between the PR and the master branch. > > Le mar. 22 nov. 2022 à 15:19, Slawomir Jaranowski > a écr

Re: [HEADS UP] Master update to parent pom 38 with JDK 1.8 and new code style

2022-11-22 Thread Guillaume Nodet
Yes, good point. One can also explicitly "rebase / merge" if there has been no commit between the PR and the master branch. Le mar. 22 nov. 2022 à 15:19, Slawomir Jaranowski a écrit : > Hi, > > Great work. > > Please take care - that commit sha will be changed after rebase PR. Should > be added

Re: [HEADS UP] Master update to parent pom 38 with JDK 1.8 and new code style

2022-11-22 Thread Slawomir Jaranowski
Hi, Great work. Please take care - that commit sha will be changed after rebase PR. Should be added at new PR or direct commit. wt., 22 lis 2022 o 14:43 Guillaume Nodet napisał(a): > As discussed in the last weeks, I've pushed an upgrade to maven parent 38 > which has the new code style enforc

[HEADS UP] Master update to parent pom 38 with JDK 1.8 and new code style

2022-11-22 Thread Guillaume Nodet
As discussed in the last weeks, I've pushed an upgrade to maven parent 38 which has the new code style enforced. The auto-formatting can be enabled using the format profile. The parent POM raises the minimum JDK requirement to JDK 1.8. Note that any component upgrading to the maven parent pom 38

[ANN] Apache Maven Parent POMs 38 Released

2022-11-22 Thread Guillaume Nodet
The Apache Maven team is pleased to announce the release of the Maven Parent POMs Version 38. Maven Parent POMs include Maven Parent POM itself, but also Maven Plugins Parent POM, Maven Shared Components Parent POM, Maven Skins Parent POM and Maven Doxia Tools Parent POM. https://maven.apache.org

[ANN] Apache Software Foundation Parent POM Version 28 Released

2022-11-22 Thread Guillaume Nodet
The Apache Maven team is pleased to announce the release of the Apache Software Foundation Parent POM Version, version 28 https://maven.apache.org/pom/asf/ You should specify the version in your project as parent like the following: org.apache apache 28 You can download the appropriate

Re: [VOTE] Maven Apache Parent 28 - Maven Shared Resources 5 - Maven Parent 38

2022-11-22 Thread Guillaume Nodet
+1 Le mar. 15 nov. 2022 à 10:18, Guillaume Nodet a écrit : > I've staged a few releases: > * Maven Apache Parent Pom 28 > * Maven Shared Resources 5 > * Maven Parent Pom 38 > > Release notes for ASF-28 > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250&version=12

Re: [DISCUSS] Quo Vadis Maven Site

2022-11-22 Thread Hervé Boutemy
yes, using a nowadays de-facto standard Markup language like asciidoc or Markdown as a pivot is one the the good ideas from this discussion and I feel it could be a concrete step implemented independently, going in the right direction without being disruptive, that could open tests for tests on