Re: [VOTE] Release Apache Maven Reporting API version 3.1.1

2022-07-29 Thread Sylwester Lachiewicz
+1 pt., 29 lip 2022, 22:57 użytkownik Slawomir Jaranowski < s.jaranow...@gmail.com> napisał: > +1 > > pt., 29 lip 2022 o 22:31 Michael Osipov napisał(a): > > > Hi, > > > > We solved 1 issue: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12352152 > >

Re: [VOTE] Release Apache Maven Reporting API version 3.1.1

2022-07-29 Thread Slawomir Jaranowski
+1 pt., 29 lip 2022 o 22:31 Michael Osipov napisał(a): > Hi, > > We solved 1 issue: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12352152 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20M

Re: [VOTE] Release Apache Maven Reporting API version 3.1.1

2022-07-29 Thread Michael Osipov
Am 2022-07-29 um 22:31 schrieb Michael Osipov: Hi, We solved 1 issue: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12352152 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution

[VOTE] Release Apache Maven Reporting API version 3.1.1

2022-07-29 Thread Michael Osipov
Hi, We solved 1 issue: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12352152 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20ma

Re: [VOTE] Release Maven SCM version 2.0.0-M2

2022-07-29 Thread Michael Osipov
Am 2022-07-28 um 21:02 schrieb Michael Osipov: Hi, We solved 24 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317828&version=12351598 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/SCM/issues Staging repo: https://repositor

Re: Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Tamás Cservenák
Don't mix in plexus (is dead). You need Guice spi TypeConverter. T On Fri, Jul 29, 2022, 16:22 Romain Manni-Bucau wrote: > Hi Konrad, > > Guess what you are looking for is > > https://github.com/eclipse/sisu.plexus/blob/27a29dc633e6b03753a3c8d29a033648630c8831/org.eclipse.sisu.plexus/src/org/ec

Re: Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Romain Manni-Bucau
Injections can work, the small note on path converter is that it must have the same handling than file one and be relative to basedir by default probably (and not the working dir) which seems missed in the linked commit. Romain Manni-Bucau @rmannibucau | Blog

Re: Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Konrad Windszus
I now created https://github.com/eclipse/sisu.plexus/issues/21, but I am not sure if we always need a dedicated plexus converter or the Plexus shim can also rely on the one provided by Sisu.Inject. As soon as I have some feedback in the ticket I am gonna work on a PR for it and also for https://

Re: Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Jorge Solórzano
Hi Konrad, If I'm not wrong, Eclipse Sisu handles the conversion of parameters, so yes right now only java.io.File type is supported. Maven currently uses Sisu 0.3.5 , and there is a pre-release of Sisu (0.9.0.M1

Re: Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Konrad Windszus
Thanks for the answer. I meanwhile found https://github.com/eclipse/sisu.inject/commit/2676001d31a06fe94d2d9a167c5f078c2eba4f5a, but IMHO SISU 0.9.0-M1 is not used in any released Maven yet, so for the time being I am bound to using File parameters, right? Konrad On 2022/07/29 14:21:57 Romain

Re: Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Romain Manni-Bucau
Hi Konrad, Guess what you are looking for is https://github.com/eclipse/sisu.plexus/blob/27a29dc633e6b03753a3c8d29a033648630c8831/org.eclipse.sisu.plexus/src/org/eclipse/sisu/plexus/CompositeBeanHelper.java#L250 which uses https://github.com/eclipse/sisu.plexus/blob/27a29dc633e6b03753a3c8d29a03364

Mojo parameters of type java.nio.file.Path

2022-07-29 Thread Konrad Windszus
Hi, According to https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#files-and-directories only java.io.File type parameters are supported for dealing with file paths. I was assuming that every complex type is supported which has a constructor taking a single String value