Proposing various improvements

2022-05-18 Thread Sebastien Doyon
Hi, Recently I found some small potential improvements that could help clean the maven code. I would be glad to contribute it back to my most useful Java project, if you find it of interest. The changes are mostly : - Use of Collections.emptyList() instead of new ArrayList() when possible. - U

Re: Maven plugins - injecting Maven components

2022-05-18 Thread Romain Manni-Bucau
Le mer. 18 mai 2022 à 15:19, Stuart McCulloch a écrit : > On Wed, 18 May 2022 at 14:15, Romain Manni-Bucau > wrote: > > > Le mer. 18 mai 2022 à 15:03, Stuart McCulloch a > écrit > > : > > > > > I do wonder whether we're conflating the real issues of exposing the > CDI > > > API (for @Typed) wit

Re: Maven plugins - injecting Maven components

2022-05-18 Thread Stuart McCulloch
On Wed, 18 May 2022 at 14:15, Romain Manni-Bucau wrote: > Le mer. 18 mai 2022 à 15:03, Stuart McCulloch a écrit > : > > > I do wonder whether we're conflating the real issues of exposing the CDI > > API (for @Typed) with the much smaller JSR330 API > > > > Yes as soon as you have a different ver

Re: Maven plugins - injecting Maven components

2022-05-18 Thread Romain Manni-Bucau
Le mer. 18 mai 2022 à 15:03, Stuart McCulloch a écrit : > I do wonder whether we're conflating the real issues of exposing the CDI > API (for @Typed) with the much smaller JSR330 API > Yes as soon as you have a different version needed by a plugin and the api exposed (parent first forced - and i

Re: Maven plugins - injecting Maven components

2022-05-18 Thread Stuart McCulloch
I do wonder whether we're conflating the real issues of exposing the CDI API (for @Typed) with the much smaller JSR330 API Does anyone have a link to an issue that specifically involved exporting the JSR330 API (I did a quick search but the threads I found were all about the CDI API) IIRC there wa

Re: Maven plugins - injecting Maven components

2022-05-18 Thread Romain Manni-Bucau
Le mer. 18 mai 2022 à 11:52, Jason van Zyl a écrit : > I have used SLF4J and JSR330 in plugins for years without issue. They all > still work and nothing has mysteriously stopped working even made 7+ years > ago. I honestly don’t see much point in making our own annotations, and > I’ve not encoun

Re: Maven plugins - injecting Maven components

2022-05-18 Thread Jason van Zyl
I have used SLF4J and JSR330 in plugins for years without issue. They all still work and nothing has mysteriously stopped working even made 7+ years ago. I honestly don’t see much point in making our own annotations, and I’ve not encountered any of the issues Romain presents. To Romain’s points