Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Mark Derricutt
I’m wondering (off the cuff thought here) if having a stronger design difference between a standard Mojo, and an Extension might be useful? As general mojo/plugin - having an injected immutable MavenProject *view* is probably fine, but for an extension I probably want a mutable MavenProject.Builde

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Romain Manni-Bucau
I think the number of plugin doing it is not that small, now the question is: what's the difference (technically) between a project you can mutate and a project manager mutating the project state? Idea behind is to NOT inject the MavenProject in any mojo but inject a proxy/decorated instance which

Re: [VOTE] - Release Apache Maven Shade Plugin Version 3.3.0

2022-03-28 Thread Sylwester Lachiewicz
+1 pon., 28 mar 2022, 18:29 użytkownik Karl Heinz Marbaise napisał: > +1 > from me. > > kind regards > Karl Heinz Marbaise > On 24.03.22 19:21, Karl Heinz Marbaise wrote: > > Hi, > > > > We solved 16 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=

Re: [VOTE] - Release Apache Maven Shade Plugin Version 3.3.0

2022-03-28 Thread Olivier Lamy
+1 On Fri, 25 Mar 2022 at 04:21, Karl Heinz Marbaise wrote: > Hi, > > We solved 16 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12348391&styleName=Text > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Matt Benson
As a developer I appreciate the concept of immutability. At the same time, having written more than one (proprietary) plugin that mutates the project model, I would hate to see my options in this regard diminished particularly if the future situation were one that forces me to modify the Maven inst

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Mark Derricutt
We’re over at https://github.com/repaint-io/maven-tiles What we’re doing is essential “evil” and mixing in “tiles” as implicit parents. It’s it’s no longer possible with 4.x - and if 4.x could provide something similar, with a transition path we could document, I’m down with sunsetting the proj

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Guillaume Nodet
Le lun. 28 mars 2022 à 21:22, Mark Derricutt a écrit : > I wonder how much of this will break what we do with the > tiles-maven-plugin, where we essentially “inject” parents into the model > via a maven extension. > Interesting. Do you have a pointer to that plugin's source code ? Guillaume

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Mark Derricutt
I wonder how much of this will break what we do with the tiles-maven-plugin, where we essentially “inject” parents into the model via a maven extension. I remember I was seeing some odd issues under earlier builds of 4.x as well some time ago but will need to refresh my memory on what that was no

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Guillaume Nodet
What I have in mind is that plugins that use the new api would receive the immutable model, while plugins that use the old (3.x) api would receive a model that would wrap the immutable one. However, I think mutating the model or the maven project should be done via services provided by the maven ap

Re: [VOTE] - Release Apache Maven Shade Plugin Version 3.3.0

2022-03-28 Thread Karl Heinz Marbaise
Hi, can I get some more PMC VOTE's because there are not enough PMC votes yet... formally I need one more PMC Vote... Kind regards Karl Heinz Marbaise On 24.03.22 19:21, Karl Heinz Marbaise wrote: Hi, We solved 16 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=123

Re: [VOTE] - Release Apache Maven Shade Plugin Version 3.3.0

2022-03-28 Thread Karl Heinz Marbaise
+1 from me. kind regards Karl Heinz Marbaise On 24.03.22 19:21, Karl Heinz Marbaise wrote: Hi, We solved 16 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12348391&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.

JDK 18 General Availability, and oracle-actions/setup-java

2022-03-28 Thread David Delabassee
Greetings! JDK 18 has been released (General Availability) on March 22nd as planned, the release cadence is working like clockwork! As a small token of gratitude, some of you have been specifically acknowledged in the "The Arrival of Java 18" announcement [1]. On behalf of the entire team, le

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Matt Benson
So in the new API, what kind of component would receive a mutable model if not a plugin? I.e., what would be the correct mechanism for enhancing the project model at runtime? Matt On Mon, Mar 28, 2022, 4:33 AM Guillaume Nodet wrote: > Hi everyone, > > Last week, I worked on a fully immutable ma

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Romain Manni-Bucau
+1 to move that way but also +1 to keep plugins working (I don't see all plugins of the ecosystem being rewritten within 5 years so a light plugin compat layer would be neat). Romain Manni-Bucau @rmannibucau | Blog | Old Blog <

Re: [DISCUSS] New Maven Core API for 4.x

2022-03-28 Thread Guillaume Nodet
Hi everyone, Last week, I worked on a fully immutable maven model. The results are available at [1]. The modifications required in modello were a bit too complicated, so I ended up using the modello models, but generating the models, readers and writers using velocity templates. The templates are

Surprises on maven 4

2022-03-28 Thread Romain Manni-Bucau
Hi all, For an output check (thanks again Michael for the pointer), I tested maven master/4 this morning and get a few question marks: 1. I know we warn when a plugin has no lock version but it also means we implicitly force to define a plugin and warn we defined it, this does not make much sense