[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-26 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952594433 oh, yes, sorry, please forget my previous comment: morning coffe took more time than I expected to warm up my brain :) Yes, having `mvnw` script (stored in source

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-26 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952590460 I think that running `mvn` from Maven distribution will be better ... Some change to maven scripts can be depend on Maven core code like: https://github.co

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #16: Execute test on proper branch

2021-10-26 Thread GitBox
slawekjaranowski commented on pull request #16: URL: https://github.com/apache/maven-gh-actions-shared/pull/16#issuecomment-952578883 not needed .. yet .. I must do more tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [maven-gh-actions-shared] slawekjaranowski closed pull request #16: Execute test on proper branch

2021-10-26 Thread GitBox
slawekjaranowski closed pull request #16: URL: https://github.com/apache/maven-gh-actions-shared/pull/16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-26 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-952568787 yes, instead of copying by hand partial scripts from https://github.com/apache/maven/tree/master/apache-maven/src/assembly/shared to current project source https://git

[GitHub] [maven-site] dependabot[bot] opened a new pull request #270: Bump ant from 1.10.11 to 1.10.12

2021-10-26 Thread GitBox
dependabot[bot] opened a new pull request #270: URL: https://github.com/apache/maven-site/pull/270 Bumps ant from 1.10.11 to 1.10.12. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.ant:ant&package-m

[GitHub] [maven-site] slawekjaranowski commented on pull request #268: IntelliJ IDEA - code style for Groovy

2021-10-26 Thread GitBox
slawekjaranowski commented on pull request #268: URL: https://github.com/apache/maven-site/pull/268#issuecomment-952305785 Easy but can be useful ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-wrapper-plugin] slachiewicz merged pull request #3: improve gitignore

2021-10-26 Thread GitBox
slachiewicz merged pull request #3: URL: https://github.com/apache/maven-wrapper-plugin/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev

Re: Maven Code Style and imports layouts

2021-10-26 Thread Slawomir Jaranowski
Hi, Benjamin - thanks for voting. Can we finish this task? I assume that there are no -1 votes so it should be processed ... Any other suggestions, improvements? pon., 18 paź 2021 o 08:28 Benjamin Marwell napisał(a): > +1! > > Sandra and I tried similar Suggestions a while back. > This will

[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #16: Execute test on proper branch

2021-10-26 Thread GitBox
slawekjaranowski opened a new pull request #16: URL: https://github.com/apache/maven-gh-actions-shared/pull/16 Test has static reference for branch, so should be executed on corresponding branch -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #15: Complete example of usage

2021-10-26 Thread GitBox
slawekjaranowski opened a new pull request #15: URL: https://github.com/apache/maven-gh-actions-shared/pull/15 simplifies copy and paste -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Thank you! JDK 18 Early Access build 20 is now available

2021-10-26 Thread Rory O'Donnell
Hi Robert , *Thank you.* I'm retiring at the end of November 2021, it's time to spend more time with the family. We started the Quality Outreach back in October 2014.  We now have 170+ projects participating. Thank you for taking the time to provide Testing feedback , excellent bugs and sup

[GitHub] [maven-doxia] dependabot[bot] opened a new pull request #72: Bump xmlunit-core from 2.7.0 to 2.8.3

2021-10-26 Thread GitBox
dependabot[bot] opened a new pull request #72: URL: https://github.com/apache/maven-doxia/pull/72 Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.7.0 to 2.8.3. Release notes Sourced from https://github.com/xmlunit/xmlunit/releases";>xmlunit-core's releases.

[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-26 Thread GitBox
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951816397 @slawekjaranowski if that would work, that would be a much more acceptable solution for me. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [maven-wrapper-plugin] slawekjaranowski commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-26 Thread GitBox
slawekjaranowski commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951775639 Another idea ... why not simply call `mvn*` scripts from Maven distribution ... of course after needed job for wrapper like downloading In this case code