[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-25 Thread GitBox
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951615646 So how do you intend to keep up with changes like https://github.com/apache/maven/pull/602 ? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-gh-actions-shared] olamy merged pull request #14: Update example in readme with v1 branch

2021-10-25 Thread GitBox
olamy merged pull request #14: URL: https://github.com/apache/maven-gh-actions-shared/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [maven-gh-actions-shared] olamy merged pull request #11: Rename workflow to maven-verify

2021-10-25 Thread GitBox
olamy merged pull request #11: URL: https://github.com/apache/maven-gh-actions-shared/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [maven-gh-actions-shared] olamy merged pull request #12: Remove release-drafetr from branch v1

2021-10-25 Thread GitBox
olamy merged pull request #12: URL: https://github.com/apache/maven-gh-actions-shared/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [maven-gh-actions-shared] olamy merged pull request #13: Release drafter - add v* branches

2021-10-25 Thread GitBox
olamy merged pull request #13: URL: https://github.com/apache/maven-gh-actions-shared/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [maven-wrapper-plugin] hboutemy commented on a change in pull request #2: unpack wrapper distribution

2021-10-25 Thread GitBox
hboutemy commented on a change in pull request #2: URL: https://github.com/apache/maven-wrapper-plugin/pull/2#discussion_r735968181 ## File path: src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java ## @@ -128,7 +128,7 @@ public void execute() throws MojoExecutionExc

[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-25 Thread GitBox
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing again is just about copying the 6 partial scripts to `maven-wrapper-distribution/src/assembly/mave

[GitHub] [maven-wrapper-plugin] hboutemy edited a comment on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-25 Thread GitBox
hboutemy edited a comment on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts. on releasing, there is only 1 simultaneous rele

[GitHub] [maven-wrapper-plugin] hboutemy commented on pull request #1: [MWRAPPER-14] put all wrapper pieces in one build

2021-10-25 Thread GitBox
hboutemy commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951301704 I completely value the work done to sync mvn and mvnw: syncing is just about copying the 6 partial scripts. on releasing, there is only 1 simultaneous release for

[GitHub] [maven-wrapper-plugin] rfscholte commented on pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build

2021-10-25 Thread GitBox
rfscholte commented on pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1#issuecomment-951204672 I'm not convinced this is the right thing to do. If you compare the original mvn and mvnw script when it was donated, you should have noticed that they both went their

[GitHub] [maven-wrapper-plugin] rfscholte commented on a change in pull request #2: unpack wrapper distribution

2021-10-25 Thread GitBox
rfscholte commented on a change in pull request #2: URL: https://github.com/apache/maven-wrapper-plugin/pull/2#discussion_r735855180 ## File path: src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java ## @@ -128,7 +128,7 @@ public void execute() throws MojoExecutionEx

[GitHub] [maven-wrapper-plugin] hboutemy opened a new pull request #1: [MWRAPPER-14] first step at putting all wrapper pieces in one build

2021-10-25 Thread GitBox
hboutemy opened a new pull request #1: URL: https://github.com/apache/maven-wrapper-plugin/pull/1 Wrapper consists in 3 pieces: - wrapper (maven-wrapper.jar) - wrapper distribution (mvnw scripts) - wrapper plugin that should have the same version = "the wrapper version" the wr

Re: Upcoming Maven 3.8.4

2021-10-25 Thread Robert Scholte
We're in an awkward situation. It looks like that of all the 3.8.x releases, the first (3.8.1) is the most stable one. The subtitle of Maven 3.8.2 was "Fixes and non-invasive backports from Maven 4.0.0-alpha-1." Looking back it looks like the backports weren't that non-invasive, and we have uni