Re: Another take on [MRESOLVER-7] Download dependency POMs in parallel

2021-10-18 Thread Ivan Babiankou
Hi Tibor, Thanks for getting back to me! I looked at the reverted changes and it seems that the majority of the classes used to pass around data are not really thread safe. Given the size of the change I'm a bit reluctant to try to fix that branch because I'm not sure all of the changes are neede

[GitHub] [maven-gh-actions-shared] olamy commented on pull request #9: Move common flags from maven_args to steps command

2021-10-18 Thread GitBox
olamy commented on pull request #9: URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946302066 @khmarbaise this change really ensure using `--errors --batch-mode --show-version` for every build. still -1? -- This is an automated message from the Apache Git Ser

[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on pull request #9: Move common flags from maven_args to steps command

2021-10-18 Thread GitBox
slawekjaranowski commented on pull request #9: URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946142677 I don't remove it only move ... command will be call as: ``` mvn --errors --batch-mode --show-version ${{ inputs.maven_args }} verify ``` w

[GitHub] [maven-gh-actions-shared] khmarbaise commented on pull request #9: Move common flags from maven_args to steps command

2021-10-18 Thread GitBox
khmarbaise commented on pull request #9: URL: https://github.com/apache/maven-gh-actions-shared/pull/9#issuecomment-946132510 From my point of view this repo contains gh actions for Apache Maven projects...so I would not remove `--errors` nor `--batch-mode` etc. so I'm -1 for that. --

[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request #9: Move common flags from maven_args to steps command

2021-10-18 Thread GitBox
slawekjaranowski opened a new pull request #9: URL: https://github.com/apache/maven-gh-actions-shared/pull/9 This change allow simpler use with other project than maven, which require different profileseg, we can ```yml uses: apache/maven-gh-actions-shared/ with: mave

[GitHub] [maven-artifact-transfer] dependabot[bot] opened a new pull request #49: Bump actions/checkout from 2.3.4 to 2.3.5

2021-10-18 Thread GitBox
dependabot[bot] opened a new pull request #49: URL: https://github.com/apache/maven-artifact-transfer/pull/49 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.4 to 2.3.5. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checko

[GitHub] [maven-site] apeteri commented on pull request #269: [MNGSITE-465] Java Code Convention - import layouts

2021-10-18 Thread GitBox
apeteri commented on pull request #269: URL: https://github.com/apache/maven-site/pull/269#issuecomment-945622992 It is possible to match "everything else" by setting `*` as the package, so the same import order can be set up within Eclipse: ![import_config](https://user-images.gith

[GitHub] [maven-site] slawekjaranowski commented on pull request #269: [MNGSITE-465] Java Code Convention - import layouts

2021-10-18 Thread GitBox
slawekjaranowski commented on pull request #269: URL: https://github.com/apache/maven-site/pull/269#issuecomment-945618941 by the way Eclipse formatter was last updated in 2016 but it is another issue to refresh it -- This is an automated message from the Apache Git Service. To resp

[GitHub] [maven-site] slawekjaranowski commented on pull request #269: [MNGSITE-465] Java Code Convention - import layouts

2021-10-18 Thread GitBox
slawekjaranowski commented on pull request #269: URL: https://github.com/apache/maven-site/pull/269#issuecomment-945616398 I don't use eclipse currently - so I can't confirm if Eclipse format support such things ... Here is kindly request for Eclipse users to verify it. -- This is an

[GitHub] [maven-site] cstamas commented on pull request #269: [MNGSITE-465] Java Code Convention - import layouts

2021-10-18 Thread GitBox
cstamas commented on pull request #269: URL: https://github.com/apache/maven-site/pull/269#issuecomment-945588118 If eclipse code format is like this (as change is about IDEA only), then I think no need for consensus. -- This is an automated message from the Apache Git Service. To respon

Re: Maven Code Style and imports layouts

2021-10-18 Thread Xeno Amess
...if there be a style restriction, adding it to CI is necessary. Benjamin Marwell 于2021年10月18日周一 下午2:28写道: > +1! > > Sandra and I tried similar Suggestions a while back. > This will help new contributors a lot. > > Thanks for your efforts! > > On Mon, 18 Oct 2021, 07:10 Slawomir Jaranowski, >