Re: [VOTE] Release Maven Resolver version 1.7.2

2021-09-10 Thread Michael Osipov
Am 2021-09-08 um 22:27 schrieb Michael Osipov: Hi, We solved 13 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12344271 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20res

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Marc Philipp
Hi Emond and Tibor, I’m glad you discovered the new LauncherSession API which was added for this purpose. The JUnit 5.8 GA release will come in the next few days. As you mentrioned, the official documentation does not (yet!) do a good job of explaining its intended use case: https://junit.org/j

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Tibor Digana
Hi Emond, This section of code is executed for the forkCount > 1 https://github.com/apache/maven-surefire/blob/master/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java#L194-L202 The above part runs if the forkCount is 1. Do

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
Hi Tibor, That's what I implemented, although I couldn't use the fancy try, because of the way the code is structured. The LauncherSession is started by LazyLauncher. This will allow registering a listener for opening and closing the session, given a place for pre and post fixtures. Best regards,

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Tibor Digana
Hi Emond, Are you looking for this? https://github.com/junit-team/junit5/blob/main/documentation/src/test/java/example/UsingTheLauncherDemo.java#L86-L96 On Fri, Sep 10, 2021 at 10:49 PM Emond Papegaaij wrote: > On Fri, Sep 10, 2021 at 9:15 PM Emond Papegaaij > > wrote: > > > On Fri, Sep 10, 20

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 9:15 PM Emond Papegaaij wrote: > On Fri, Sep 10, 2021 at 8:41 PM Christian Stein > wrote: > >> On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij < >> emond.papega...@gmail.com> >> wrote: >> >> For now, I think the LauncherSession is the best way to at least provide >> > som

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 8:41 PM Christian Stein wrote: > On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij > > wrote: > > For now, I think the LauncherSession is the best way to at least provide > > some hooks for pre and post fixtures. It shouldn't be too hard to get > this > > in the current cod

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Tibor Digana
Sorry for typos, I sent it from my mobile. T On Fri, Sep 10, 2021 at 6:18 PM Tibor Digana wrote: > We have to dig into Junit 5. Surefire is a streamer of classes across the > forks which is our load balancer. Therefore each class is running > separately, pre and post fixtures. If the Junit 5 use

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Christian Stein
On Fri, Sep 10, 2021 at 8:27 PM Emond Papegaaij wrote: > [...] For now, I think the LauncherSession is the best way to at least provide > some hooks for pre and post fixtures. It shouldn't be too hard to get this > in the current code base with backwards compatibility for JUnit Platform > 1.7 an

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 6:18 PM Tibor Digana wrote: > We have to dig into Junit 5. Surefire is a streamer of classes across the > forks which is our load balancer. Therefore each class is running > separately, pre and post fixtures. If the Junit 5 used Java Streamer > including dome kind of contr

[GitHub] [maven-site] michael-o commented on pull request #257: run.md: change example to use the "compile" phase

2021-09-10 Thread GitBox
michael-o commented on pull request #257: URL: https://github.com/apache/maven-site/pull/257#issuecomment-917065645 @waldyrious Muito obrigado! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven-site] michael-o merged pull request #257: run.md: change example to use the "compile" phase

2021-09-10 Thread GitBox
michael-o merged pull request #257: URL: https://github.com/apache/maven-site/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [maven-site] waldyrious commented on pull request #257: run.md: change example to use the "compile" phase

2021-09-10 Thread GitBox
waldyrious commented on pull request #257: URL: https://github.com/apache/maven-site/pull/257#issuecomment-917045041 Ok, updated with the changes discussed above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Tibor Digana
We have to dig into Junit 5. Surefire is a streamer of classes across the forks which is our load balancer. Therefore each class is running separately, pre and post fixtures. If the Junit 5 used Java Streamer including dome kind of control of fixtures then web would have this issue. Dňa pi 10. 9.

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
On Fri, Sep 10, 2021 at 5:06 PM Tibor Digana wrote: > If you use forkCount > 1, the Surefire loads test classes via load > balancer. > If you use default forkCount = 0, all the classes are run eagerly as a > suite via JUnit5 Launcher in one shot. > Yes, this is what I saw in the JUnitPlatformPro

[GitHub] [maven-site] michael-o merged pull request #258: Add Gradle Enterprise extension

2021-09-10 Thread GitBox
michael-o merged pull request #258: URL: https://github.com/apache/maven-site/pull/258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[GitHub] [maven-site] michael-o commented on pull request #257: run.md: change example to use the "compile" phase

2021-09-10 Thread GitBox
michael-o commented on pull request #257: URL: https://github.com/apache/maven-site/pull/257#issuecomment-917007266 > > > Well, in [Introduction to the Build Lifecycle § Usual Command Line Calls](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#usual-co

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Tibor Digana
Please read the documentation https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html On Fri, Sep 10, 2021 at 5:05 PM Tibor Digana wrote: > If you use forkCount > 1, the Surefire loads test classes via load > balancer. > If you use default forkCount = 0, all the classes a

Re: JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Tibor Digana
If you use forkCount > 1, the Surefire loads test classes via load balancer. If you use default forkCount = 0, all the classes are run eagerly as a suite via JUnit5 Launcher in one shot. If you are aiming for Arquillian, testing the applications in the application server, you should use maven-fail

[GitHub] [maven-site] waldyrious commented on pull request #257: run.md: change example to use the "compile" phase

2021-09-10 Thread GitBox
waldyrious commented on pull request #257: URL: https://github.com/apache/maven-site/pull/257#issuecomment-916928861 Well, in [Introduction to the Build Lifecycle § Usual Command Line Calls](http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#usual-command-line-ca

[GitHub] [maven-site] marcphilipp commented on pull request #258: Add Gradle Enterprise extension

2021-09-10 Thread GitBox
marcphilipp commented on pull request #258: URL: https://github.com/apache/maven-site/pull/258#issuecomment-916914831 After a discussion on Slack, I created a subsection for commercial extensions. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[ANN] Apache Maven PMD Plugin 3.15.0 Released

2021-09-10 Thread Andreas Dangel
The Maven team is pleased to announce the release of the Apache Maven PMD Plugin, version 3.15.0 A Maven plugin for the PMD toolkit, that produces a report on both code rule violations and detected copy and paste fragments, as well as being able to fail the build based on these metrics. https

[RESULT] [VOTE] Release Apache Maven PMD Plugin version 3.15.0

2021-09-10 Thread Andreas Dangel
Hi, The vote has passed with the following result: +1 : Olivier Lamy, Tamás Cservenák, Robert Scholte, Hervé Boutemy, Arnaud Héritier, Sylwester Lachiewicz, Andreas Dangel PMC quorum: reached. I will promote the artifacts to the central repo. Regards, Andreas ---

Re: Initialisation of a vote for Maven Shade Plugin version 3.3.0

2021-09-10 Thread Andrew Bryan
+1 A new build would greatly improve my life. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

JUnit Platform, forkCount > 1 and the TestPlan

2021-09-10 Thread Emond Papegaaij
Hi all, First of all, sorry for the lengthy post. I decided to add some context to explain things a bit, but it resulted in quite a long e-mail. For the past few weeks I've been trying to come up with a solution for the issue I filled under SUREFIRE-1935, but I'm getting stuck and starting to feel

[GitHub] [maven-site] michael-o commented on pull request #257: run.md: change example to use the "compile" phase

2021-09-10 Thread GitBox
michael-o commented on pull request #257: URL: https://github.com/apache/maven-site/pull/257#issuecomment-916731454 I prefer `clean verify` to complete tests, not to install or package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [VOTE] Release Apache Maven PMD Plugin version 3.15.0

2021-09-10 Thread Arnaud Héritier
+1 On Fri, Sep 10, 2021 at 7:37 AM Hervé BOUTEMY wrote: > +1 > > checked that I could reproduce the build: reference binaries were done > with > JDK 8 on some Unix > > Regards, > > Hervé > > Le lundi 6 septembre 2021, 20:56:25 CEST Andreas Dangel a écrit : > > Hi, > > > > We solved 14 issues: >

Re: [VOTE] Release Maven Resolver version 1.7.2

2021-09-10 Thread Arnaud Héritier
+1 On Fri, Sep 10, 2021 at 8:49 AM Tamás Cservenák wrote: > +1 > > On Wed, Sep 8, 2021, 22:27 Michael Osipov wrote: > > > Hi, > > > > We solved 13 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12344271 > > > > There are still a couple of iss