Re: JPMS, Maven and test jars

2021-06-23 Thread Robert Scholte
>> I would not want it to be log4j-core-tests-3.0.0-SNAPSHOT.jar as that would not be understood to be a test jar. If this artifact is intended for log4j only, consider skipping install/deploy. But then I wonder why there's a need for a module descriptor. If it is intended to be used by users of

Re: Maven 3.8.x

2021-06-23 Thread Robert Scholte
MNG-5669 contains lambda and IIRC there was a follow up improvement by Guillaume. MNG-6824 contains method references. I think both are more improvements than bugs. Before MNG-5669 Maven read a dependency that was also part of the reactor again. Result was the same, just spilling time. Before 

Re: Maven 3.8.x

2021-06-23 Thread Hervé BOUTEMY
IIUC, DefaultModelBuilder fundamental change was done on June 22 2020: https://github.com/apache/maven/commit/bdec668de9c600165bb69c95b6ea0625d9f74fb0 before that point in time, there is no issue, isn't it? then I imagine MNG-5669 and MNG-6824 are safe to cherry pick? Regards, Hervé Le mercredi

Re: [VOTE] Release Maven Doxia version 1.10

2021-06-23 Thread Hervé BOUTEMY
+1 build reproduced, reference build is JDK 8 on Windows Regards, Hervé Le lundi 21 juin 2021, 22:22:58 CEST Michael Osipov a écrit : > Hi, > > We solved 9 issues: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317230&ve > rsion=12346985 > > There are still a couple of i

Re: JPMS, Maven and test jars

2021-06-23 Thread Gary Gregory
Some of the code is shared on the test side just like you shared code on the main side, there is nothing unusual abour that. For example test infrastructure, utilities, JUnit rules, and do on. Gary On Wed, Jun 23, 2021, 02:54 Jochen Wiedmann wrote: > On Tue, Jun 22, 2021 at 9:32 PM Gary Gregory

Re: [VOTE] Release Maven Doxia version 1.10

2021-06-23 Thread Sylwester Lachiewicz
+1 On Mon, Jun 21, 2021, 10:23 PM Michael Osipov wrote: > Hi, > > We solved 9 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317230&version=12346985 > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%2

[GitHub] [maven-site] rjmunro opened a new pull request #240: Use an SPDX identifier in example, as recommended

2021-06-23 Thread GitBox
rjmunro opened a new pull request #240: URL: https://github.com/apache/maven-site/pull/240 The text says: > Using an SPDX identifier as the license name is recommended. But then doesn't use one in the example. I found this confusing. -- This is an automated message from the

Re: Maven 3.8.x

2021-06-23 Thread Robert Scholte
I would avoid cherrypicking any commit related to the DefaultModelBuilder, this is just not the same class anymore. Also don't try to add fixes that has been done with Java 8 features. To make your life easier I would focus on regressions only. So I would at least NOT try to include: - MNG-5669

Re: Maven 3.8.x

2021-06-23 Thread Martin Kanters
I don't have any objections with backporting those bugfixes, but I'm not sure whether MNG-6160 will work without MNG-4660. See Maarten's analysis in the comments [1]. We'll have to re-check that bug when preparing the 3.8.x release. [1] https://issues.apache.org/jira/browse/MNG-6160 Op wo 23 jun.

Maven 3.8.x

2021-06-23 Thread Michael Osipov
Folks, I'd like to proceed with 3.8.x since there are a few issues which users would like to see addressed. I went through the issues in 4.0.0-alpha-1 and would like to evaluate the following to be back ported to 3.8.x branch: https://issues.apache.org/jira/browse/MNG-5669 https://issues.apac

Re: [VOTE] Release Maven Doxia version 1.10

2021-06-23 Thread Michael Osipov
Am 2021-06-21 um 22:22 schrieb Michael Osipov: Hi, We solved 9 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317230&version=12346985 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20DOXIA%20AND%20resoluti