[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

2021-04-29 Thread GitBox
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-829350347 but now to "drop 3.0.x", it is simple as dropping module for 3.0.x :wink: -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #24: [MSHARED-987] Make use of SISU

2021-04-29 Thread GitBox
cstamas commented on pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24#issuecomment-829348216 As mentioned above UTs pass OK The ITs pass, **except for maven 3.0.5**, reason: it seems it was not yet honoring "sisu index" (`META-INF/sisu/javax.inject.Named`

[GitHub] [maven-artifact-transfer] cstamas commented on pull request #23: [MSHARED-987] Drop legacy, prepare for future

2021-04-29 Thread GitBox
cstamas commented on pull request #23: URL: https://github.com/apache/maven-artifact-transfer/pull/23#issuecomment-829236111 Superseded by https://github.com/apache/maven-artifact-transfer/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven-artifact-transfer] cstamas closed pull request #23: [MSHARED-987] Drop legacy, prepare for future

2021-04-29 Thread GitBox
cstamas closed pull request #23: URL: https://github.com/apache/maven-artifact-transfer/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [maven-artifact-transfer] cstamas opened a new pull request #24: [MSHARED-987] Make use of SISU

2021-04-29 Thread GitBox
cstamas opened a new pull request #24: URL: https://github.com/apache/maven-artifact-transfer/pull/24 https://issues.apache.org/jira/browse/MSHARED-987 Drop all the reflection hoops and loops, and organize into api-provider layout. Should have NO IMPACT on consumers. -- This i

[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #23: [MSHARED-987] Drop legacy, prepare for future

2021-04-29 Thread GitBox
rfscholte commented on pull request #23: URL: https://github.com/apache/maven-artifact-transfer/pull/23#issuecomment-829158705 https://github.com/apache/maven-artifact-transfer/tree/master/src/main/java/org/apache/maven/shared/transfer/project this package should be moved to Maven Core (m

Re: [VOTE] Release Apache Maven Shared Utils version 3.3.4

2021-04-29 Thread Martin Kanters
+1 Op do 29 apr. 2021 om 05:46 schreef Olivier Lamy : > +1 > > On Tue, 27 Apr 2021 at 03:59, Maarten Mulders > wrote: > > > Hi, > > > > We solved 6 issues: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12350122&styleName=Text > > > > There are still