[GitHub] [maven-site-plugin] elharo commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r619700755 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +116,8 @@ public void doFilter( ServletRequest servletReq

Re: [VOTE] Release Apache Maven Plugin Tools version 3.6.1

+1 On Fri, Apr 23, 2021 at 2:56 PM Robert Scholte wrote: > Hi, > > We solved 14 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12344365&styleName=Text > > There are still a couple of issues left in JIRA: > > https://issues.apache.org/jira/issues/?jq

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.1.2

+1 On Sun, Apr 25, 2021 at 9:46 PM Michael Osipov wrote: > Hi, > > We solved 3 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317821&version=12349521 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MPIR/issues > > Sta

[VOTE] Release Maven Project Info Reports Plugin version 3.1.2

Hi, We solved 3 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317821&version=12349521 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/projects/MPIR/issues Staging repo: https://repository.apache.org/content/repositories/maven-1642/ ht

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

elharo commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r619862996 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +117,20 @@ public void doFilter( ServletRequest servletRe

[GitHub] [maven-site-plugin] qualitesys commented on a change in pull request #48: [MSITE-872] Set the Content-Type header

qualitesys commented on a change in pull request #48: URL: https://github.com/apache/maven-site-plugin/pull/48#discussion_r619859807 ## File path: src/main/java/org/apache/maven/plugins/site/run/DoxiaFilter.java ## @@ -114,6 +116,8 @@ public void doFilter( ServletRequest servle

Re: JPMS compile problems

Thanks Christian, Thanks to either a good night’s sleep or reading the messages in this thread I realized deleting the module-info.class file generated to create the test jar might fix the problem. It did. After deleting it the compiler only used the class path to run the annotation processor an

Re: JPMS compile problems

On Sun, Apr 25, 2021 at 4:53 PM Apache wrote: > Thanks Christian. I’ve read that blog several times. It helped me > immensely in getting anything to work. You're welcome and glad to hear that it helped you! > However, it doesn’t exactly cover my situation where some of the test > classes need

Re: JPMS compile problems

Thanks Christian. I’ve read that blog several times. It helped me immensely in getting anything to work. However, it doesn’t exactly cover my situation where some of the test classes need to be packaged into their own module for downstream maven modules. That, and the Javac bug on MacOS are what

Re: JPMS compile problems

Yes. My main jar has org.apache.logging.log4j.core and the test jar has org.apache.logging.log4j.core.test. Although IntelliJ is very confused by what I am doing it has no part in this. I only build using maven from the command line. Yes, to get all these compiles to work I have had to move thin

Re: JPMS compile problems

Robert refers to https://sormuras.github.io/blog/2018-09-11-testing-in-the-modular-world Caveat: I didn't look in detail into current Maven's core plugins, like the compiler plugin and/or Surefire/Failsafe. So, things might have changed compared to what I wrote back in 2018. On Sun, Apr 25, 202

Re: JPMS compile problems

Robert, I am not sure what you are getting at with reference to black box and white box testing. I am simply trying to figure out how to get a buildable project. Ralph > On Apr 25, 2021, at 1:40 AM, Robert Scholte wrote: > > I think you need to talk with Christian Stein about blackbox and wh

Re: [VOTE] Release Apache Maven Plugin Tools version 3.6.1

Hi, +1 from me. Kind Regards Karl Heinz Marbaise On 23.04.21 14:56, Robert Scholte wrote: Hi, We solved 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12344365&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.o

Re: [VOTE] Release Apache Maven Plugin Tools version 3.6.1

+1 On 23-4-2021 14:56:00, Robert Scholte wrote: Hi, We solved 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12344365&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317820%

Re: JPMS compile problems

You must have different Java packages in Jar modules in order to have regular JMPS modules. One user of Maven reported a bug against IntelliJ IDEA that the IDE does not understand src/test/java/module-info.java. The only way on how to support one common Java package and two JPMS modules too is to b

Re: JPMS compile problems

I think you need to talk with Christian Stein about blackbox and whitebox testing. Robert On 25-4-2021 08:47:20, Ralph Goers wrote: I am trying to convert Log4j 2 to be fully modularized and am running into problems with Log4j-core. First, I have hit a couple of nasty bugs when compiling on Ma